From c4213744c18be23e3e4484f126ae0b2d0eba4437 Mon Sep 17 00:00:00 2001
From: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
Date: Wed, 2 Oct 2019 16:59:03 +0200
Subject: Migrate pytest to unittest

After a discussion in the core developers channel, we have decided to
migrate from `pytest` to `unittest` as the testing framework. This
commit sets up the repository to use `unittest` and migrates the
first couple of tests files to the new framework.

What I have done to migrate to `unitest`:

- Removed all `pytest` test files, since they are incompatible.

- Removed `pytest`-related dependencies from the Pipfile.

- Added `coverage.py` to the Pipfile dev-packages and relocked.

- Added convenience scripts to Pipfile for running the test suite.

- Adjust to `azure-pipelines.yml` to use `coverage.py` and `unittest`.

- Migrated four test files from `pytest` to `unittest` format.

In addition, I've added five helper Mock subclasses in `helpers.py`
and created a `TestCase` subclass in `base.py` to add an assertion
that asserts that no log records were logged within the context of
the context manager. Obviously, these new utility functions and
classes are fully tested in their respective `test_` files.

Finally, I've started with an introductory guide for writing tests
for our bot in `README.md`.
---
 tests/rules/test_attachments.py | 52 -----------------------------------------
 1 file changed, 52 deletions(-)
 delete mode 100644 tests/rules/test_attachments.py

(limited to 'tests/rules/test_attachments.py')

diff --git a/tests/rules/test_attachments.py b/tests/rules/test_attachments.py
deleted file mode 100644
index 6f025b3cb..000000000
--- a/tests/rules/test_attachments.py
+++ /dev/null
@@ -1,52 +0,0 @@
-import asyncio
-from dataclasses import dataclass
-from typing import Any, List
-
-import pytest
-
-from bot.rules import attachments
-
-
-# Using `MagicMock` sadly doesn't work for this usecase
-# since it's __eq__ compares the MagicMock's ID. We just
-# want to compare the actual attributes we set.
-@dataclass
-class FakeMessage:
-    author: str
-    attachments: List[Any]
-
-
-def msg(total_attachments: int):
-    return FakeMessage(author='lemon', attachments=list(range(total_attachments)))
-
-
-@pytest.mark.parametrize(
-    'messages',
-    (
-        (msg(0), msg(0), msg(0)),
-        (msg(2), msg(2)),
-        (msg(0),),
-    )
-)
-def test_allows_messages_without_too_many_attachments(messages):
-    last_message, *recent_messages = messages
-    coro = attachments.apply(last_message, recent_messages, {'max': 5})
-    assert asyncio.run(coro) is None
-
-
-@pytest.mark.parametrize(
-    ('messages', 'relevant_messages', 'total'),
-    (
-        ((msg(4), msg(0), msg(6)), [msg(4), msg(6)], 10),
-        ((msg(6),), [msg(6)], 6),
-        ((msg(1),) * 6, [msg(1)] * 6, 6),
-    )
-)
-def test_disallows_messages_with_too_many_attachments(messages, relevant_messages, total):
-    last_message, *recent_messages = messages
-    coro = attachments.apply(last_message, recent_messages, {'max': 5})
-    assert asyncio.run(coro) == (
-        f"sent {total} attachments in 5s",
-        ('lemon',),
-        relevant_messages
-    )
-- 
cgit v1.2.3