From f87a53ff442bc10cd2cba87943e40c531e0ce9ba Mon Sep 17 00:00:00 2001
From: Numerlor <25886452+Numerlor@users.noreply.github.com>
Date: Wed, 26 Feb 2020 10:43:38 +0100
Subject: Check for falsy values instead of ``""` and `None` explicitly.

After the change to also check empty strings to avoid unucessary requests, it is no longer necessary to do an explicit value check, as the only values that can come from the .env file are `None` and strings

Co-authored-by: Karlis S <45097959+ks129@users.noreply.github.com>
---
 bot/cogs/reddit.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/bot/cogs/reddit.py b/bot/cogs/reddit.py
index 22e5c2a9c..6d03928e0 100644
--- a/bot/cogs/reddit.py
+++ b/bot/cogs/reddit.py
@@ -290,8 +290,7 @@ class Reddit(Cog):
 
 def setup(bot: Bot) -> None:
     """Load the Reddit cog."""
-    invalid_values = "", None
-    if any(value in (RedditConfig.secret, RedditConfig.client_id) for value in invalid_values):
+    if not RedditConfig.secret or not RedditConfig.client_id:
         log.error("Credentials not provided, cog not loaded.")
         return
     bot.add_cog(Reddit(bot))
-- 
cgit v1.2.3