From d936e5bc049e2e93beca3c62430d048d9f9cf47b Mon Sep 17 00:00:00 2001
From: Numerlor <25886452+Numerlor@users.noreply.github.com>
Date: Wed, 11 Nov 2020 18:23:01 +0100
Subject: Cancel scheduled inventory updates on all refreshes

---
 bot/exts/info/doc/_cog.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/bot/exts/info/doc/_cog.py b/bot/exts/info/doc/_cog.py
index fa59bcc42..822f682bf 100644
--- a/bot/exts/info/doc/_cog.py
+++ b/bot/exts/info/doc/_cog.py
@@ -250,6 +250,8 @@ class DocCog(commands.Cog):
     async def refresh_inventory(self) -> None:
         """Refresh internal documentation inventory."""
         log.debug("Refreshing documentation inventory...")
+        for inventory in self.scheduled_inventories:
+            self.inventory_scheduler.cancel(inventory)
 
         # Clear the old base URLS and doc symbols to ensure
         # that we start from a fresh local dataset.
@@ -418,9 +420,6 @@ class DocCog(commands.Cog):
         """
         await self.bot.api_client.delete(f'bot/documentation-links/{package_name}')
 
-        if package_name in self.scheduled_inventories:
-            self.inventory_scheduler.cancel(package_name)
-
         async with ctx.typing():
             # Rebuild the inventory to ensure that everything
             # that was from this package is properly deleted.
@@ -431,9 +430,6 @@ class DocCog(commands.Cog):
     @commands.has_any_role(*MODERATION_ROLES)
     async def refresh_command(self, ctx: commands.Context) -> None:
         """Refresh inventories and send differences to channel."""
-        for inventory in self.scheduled_inventories:
-            self.inventory_scheduler.cancel(inventory)
-
         old_inventories = set(self.base_urls)
         with ctx.typing():
             await self.refresh_inventory()
-- 
cgit v1.2.3