From c111dd7db591450d62dfa590b11f2fc7078a16e3 Mon Sep 17 00:00:00 2001 From: Matteo Bertucci Date: Sun, 9 May 2021 17:48:19 +0200 Subject: Nomination: simplify history loop Co-authored-by: mbaruh --- bot/exts/recruitment/talentpool/_review.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/bot/exts/recruitment/talentpool/_review.py b/bot/exts/recruitment/talentpool/_review.py index 81c9516ac..b0b9061db 100644 --- a/bot/exts/recruitment/talentpool/_review.py +++ b/bot/exts/recruitment/talentpool/_review.py @@ -136,11 +136,9 @@ class Reviewer: # For that we try to get messages sent in this timeframe until none is returned and NoMoreItems is raised. messages = [message] with contextlib.suppress(NoMoreItems): - while True: - new_message = await message.channel.history( # noqa: B305 - yes flake8, .next() is a thing here. - before=messages[-1].created_at, - after=messages[-1].created_at - timedelta(seconds=2) - ).next() + async for new_message in message.channel.history(before=message.created_at): + if messages[-1].created_at - new_message.created_at > timedelta(seconds=2): + break messages.append(new_message) content = "".join(message_.content for message_ in messages[::-1]) -- cgit v1.2.3