From 8c64fc637dda73cfa4b79d1f3541d067380e51d8 Mon Sep 17 00:00:00 2001
From: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
Date: Fri, 15 Nov 2019 01:02:40 +0100
Subject: Check only for bot's green checkmark in DuckPond

Previously, the presence of any green checkmark as a reaction would
prevent a message from being relayed to the duck pond, regardless of
the actor of that reaction. Since we only want to check if the bot
has already processed this message, we should check for a checkmark
added by the bot.

This commit adds such a user check.
---
 bot/cogs/duck_pond.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/bot/cogs/duck_pond.py b/bot/cogs/duck_pond.py
index 45bbc410b..aac023a2e 100644
--- a/bot/cogs/duck_pond.py
+++ b/bot/cogs/duck_pond.py
@@ -37,12 +37,13 @@ class DuckPond(Cog):
                     return True
         return False
 
-    @staticmethod
-    def has_green_checkmark(message: Message) -> bool:
+    async def has_green_checkmark(self, message: Message) -> bool:
         """Check if the message has a green checkmark reaction."""
         for reaction in message.reactions:
             if reaction.emoji == "✅":
-                return True
+                async for user in reaction.users():
+                    if user == self.bot.user:
+                        return True
         return False
 
     async def send_webhook(
@@ -115,7 +116,7 @@ class DuckPond(Cog):
             return
 
         # Does the message already have a green checkmark?
-        if self.has_green_checkmark(message):
+        if await self.has_green_checkmark(message):
             return
 
         # Time to count our ducks!
-- 
cgit v1.2.3