aboutsummaryrefslogtreecommitdiffstats
path: root/tests (follow)
Commit message (Collapse)AuthorAgeLines
* EH Tests: Created test cases set + already handled error testGravatar ks1292020-05-18-0/+22
| | | | | | Created test that make sure when error is already handled in local error handler, this don't await `ctx.send` to make sure that this don't move forward.
* Use `Command`-object for `send_help`Gravatar Sebastiaan Zeeff2020-05-17-2/+2
| | | | | | | | As @mathsman5133 pointed out, it's better to use the `Command`-instance we typically already have in the current context than to rely on parsing the qualified name again. The invocation is now done as: `await ctx.send_help(ctx.command)`
* Use `send_help` to invoke command helpGravatar Sebastiaan Zeeff2020-05-17-2/+1
| | | | | | | | | | | | | | | | | | | | | | | After the refactoring of the help command, we need to use the built-in method of calling the help command: `Context.send_help`. As an argument, the qualified name (a string containing the full command path, including parents) of the command can be passed. Examples: - await ctx.send_help("reminders edit") This would send a help embed with information on `!reminders edit` to the Context. - await ctx.send_help(ctx.command.qualified_name) This would extract the qualified name of the command, which is the full command path, and send a help embed to Context. - await ctx.send_help() This will send the main "root" help embed to the Context.
* Tests: change avatar_url_as assertion to use static_formatGravatar MarkKoz2020-04-30-1/+1
|
* Add DMChannel tests for in_whitelist decoratorGravatar Sebastiaan Zeeff2020-04-27-31/+63
| | | | | | The `in_whitelist` decorator should not fail when a decorated command was called in a DMChannel; it should simply conclude that the user is not allowed to use the command. I've added a test case that uses a DMChannel context with User, not Member, objects. In addition, I've opted to display a test case description in the `subTest`: Simply printing the actual arguments and context is messy and does not actually show you the information you'd like. This description is enough to figure out which test is failing and what the gist of the test is.
* Add mock for discord.DMChannelsGravatar Sebastiaan Zeeff2020-04-27-0/+21
|
* Exclude never-run lines from coverageGravatar Sebastiaan Zeeff2020-04-27-2/+2
|
* Simplify `in_whitelisted_context` decorator APIGravatar Sebastiaan Zeeff2020-04-23-32/+32
| | | | | | | | | | | | | | | | The API of the `in_whitelisted_context` decorator was a bit clunky: - The long parameter names frequently required multiline decorators - Despite `#bot-commands` being the defacto default, it needed to be passed - The name of the function, `in_whitelisted_context` is fairly long in itself To shorten the call length of the decorator, the parameter names were shortened by dropping the `whitelisted_` prefix. This means that the parameter names are now just `channels`, `categories`, and `roles`. This already means that all current usages of the decorator are reduced to one line. In addition, `#bot-commands` has now been made the default redirect channel for the decorator. This means that if no `redirect` was passed, users will be redirected to `bot-commands` to use the command. If needed, `None` (or any falsey value) can be passed to disable redirection. Passing another channel id will trigger that channel to be used as the redirection target instead of bot-commands. Finally, the name of the decorator was shortened to `in_whitelist`, which already communicates what it is supposed to do.
* Add tests for `in_whitelisted_context` decoratorGravatar Sebastiaan Zeeff2020-04-23-0/+115
| | | | I have added tests for the new `in_whitelisted_context` decorator. They work by calling the decorator with different kwargs to generate a specific predicate callable. That callable is then called to assess if it comes to the right conclusion.
* Remove vestigial kwargs from MockTextChannel.__init__Gravatar Sebastiaan Zeeff2020-04-23-1/+1
|
* Replace `in_channel` decorator by `in_whitelisted_context`Gravatar Sebastiaan Zeeff2020-04-23-2/+2
| | | | | | | | The `in_channel` decorator that served as a factory for `in_channel` checks was replaced by the broaded `in_whitelisted_context` decorator. This means that we can now whitelist commands using channel IDs, category IDs, and/or role IDs. The whitelists will be applied in an "OR" fashion, meaning that as soon as some part of the context happens to be whitelisted, the `predicate` check the decorator produces will return `True`. To reflect that this is now a broader decorator that checks for a whitelisted *context* (as opposed to just whitelisted channels), the exception the predicate raises has been changed to `InWhitelistedContextCheckFailure` to reflect the broader scope of the decorator. I've updated all the commands that used the previous version, `in_channel`, to use the replacement.
* (Syncer Tests): Replaced wrong side effectGravatar ks1292020-04-09-1/+2
| | | Replaced `TimeoutError` with `asyncio.TimeoutError`.
* Set unsilence permissions to inherit instead of trueGravatar Sebastiaan Zeeff2020-03-30-1/+1
| | | | | | The "unsilence" action of the silence/hush command used `send_messages=True` when unsilencing a hushed channel. This had the side effect of also enabling send messages permissions for those with the Muted rule, as an explicit True permission apparently overwrites an explicit False permission, even if the latter was set for a higher top-role. The solution is to revert back to the `Inherit` permission by assigning `None`. This is what we normally use when Developers are allowed to send messages to a channel.
* Merge branch 'master' into hush-cogGravatar Eivind Teig2020-03-30-58/+131
|\
| * Snekbox tests: use `get_code` in `test_continue_eval_does_continue`Gravatar MarkKoz2020-03-25-3/+6
| |
| * Snekbox tests: test `get_code`Gravatar MarkKoz2020-03-25-4/+32
| | | | | | | | | | Should return 1st arg (or None) if eval cmd in message, otherwise return full content.
| * Cog tests: comment some code for clarificationGravatar MarkKoz2020-03-16-0/+3
| |
| * Cog tests: fix error on import due to discord.ext.tasks.loopGravatar MarkKoz2020-03-13-3/+5
| | | | | | | | | | The tasks extensions loop requires an event loop to exist. To work around this, it's been mocked.
| * Cog tests: fix leading space in aliases without parentsGravatar MarkKoz2020-03-13-1/+1
| |
| * Cog tests: add a test for duplicate command names & aliasesGravatar MarkKoz2020-03-13-0/+17
| |
| * Cog tests: fix duplicate commands being yieldedGravatar MarkKoz2020-03-13-1/+2
| | | | | | | | | | discord.py yields duplicate Command objects for each alias a command has, so the duplicates need to be removed on our end.
| * Cog tests: fix nested modules not being foundGravatar MarkKoz2020-03-13-9/+13
| | | | | | | | | | * Rename `walk_extensions` to `walk_modules` because some extensions don't consist of a single module
| * Cog tests: fix duplicate cogs being yieldedGravatar MarkKoz2020-03-13-1/+2
| | | | | | | | Have to check the modules are equal to prevent yielding imported cogs.
| * Cog tests: fix Cog type check in `walk_cogs`Gravatar MarkKoz2020-03-13-3/+3
| |
| * Cog tests: add a function to yield all commandsGravatar MarkKoz2020-03-13-0/+7
| | | | | | | | This will help reduce nesting in the actual test.
| * Cog tests: add a function to get all qualified names for a cmdGravatar MarkKoz2020-03-13-0/+8
| |
| * Cog tests: add a function to get all cogsGravatar MarkKoz2020-03-13-0/+7
| |
| * Cog tests: add a function to get all extensionsGravatar MarkKoz2020-03-13-0/+11
| |
| * Cog tests: add a function to get all commandsGravatar MarkKoz2020-03-09-0/+12
| | | | | | | | | | | | | | | | For tests, ideally creating instances of cogs should be avoided to avoid extra code execution. This function was copied over from discord.py because their function is not a static method, though it still works as one. It was probably just a design decision on their part to not make it static.
| * Cog tests: create boilerplate for command name testsGravatar MarkKoz2020-03-09-0/+7
| |
| * Merge branch 'master' into roles-command-paginationGravatar scragly2020-03-05-48/+11
| |\
| | * Update code for pep8-naming complianceGravatar S. Co12020-03-03-6/+6
| | |
| | * Remove CaseInsensitiveDictGravatar S. Co12020-03-03-37/+0
| | | | | | | | | This was added by the now-removed Snake cog & is not used elsewhere on bot.
| | * Add more pre-commit hooksGravatar MarkKoz2020-03-02-5/+5
| | | | | | | | | | | | | | | * Remove trailing whitespaces * Specify error code for a noqa in the free command
| * | (Information Cog, !roles command test): Removed 's' at end of "Total 1 ↵Gravatar ks1232020-03-05-1/+1
| | | | | | | | | | | | role(s)" due changes in command.
| * | (Information Cog, !roles command test): Applied empty parameter change.Gravatar ks1232020-03-05-1/+1
| | |
| * | Merge branch 'master' into roles-command-paginationGravatar S. Co12020-03-03-512/+196
| |\|
| * | !roles Command Test: Applied !roles command changesGravatar Karlis. S2020-03-01-3/+2
| | |
* | | Add tests for `HushDurationConverter`.Gravatar Numerlor2020-03-17-0/+30
| | |
* | | Add tests ensuring permissions get preserved.Gravatar Numerlor2020-03-17-0/+31
| | |
* | | Use set `discard` instead of `remove`.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | | | | Discard ignores non present values, allowing us to skip the KeyError suppress.
* | | Add docstring to test.Gravatar Numerlor2020-03-17-0/+1
| | |
* | | Fix test name.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | `removed` was describing the opposite behaviour.
* | | Remove `alert_channel` mention from docstring.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | | | | After removing the optional channel arg and changing output message channels we're only testing `ctx`'s `send`.
* | | Remove one indentation level.Gravatar Numerlor2020-03-17-3/+3
| | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
* | | Rename `cog_unload` tests.Gravatar Numerlor2020-03-17-2/+2
| | | | | | | | | | | | Previous names were undescriptive from testing phases.
* | | Fix `test_cog_unload` passing tests with invalid values.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | | | | | | | | | | The first assert - `asyncio_mock.create_task.assert_called_once_with` called `alert_channel`'s send resulting in an extra call. `send` on `alert_channel` was not tested properly because of a typo and a missing assert in the method call.
* | | Set `_get_instance_vars_event` in test's `setUp`.Gravatar Numerlor2020-03-15-0/+2
| | |
* | | Adjust tests for new calling behaviour.Gravatar Numerlor2020-03-15-2/+2
| | | | | | | | | | | | | | | `.set_permissions` calls were changed to use kwargs directly instead of an overwrite, this reflects the changes in tests.
* | | Use dict instead of a set and custom class.Gravatar Numerlor2020-03-15-25/+3
| | | | | | | | | | | | | | | The FirstHash class is no longer necessary with only channels and the current loop in tuples. FirstHash was removed, along with its tests and tests were adjusted for new dict behaviour.