aboutsummaryrefslogtreecommitdiffstats
path: root/tests (follow)
Commit message (Collapse)AuthorAgeLines
* Incidents tests: write tests for `on_raw_reaction_add`Gravatar kwzrd2020-06-19-0/+128
|
* Incidents tests: write tests for `crawl_incidents`Gravatar kwzrd2020-06-19-0/+58
|
* Incidents tests: add helper for mocking async for-loopsGravatar kwzrd2020-06-19-0/+37
| | | | | | See the docstring. This does not make the ambition to be powerful enough to be included in `tests.helpers`, and is only intended for local purposes.
* Merge branch 'origin/master' into kwzrd/incidentsGravatar kwzrd2020-06-19-107/+302
|\
| * Merge branch 'master' into help_channel_rediscacheGravatar Kieran Siek2020-06-16-167/+361
| |\
| | * Merge pull request #937 from python-discord/bug/filters/928/non-ascii-tokenGravatar Mark2020-06-12-102/+285
| | |\ | | | | | | | | Make token detection more robust and completely rewrite its tests
| | | * Merge remote-tracking branch 'origin/master' into ↵Gravatar MarkKoz2020-06-02-40/+645
| | | |\ | | | | | | | | | | | | | | | bug/filters/928/non-ascii-token
| | | * | Token remover: remove the `delete_message` functionGravatar MarkKoz2020-06-02-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | It's redundant; there's no benefit here in abstracting two lines of code into a function.
| | | * | Test find_token_in_message returns None for invalid matchesGravatar MarkKoz2020-05-28-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | This covers the case when a token is matched, but its user ID and timestamp turn out to be invalid.
| | | * | Adjust find_token_in_message tests for the recent cog changesGravatar MarkKoz2020-05-28-19/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It now supports the changes that switched to finditer, added match groups, and added the Token NamedTuple. It also accounts for the is_maybe_token function being removed. For the sake of simplicity, call assertions on is_valid_user_id and is_valid_timestamp were not made.
| | | * | Remove is_maybe_token testsGravatar MarkKoz2020-05-28-33/+0
| | | | | | | | | | | | | | | | | | | | | | | | | The function was removed due to redundancy. Therefore, its tests are obsolete.
| | | * | Add more thorough and realistic inputs for token ID and timestamp testsGravatar MarkKoz2020-05-27-18/+52
| | | | | | | | | | | | | | | | | | | | | | | | | The tests for valid inputs and invalid inputs were split to make them more readable.
| | | * | Adjust token remover tests to use the Token NamedTupleGravatar MarkKoz2020-05-27-6/+8
| | | | |
| | | * | Switch findall to finditer in assertionsGravatar MarkKoz2020-05-27-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | `find_token_in_message` now uses the latter so the tests should adjust accordingly.
| | | * | Use real token values for testing multiple matches in regexGravatar MarkKoz2020-05-25-3/+4
| | | | |
| | | * | Fix multiple match text for token regexGravatar MarkKoz2020-05-25-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It has to account for the addition of groups. It's easiest to compare the entire string so `finditer` is used to return re.Match objects; the tuples of `findall` would be cumbersome. Also threw in a change to use `assertCountEqual` cause the order doesn't really matter.
| | | * | Fix valid token regex testGravatar MarkKoz2020-05-25-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was broken due to the addition of groups. Rather than returning the full match, `findall` returns groups if any exist. The test was comparing a tuple of groups to the token string, which was of course failing. Now `fullmatch` is used cause it's simpler - just check for `None` and don't worry about iterating matches to search.
| | | * | Add more valid tokens to test the regex withGravatar MarkKoz2020-05-25-3/+5
| | | | |
| | | * | Test token regex won't match non-base64 charactersGravatar MarkKoz2020-05-25-4/+3
| | | | |
| | | * | Fix a test needlessly being a coroutineGravatar MarkKoz2020-05-13-1/+1
| | | | |
| | | * | Use subtests for valid ID/timestamp tests and test non-ASCII inputsGravatar MarkKoz2020-05-11-18/+25
| | | | |
| | | * | Clean up token remover test importsGravatar MarkKoz2020-05-11-16/+12
| | | | |
| | | * | Replace deprecated assertion methodsGravatar MarkKoz2020-05-11-2/+2
| | | | |
| | | * | Refactor `TokenRemoverSetupTests` and add a more thorough testGravatar MarkKoz2020-05-11-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | The test now ensures the cog is instantiated and that the instance is passed as an argument to `add_cog`.
| | | * | Test TokenRemover.take_actionGravatar MarkKoz2020-05-11-43/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove `bot.get_cog` mocks in `setUp` * Mock the logger cause it's easier to assert logs * Remove subtests * Assert helper functions were called * Create an autospec for ModLog
| | | * | Test TokenRemover.format_log_messageGravatar MarkKoz2020-05-11-0/+16
| | | | |
| | | * | Test token remover's message deletionGravatar MarkKoz2020-05-11-0/+9
| | | | |
| | | * | Simplify token remover's message mockGravatar MarkKoz2020-05-11-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | * Rely on default values for the author * Set the content to a non-empty string
| | | * | Avoid instantiating the cog when testing static/class methodsGravatar MarkKoz2020-05-11-10/+5
| | | | |
| | | * | Correct the return type annotation for the autospec decoratorGravatar MarkKoz2020-05-11-2/+2
| | | | |
| | | * | Test token regex matches valid tokensGravatar MarkKoz2020-05-11-0/+21
| | | | |
| | | * | Test is_maybe_tokenGravatar MarkKoz2020-05-11-7/+24
| | | | |
| | | * | Test `is_maybe_token` returns False for missing partsGravatar MarkKoz2020-05-11-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In practice, this won't ever happen since the regex wouldn't match strings with missing parts. However, the function does check it so may as well test it. It's not necessarily bound to always use inputs from the regex either I suppose.
| | | * | Fix autospec decorator when used with multiple attributesGravatar MarkKoz2020-05-11-16/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original approach of messing with the `attribute_name` didn't work for reasons I won't discuss here (would require knowledge of patcher internals). The new approach doesn't use patch.multiple but mimics it by applying multiple patch decorators to the function. As a consequence, this can no longer be used as a context manager.
| | | * | Test token regex doesn't match invalid tokensGravatar MarkKoz2020-05-11-7/+25
| | | | |
| | | * | Test `find_token_in_message` returns the found tokenGravatar MarkKoz2020-05-11-0/+24
| | | | |
| | | * | Test `find_token_in_message` returns None if no matches foundGravatar MarkKoz2020-05-11-0/+14
| | | | |
| | | * | Fix test for token remover ignoring bot messagesGravatar MarkKoz2020-05-11-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's not possible to test this via asserting the return value of `on_message` since it never returns anything. Instead, the actual relevant unit, `find_token_in_message,` should be tested.
| | | * | Allow using arbitrary parameter names with the autospec decoratorGravatar MarkKoz2020-05-11-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | This gives the caller more flexibility. Sometimes attribute names are too long or they don't follow a naming scheme accepted by the linter.
| | | * | Test token remover skips messages without tokensGravatar MarkKoz2020-05-11-0/+11
| | | | |
| | | * | Test token remover takes action if a token is foundGravatar MarkKoz2020-05-11-1/+13
| | | | |
| | | * | Add a test helper function to patch multiple attributes with autospecsGravatar MarkKoz2020-05-11-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helper reduces redundancy/boilerplate by setting default values. It also has the consequence of shortening the length of the invocation, which makes it faster to use and easier to read.
| | | * | Test on_message_edit of token remover uses on_messageGravatar MarkKoz2020-05-11-2/+10
| | | | |
| | * | | Merge pull request #978 from ItsDrike/unsilence-schedulerGravatar Mark2020-06-12-4/+14
| | |\ \ \ | | | | | | | | | | | | Use Scheduler instead of asyncio.sleep on silence cog
| | | * | | Test for channel not silenced messageGravatar ItsDrike2020-06-06-4/+14
| | | | | |
| * | | | | Merge branch 'master' into help_channel_rediscacheGravatar Leon Sandøy2020-06-06-9/+8
| |\ \ \ \ \
| * | | | | | Add support for bool values in RedisCacheGravatar Leon Sandøy2020-05-31-1/+3
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | We're gonna need this for the help channel handling, and it seems like a reasonable type to support anyway. It requires a tiny bit of special handling, but nothing outrageous.
* | | | | | Incidents tests: write tests for `process_event`Gravatar kwzrd2020-06-18-1/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also breaks the helpers import statement into a vertical list, as the amount of imports has grown too much. I still believe that this is a preferred alternative to accessing the helpers via module namespace, as we use them a lot, and the added visual noise would be annoying to read - their names are already descriptive enough.
* | | | | | Incidents tests: write tests for `make_confirmation_task`Gravatar kwzrd2020-06-13-0/+35
| | | | | |
* | | | | | Incidents tests: write tests for `on_message`Gravatar kwzrd2020-06-13-0/+27
| | | | | |