bot - A mirrored copy of the python-discord/bot repository.

	Commit message (Collapse)	Author	Age	Lines
...
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for rescheduling active silences	MarkKoz	2020-08-18	-0/+29
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: test the rescheduler unsilences expired silences	MarkKoz	2020-08-18	-0/+14
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: test the rescheduler adds permanent silence to notifier	MarkKoz	2020-08-18	-0/+14
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: test the scheduler skips missing channels	MarkKoz	2020-08-18	-0/+25
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for _init_cog rescheduling unsilences	MarkKoz	2020-08-18	-0/+7
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: remove _reschedule patch for cog tests	MarkKoz	2020-08-18	-4/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	They don't do anything because they patch the class rather than the instance. It's too late for patching the instance to work since the `setUp` fixture, which instantiates the cog, executes before the patches do. Patching `setUp` would work (and its done in the other test cases), but some tests in this case will need the unpatched function too. Patching it doesn't serve much benefit to most tests anyway, so it's not worth the effort trying to make them work where they aren't needed.
* \| \| \| \| \| \| \| \| \|	Silence tests: access everything via the silence module	MarkKoz	2020-08-18	-24/+23
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The module is imported anyway to keep imports short and clean. Using it in patch targets is shorter and allows for the two imports from the module to be removed.
* \| \| \| \| \| \| \| \| \|	Silence tests: add a subtest for the manual unsilence message	MarkKoz	2020-08-17	-4/+7
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: assert against message constants	MarkKoz	2020-08-17	-6/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Duplicating strings in assertions is redundant, closely coupled, and less maintainable.
* \| \| \| \| \| \| \| \| \|	Silence tests: also test that cache misses preserve other overwrites	MarkKoz	2020-08-17	-12/+16
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for a mod alert on cache miss	MarkKoz	2020-08-17	-0/+7
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for default overwrites on cache miss	MarkKoz	2020-08-17	-4/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use a False for `add_reactions` in the mock overwrite rather than None to be sure the default (also None) is actually set for it. Fix channels set by `_init_cog` not being mocked properly.
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for task cancellation	MarkKoz	2020-08-17	-0/+5
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for deletion from the time cache	MarkKoz	2020-08-17	-0/+5
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add tests for scheduling tasks	MarkKoz	2020-08-17	-0/+12
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for caching permanent times	MarkKoz	2020-08-17	-0/+6
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: add a test for the time cache	MarkKoz	2020-08-17	-0/+15
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix mock for _init_task	MarkKoz	2020-08-17	-2/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	An `AsyncMock` fails because it returns a coroutine which may only be awaited once. However, an `asyncio.Future` is perfect because it is easy to create and can be awaited repeatedly, just like the actual `asyncio.Task` that is being mocked.
* \| \| \| \| \| \| \| \| \|	Silence tests: create channel and overwrite in setUp for silence tests	MarkKoz	2020-08-17	-29/+17
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Reduce code redundancy by only defining them once.
* \| \| \| \| \| \| \| \| \|	Silence tests: merge unsilence fixture into setUp	MarkKoz	2020-08-17	-32/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Now that there are separate test cases, there's no need to keep the fixtures separate.
* \| \| \| \| \| \| \| \| \|	Silence tests: autospec _reschedule and SilenceNotifier for cog tests	MarkKoz	2020-08-17	-4/+10
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: separate test cases; refactor names & docstrings	MarkKoz	2020-08-17	-71/+95
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix tests for _unsilence	MarkKoz	2020-08-17	-30/+45
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add a fixture to set up mocks for a successful `unsilence` call. This reduces code redundancy.
* \| \| \| \| \| \| \| \| \|	Silence tests: fix test_unsilence_private_removed_notifier	MarkKoz	2020-08-17	-2/+5
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix overwrite preservation test for silences	MarkKoz	2020-08-17	-11/+15
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix command message tests	MarkKoz	2020-08-17	-15/+10
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix test_silence_private_for_false	MarkKoz	2020-08-17	-4/+13
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix test_silence_private_silenced_channel	MarkKoz	2020-08-17	-3/+10
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix test_silence_private_notifier	MarkKoz	2020-08-17	-0/+3
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix test_unsilence_private_for_false	MarkKoz	2020-08-17	-1/+4
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: fix silence cache test for overwrites	MarkKoz	2020-08-17	-5/+8
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: replace obsolete cog_unload tests	MarkKoz	2020-08-17	-13/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Moderation notifications are no longer sent so that doesn't need to be tested.
* \| \| \| \| \| \| \| \| \|	Silence tests: rename test_instance_vars to test_init_cog	MarkKoz	2020-08-17	-5/+5
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Silence tests: mock RedisCaches	MarkKoz	2020-08-17	-3/+2
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Tests: optionally prevent autospec helper from passing mocks	MarkKoz	2020-08-17	-19/+66
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Not everything that's decorated needs the mocks that are patched. Being required to add the args to the test function anyway is annoying. It's especially bad if trying to decorate an entire test suite, as every test would need the args. Move the definition to a separate module to keep things cleaner.
* \| \| \| \| \| \| \| \| \|	Silence: rename _get_instance_vars to _init_cog	MarkKoz	2020-08-16	-4/+4
\|/ / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's a more accurate name since it also reschedules unsilences now.
* \| \| \| \| \| \| \| \|	Merge branch 'master' into whitelist_system	Leon Sandøy	2020-08-03	-3/+946
\|\ \ \ \ \ \ \ \ \ \| \| \|/ / / / / / / \| \|/\| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	Jam tests: use the MAX_CHANNELS constant more	MarkKoz	2020-07-22	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's clearer to write MAX_CHANNELS - 2 than a literal 48.
\| * \| \| \| \| \| \| \|	Jam tests: assert equality of new category	MarkKoz	2020-07-22	-1/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	Jam tests: add subtests to non-existent category test	MarkKoz	2020-07-22	-7/+18
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The test has to account for not only the name not matching, but also a lack of available spaces for new channels.
\| * \| \| \| \| \| \| \|	Jam tests: fix category test	MarkKoz	2020-07-22	-14/+24
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	Merge branch 'master' into jam-test	Mark	2020-07-22	-185/+1384
\| \|\\| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Edited tests to reflect changes (removed py formatting)	wookie184	2020-07-20	-3/+3
\| \| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Merge 'master' into 'kwzrd/incidents'; resolve config conflicts	kwzrd	2020-07-16	-39/+24
\| \| \|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add upstream changes & resolve config conflicts introduced by #1041. In the conflicting parts of the diff, this commit also re-sorts constants which were added upstream to lexicographical order. This does not re-sort all constants added upstream.
\| \| * \| \| \| \| \| \| \|	Incidents: reduce log level of 404 exception	kwzrd	2020-07-16	-2/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: MarkKoz <[email protected]>
\| \| * \| \| \| \| \| \| \|	Incidents: link `proxy_url` if attachment fails to download	kwzrd	2020-07-14	-37/+36
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Suggested by Mark during review. If the download fails, we fallback on showing an informative message, which will link the attachment cdn link. The attachment-handling logic was moved from the `archive` coroutine into `make_embed`, which now also returns the file, if available. In the end, this appears to be the smoothest approach. Co-authored-by: MarkKoz <[email protected]>
\| \| * \| \| \| \| \| \| \|	Incidents: add `download_file` helper & tests	kwzrd	2020-07-13	-0/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: MarkKoz <[email protected]>
\| \| * \| \| \| \| \| \| \|	Incidents tests: improve in-line comment wording	kwzrd	2020-07-09	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: MarkKoz <[email protected]>
\| \| * \| \| \| \| \| \| \|	Merge 'master' into 'kwzrd/incidents'; resolve mod pkg init conflict	kwzrd	2020-07-08	-24/+242
\| \| \|\ \ \ \ \ \ \ \
\| \| * \| \| \| \| \| \| \| \|	Incidents: archive incident attachments	kwzrd	2020-07-03	-0/+30
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	There is no handling of file types as explained in the `archive` docstring. Testing indicates that relaying incidents with e.g. a text file attachment is simply a noop in the Discord GUI. If there is at least one attachment, we always only relay the one at index 0, as it is believed the user-sent messages can only contain one attachment at maximum. This also adds an extra test asserting the behaviour when an incident with an attachment is archived. The existing test for `archive` is adjusted to assume no attachments. Joe helped me conceive & test this. Co-authored-by: Joseph Banks <[email protected]>