aboutsummaryrefslogtreecommitdiffstats
path: root/tests (follow)
Commit message (Collapse)AuthorAgeLines
* Cog tests: add a function to yield all commandsGravatar MarkKoz2020-03-13-0/+7
| | | | This will help reduce nesting in the actual test.
* Cog tests: add a function to get all qualified names for a cmdGravatar MarkKoz2020-03-13-0/+8
|
* Cog tests: add a function to get all cogsGravatar MarkKoz2020-03-13-0/+7
|
* Cog tests: add a function to get all extensionsGravatar MarkKoz2020-03-13-0/+11
|
* Cog tests: add a function to get all commandsGravatar MarkKoz2020-03-09-0/+12
| | | | | | | | For tests, ideally creating instances of cogs should be avoided to avoid extra code execution. This function was copied over from discord.py because their function is not a static method, though it still works as one. It was probably just a design decision on their part to not make it static.
* Cog tests: create boilerplate for command name testsGravatar MarkKoz2020-03-09-0/+7
|
* Merge branch 'master' into roles-command-paginationGravatar scragly2020-03-05-48/+11
|\
| * Update code for pep8-naming complianceGravatar S. Co12020-03-03-6/+6
| |
| * Remove CaseInsensitiveDictGravatar S. Co12020-03-03-37/+0
| | | | | | This was added by the now-removed Snake cog & is not used elsewhere on bot.
| * Add more pre-commit hooksGravatar MarkKoz2020-03-02-5/+5
| | | | | | | | | | * Remove trailing whitespaces * Specify error code for a noqa in the free command
* | (Information Cog, !roles command test): Removed 's' at end of "Total 1 ↵Gravatar ks1232020-03-05-1/+1
| | | | | | | | role(s)" due changes in command.
* | (Information Cog, !roles command test): Applied empty parameter change.Gravatar ks1232020-03-05-1/+1
| |
* | Merge branch 'master' into roles-command-paginationGravatar S. Co12020-03-03-512/+196
|\|
| * Modify log test regex to be non-os-specificGravatar S. Co12020-03-01-1/+1
| | | | | | Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
| * Migrate snekbox tests to Python 3.8's unittestGravatar Sebastiaan Zeeff2020-02-29-41/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks. In particular, I had to make a few changes: - Mocking the async post() context manager correctly Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called). - Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with` Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited. - Patch `functools.partial` as `partial` objects are compared by identity When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
| * Merge branch 'master' into python38-migrationGravatar Sebastiaan Zeeff2020-02-29-23/+376
| |\ | | | | | | | | | I've resolved the merge conflict by confirming the deleted part of tests/helpers.py
| * | Use MagicMock as return value for _get_diff mockGravatar Sebastiaan Zeeff2020-02-24-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `_get_diff` method of TestSyncer class is mocked using an AsyncMock object. By default, when an AsyncMock object is called **and awaited**, it returns a child mock of the same time (another AsyncMock) according to the "the child is a like the parent" principle. This means that the _get_diff method will return an AsyncMock unless a different return_value is explicitly provided. Because of that "child is like parent" behavior, this will happen in lines 194-196 of bot.cogs.sync.syncers (annotations added by me): ``` // `diff` will be a child AsyncMock as "child is like parent" diff = await self._get_diff(guild) // `diff._asdict` will be an AsyncMock as "child is like parent" and, // after being called, it will return an unawaited coroutine object // we assign the name `diff_dict`: diff_dict = diff._asdict() // `diff_dict` is still an unawaited coroutine object meaning that it // doesn't have an `items()` method: totals = {k: len(v) for k, v in diff_dict.items() if v is not None} ``` Original, unannotated: https://github.com/python-discord/bot/blob/c81a4d401ea434e98b0a1ece51d3d10f1a3ad226/bot/cogs/sync/syncers.py#L194-L196 This will lead to the following exception when running the tests: ```py ====================================================================== ERROR: test_sync_confirmation_context_redirect (tests.bot.cogs.sync.test_base.SyncerSyncTests) (ctx=None, author=<MockMember name='mock.user' spec_set='Member' id='140583452034864'>, message=None) If ctx is given, a new message should be sent and author should be ctx's author. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/sebastiaan/pydis/repositories/bot/tests/bot/cogs/sync/test_base.py", line 348, in test_sync_confirmation_context_redirect await self.syncer.sync(guild, ctx) File "/home/sebastiaan/pydis/repositories/bot/bot/cogs/sync/syncers.py", line 196, in sync totals = {k: len(v) for k, v in diff_dict.items() if v is not None} AttributeError: 'coroutine' object has no attribute 'items' ``` The solution is to assign an explicit return value so the parent mock doesn't "guess" and return an object of its own type. I previously did that by providing a specific `_Diff` object as the return value, but I should have gone with a `MagicMock` to signify that it's not an important return value; it's just something that needs to support/mimic the API we use on it. So that's what this commit adds.
| * | Sync tests: use autospec instead of MockSyncerGravatar MarkKoz2020-02-23-18/+4
| | | | | | | | | | | | | | | Autospec supports using AsyncMocks in 3.8 so there's no need to rely on a subclass of CustomMockMixin for the async mocks.
| * | Migrate syncers test suite to Python 3.8Gravatar Sebastiaan Zeeff2020-02-24-75/+34
| | | | | | | | | | | | The test suite for the new role/member syncers used the "old"-style test suite with the helpers implemented for Python 3.7. I have migrated it to use the new Python 3.8 asyncio test helpers.
| * | Use realistic mixin implementationGravatar Sebastiaan Zeeff2020-02-24-1/+1
| | | | | | | | | | | | Instead of using the mixin class bare, I've now included into a class tha subclasses unittest.TestCase as that's how it's going to be used "in the wild".
| * | Merge branch 'master' into python38-migrationGravatar Sebastiaan Zeeff2020-02-24-210/+1198
| |\ \
| * | | Fix test_time test and ensure coverageGravatar Sebastiaan Zeeff2020-02-23-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | One of the test_time methods did not actually assert the exception message it was trying to detect as the assertion statement was contained within the context manager handling the exception. I've moved it out of the context so it actually runs. I've also added a few `praga: no cover` comments for parts that were artifically lowering coverage of the test suite.
| * | | Use unittest's AsyncMock instead of our AsyncMockGravatar Sebastiaan Zeeff2020-02-23-213/+103
| | | | | | | | | | | | | | | | | | | | | | | | Python 3.8 introduced an `unittest.mock.AsyncMock` class that can be used to mock coroutines and other types of asynchronous operations like async iterators and async context managers. As we were using our custom, but limited, AsyncMock, I have replaced our mock with unittest's AsyncMock. Since Python 3.8 also introduces a different way of automatically detecting which attributes should be mocked with an AsyncMock, I've changed our CustomMockMixin to use this new method as well. Together with a couple other small changes, this means that our Custom Mocks now use a lazy method of detecting coroutine attributes, which significantly speeds up the test suite.
| * | | Remove lingering pytest test_time.py fileGravatar Sebastiaan Zeeff2020-02-23-62/+0
| | | | | | | | | | | | | | | | I forgot to remove one pytest test file during the migration from pytest to unittest. Since we have sinced added a unittest version of the same file, I've now removed the lingering pytest file.
| * | | Use IsolatedAsyncioTestCase instead of async_testGravatar Sebastiaan Zeeff2020-02-23-70/+13
| | | | | | | | | | | | | | | | Since we upgraded to Python 3.8, we can now use the new IsolatedAsyncioTestCase test class to use coroutine-based test methods instead of our own, custom async_test decorator. I have changed the base class for all of our test classes that use coroutine-based test methods and removed the now obsolete decorator from our helpers.
| * | | Use mixin-composition not inheritance for LoggingTestCaseGravatar Sebastiaan Zeeff2020-02-23-16/+14
| | | | | | | | | | | | | | | | | | | | | | | | We used inheritence to add additional logging assertion methods to unittest's TestCase class. However, with the introduction of the new IsolatedAsyncioTestCase this extension strategy means we'd have to create multiple child classes to be able to use the extended functionality in all of the TestCase variants. Since that leads to undesirable code reuse and an inheritance relationship is not at all needed, I've switched to a mixin-composition based approach that allows the user to extend the functionality of any TestCase variant with a mixin where needed.
* | | | !roles Command Test: Applied !roles command changesGravatar Karlis. S2020-03-01-3/+2
| |_|/ |/| |
* | | Merge branch 'master' into fuzzy_zero_divGravatar Shirayuki Nekomata2020-02-29-0/+380
|\ \ \
| * \ \ Merge remote-tracking branch 'origin/master' into eval-enhancementsGravatar MarkKoz2020-02-28-471/+1844
| |\ \ \
| * | | | Return only the new code in continue_eval and check for truthiness insteadGravatar Matteo2020-02-28-4/+4
| | | | |
| * | | | Use unicode code point instead of literal for the snekbox re-eval emojiGravatar Matteo2020-02-27-3/+3
| | | | | | | | | | | | | | | | | | | | Unicode literals aren't really safe compared to code points
| * | | | Split the eval command procedure into two functions.Gravatar Matteo2020-02-27-69/+81
| | | | | | | | | | | | | | | | | | | | Two functions were created: send_eval and continue_eval, in order to facilitate testing. The corresponding tests are also changed in this commit.
| * | | | Merge branch 'master' into eval-enhancementsGravatar Matteo Bertucci2020-02-18-1/+8
| |\ \ \ \
| * | | | | Use kwargs to set mock attributesGravatar Matteo2020-02-18-25/+11
| | | | | |
| * | | | | Assert return value of Snekbox.post_evalGravatar Matteo2020-02-18-1/+3
| | | | | |
| * | | | | Use a space instead of an empty string in test_get_status_emoji Gravatar Matteo Bertucci2020-02-18-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because of the stripping, it should still be considered as empty Co-Authored-By: Mark <[email protected]>
| * | | | | Delete additional informations from subtest Gravatar Matteo Bertucci2020-02-18-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reduce visual clutter Co-Authored-By: Mark <[email protected]>
| * | | | | Split assertions onto separate lines Gravatar Matteo Bertucci2020-02-18-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reads better as separate lines Co-Authored-By: Mark <[email protected]>
| * | | | | Split assertion onto separate linesGravatar Matteo Bertucci2020-02-18-1/+2
| | | | | | | | | | | | | | | | | | Co-Authored-By: Mark <[email protected]>
| * | | | | Write tests for bot/cogs/test_snekbox.pyGravatar Akarys422020-02-09-0/+363
| | | | | |
| * | | | | Create an AsyncContextManagerMock mock for testing asynchronous context managersGravatar Akarys422020-02-09-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | It can be used to test aiohttp request functions, since they are async context managers
* | | | | | Merge branch 'master' into fuzzy_zero_divGravatar Numerlor2020-02-28-7/+7
|\ \ \ \ \ \ | | |_|/ / / | |/| | | | | | | | | | | | | | | | # Conflicts: # bot/cogs/error_handler.py
| * | | | | Merge branch 'master' into feat/backend/b496/rename-constantsGravatar Leon Sandøy2020-02-28-15/+0
| |\ \ \ \ \
| * | | | | | Fix mismatched constant names in syncer testsGravatar S. Co12020-02-25-2/+2
| | | | | | |
| * | | | | | Merge branch 'master' into feat/backend/b496/rename-constantsGravatar S. Co12020-02-25-205/+1197
| |\ \ \ \ \ \ | | | |_|_|_|/ | | |/| | | |
| * | | | | | Tests: fix setting bot-commands ID in information testsGravatar MarkKoz2020-02-23-4/+4
| | | | | | |
| * | | | | | Constants: rename roles to match their names in the guildGravatar MarkKoz2020-02-23-1/+1
| | |_|_|_|/ | |/| | | |
* | | | | | Merge branch 'master' into fuzzy_zero_divGravatar Sebastiaan Zeeff2020-02-27-15/+0
|\ \ \ \ \ \ | | |_|/ / / | |/| | | |
| * | | | | Merge branch 'master' into channel_constants_checkGravatar Numerlor2020-02-25-205/+1197
| |\ \ \ \ \ | | | |/ / / | | |/| | |
| * | | | | Remove unused `chunks` function and its tests.Gravatar Numerlor2020-02-24-15/+0
| | |/ / / | |/| | | | | | | | | | | | | The function was only used in the since removed `Events` cog.
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-25 06:24:50 +0000