| Commit message (Collapse) | Author | Lines |
|
Bug: When asking for a review for a user that isn't currently nominated
using the `!talentpool get_review <userid>` command, the user is added
to the talentpool `watched_users` cache, causing their messages to be
relayed to the talentpool watch channel.
Steps to reproduce: Use `!talentpool get_review <user_id>`, where
`<user_id>` is the ID of a user not currently nominated. The command
will correctly reply that the user isn't nominated, but their ID will be
added as a key to the defaultdict nonetheless.
Solution: replace all regular getitem usages with `.get(<user_id>)`, as
the Reviewer should never insert IDs using the regular defaultdict path.
Additional note: I've replaced all occurrences of regular getitem access
into the defaultdict, even those that are normally not reachable with
the id of a user that's currently not nominated, to prevent a future
refactor from accidentally introducing this bug again.
|
|
users twice
|
|
|
|
|
|
Celebrities:
- The Weeknd
- Ringo Starr
- John Lennon
- Guido Van Rossum
- George Harrison
- Darude
|
|
|
|
Co-authored-by: Boris Muratov <[email protected]>
|
|
|
|
|
|
|
|
|
|
Just cause a URL looks valid doesn't mean it will be valid, so a 404
is a normal and harmless error.
Fixes #1553
Fixes BOT-Z4
Fixes BOT-Z8
Fixes BOT-Z9
|
|
Move the exception handling to `on_message` to avoid writing a lot of
None checks; `_fetch_response` is used multiple times in various places.
Fixes #1554
Fixes BOT-Z7
|
|
BadUnionArgument sends command help after:
https://github.com/python-discord/bot/pull/1434
|
|
This was removed in the branding manager rewrite:
https://github.com/python-discord/bot/pull/1463/
|
|
|
|
|
|
|
|
This commit changes sighly how the warn, kick and mute commands to take a fetched member as their argument and to return a little error message if the user isn't in the guild rather than showing the whole help page.
|
|
|
|
|
|
Co-authored-by: Xithrius <[email protected]>
|
|
|
|
Co_authored-by: Numerlor <[email protected]>
|
|
|
|
|
|
|
|
This allows mod alert pings to go through in #mod-alerts, the allowed mentions only included the mods team role which is not pinged on mod alerts.
|
|
The modlog alert embed no longer pings everyone.
|
|
Co-authored-by: ChrisJL <[email protected]>
|
|
The `tests/README.md` file still referenced our old custom `AsyncMock` that has been removed in favour of the standard library one that has been introduced in 3.8. This commit fixes this by updating the section.
|
|
Co-authored-by: Boris Muratov <[email protected]>
|
|
|
|
|
|
Co-authored-by: Rohan Reddy Alleti <[email protected]>
|
|
|
|
|
|
|
|
|
|
Co-authored-by: Matteo Bertucci <[email protected]>
|
|
|
|
|
|
This is useful to audit users who still have the permission to stream. I have chosen to also
sort and paginate the embed to make it easier to read. The sorting is based on how long until
the user's streaming permissions are revoked, with permanent streamers at the end.
|
|
Previously any staff member (including helpers) could use the stream commands.
|
|
To mimic the same behaviour, setting all of the loggers to the trace level
was changed to a "*" prefix without looking at other contents instead of
setting it exactly to "ROOT" or "*"
|
|
Negative indexing starts at -1, not 0, meaning lower bound should be -1 * len(zen_lines), not -1 * upper_bound.
|
|
|
|
The renaming includes the commands inside it.
|
|
|
|
|