| Commit message (Collapse) | Author | Lines |
|
|
|
|
|
This commit just alters existing code to work with the new interface,
and with async. All tests are passing successfully.
|
|
- All methods will now do a validation check
- Complete interface spec added to class:
- .update
- .clear
- .pop
- .to_dict
- .length
- .contains
- .delete
- .get
- .set
|
|
The .set and .get will accept ints, floats, and strings. These will be
converted into "typestrings", which is basically just a simple format
that's been invented for this object.
For example, an int looks like `b"i|2423"`. Note how it is still stored
as a bytestring (like everything in Redis), but because of this prefix
we are able to coerce it into the type we want on the way out of the db.
|
|
This will help catch anything that tries to get/set an attribute/method
which doesn't exist. It'll also catch missing/too many parameters being
passed to methods.
|
|
Because some of the redis pool/connection methods return futures rather
than being coroutines, the redis pool had to be mocked using the
CustomMockMixin so it could take advantage of `additional_spec_asyncs`
to use AsyncMocks for these future-returning methods.
|
|
The fix is to mock the loop and pass it to the Bot. It will then set
it as `self.loop` rather than trying to get an event loop from asyncio.
The `create_task` patch has been moved to this loop mock rather than
being done in MockBot to ensure that it applies to anything calling it
when instantiating the Bot.
|
|
I'm not sure how it even managed to work before. It was calling the
`post` coroutine (without specifying a URL) and then changing
`__aenter__`. Now, a separate mock is created for the context manager
and the `post` simply returns that mocked context manager.
|
|
The assertion wasn't using the assertion method. Furthermore, it was
testing a non-existent function `create_loop` rather than `create_task`.
|
|
|
|
Co-authored-by: Mark <[email protected]>
|
|
This global connection is the one we will be using in RedisCache to
power all our commands.
This also ensures that connection is closed when the bot starts its
shutdown process.
|
|
|
|
In production, we will need this password to make a connection to Redis.
|
|
Co-authored-by: Joseph Banks <[email protected]>
|
|
Co-authored-by: Joseph Banks <[email protected]>
|
|
|
|
publish can take place
|
|
In production, we will need this password to make a connection to Redis.
|
|
The `discord-py` package is no longer the official release, and so
making this change silences some warnings about deprecation.
|
|
|
|
|
|
As @mathsman5133 pointed out, it's better to use the `Command`-instance
we typically already have in the current context than to rely on parsing
the qualified name again.
The invocation is now done as: `await ctx.send_help(ctx.command)`
|
|
|
|
|
|
Co-authored-by: kwzrd <[email protected]>
|
|
After the refactoring of the help command, we need to use the built-in
method of calling the help command: `Context.send_help`. As an argument,
the qualified name (a string containing the full command path, including
parents) of the command can be passed.
Examples:
- await ctx.send_help("reminders edit")
This would send a help embed with information on `!reminders edit` to
the Context.
- await ctx.send_help(ctx.command.qualified_name)
This would extract the qualified name of the command, which is the full
command path, and send a help embed to Context.
- await ctx.send_help()
This will send the main "root" help embed to the Context.
|
|
Turns out that bumping the flake8 version up to 3.8 introduces a long
list of new linting errors. Since this PR is the one that bumps the
version, I suppose we will also fix all the linting errors in this
branch.
|
|
|
|
|