aboutsummaryrefslogtreecommitdiffstats
path: root/tests/helpers.py (unfollow)
Commit message (Collapse)AuthorLines
2020-02-15Moderation: avoid prematurely cancelling deactivation taskGravatar MarkKoz-1/+3
Because deactivate_infraction() explicitly cancels the scheduled task, it now runs in a separate task to avoid prematurely cancelling itself.
2020-02-15Scheduler: cancel the task in the callbackGravatar MarkKoz-12/+30
This design makes more sense and is more convenient than requiring tasks to be responsible for cancelling themselves. * Rename _handle_task_exception to _task_done_callback * Add trace logging
2020-02-15Scheduler: raise task exceptions besides CancelledErrorGravatar MarkKoz-4/+7
Explicitly retrieves the task's exception, which will raise the exception if one exists. * Rename _suppress_cancelled_error to _handle_task_exception
2020-02-15Scheduler: remove loop parameter from schedule_taskGravatar MarkKoz-16/+9
asyncio.create_task() exists and will already use the running loop in the current thread. Because there is no intention of using a different loop in a different thread anywhere in the program for the foreseeable future, the loop parameter is redundant.
2020-02-15Scheduler: correct schedule_task's docstringGravatar MarkKoz-1/+1
2020-02-15Scheduler: remove create_task functionGravatar MarkKoz-15/+7
It's redundant because the done callback only takes a single line to add and can be added in schedule_task(). * Use Task as the type hint rather than Future for _suppress_cancelled_error()
2020-02-15Scheduler: fix #754 - only suppress CancelledErrorGravatar MarkKoz-6/+7
2020-02-14Stop scheduling expiration of permanent infractions on editGravatar Sebastiaan Zeeff-2/+5
https://github.com/python-discord/bot/issues/751 The infraction edit command defined in `bot.cogs.moderation.management` contained a bug causing it to attempt to schedule an expiration task when turning a temporary infraction into a permanent infraction. Since the "expires_at" field of a permanent infractions is `None`, this caused an exception to occur in the scheduler: Traceback (most recent call last): File "/bot/bot/cogs/moderation/scheduler.py", line 415, in _scheduled_task expiry = dateutil.parser.isoparse(infraction["expires_at"]).replace(tzinfo=None) File "/usr/local/lib/python3.7/site-packages/dateutil/parser/isoparser.py", line 37, in func return f(self, str_in, *args, **kwargs) File "/usr/local/lib/python3.7/site-packages/dateutil/parser/isoparser.py", line 134, in isoparse components, pos = self._parse_isodate(dt_str) File "/usr/local/lib/python3.7/site-packages/dateutil/parser/isoparser.py", line 208, in _parse_isodate return self._parse_isodate_common(dt_str) File "/usr/local/lib/python3.7/site-packages/dateutil/parser/isoparser.py", line 213, in _parse_isodate_common len_str = len(dt_str) TypeError: object of type 'NoneType' has no len() I have solved this by adding a check that makes sure we only schedule an expiration task when the `"expires_at"` field has a truthy value (which all valid datetime strings are) using `if request_data['expires_at']`. IMPORTANT NOTE: While it's tempting to just skip the entire scheduling block for permanent infractions, it's essential to unschedule existing expiration tasks for this infraction as we're changing a temporary infraction to a permanent infraction. This commit closes #751
2020-02-12Fix pagniation module for "last page" reactionGravatar mosguinz-1/+1
Fixes #746.
2020-02-09Remove clear reaction from paginatorsGravatar MarkKoz-17/+2
It could be confused with the delete reaction. Clearing reactions manually is rarely a useful feature anyway.
2020-02-07Pin discord.py to 1.3.xGravatar MarkKoz-2/+2
2020-02-07Update discord.py to 1.3.1Gravatar MarkKoz-39/+34
2020-02-06Add missing slash to asking good questions url.Gravatar scragly-1/+1
2020-02-05Move tools and questions guide to under resourcesGravatar scragly-2/+2
After the wiki pages adjustment to the resources page, these two urls are needing to be updated to point to the new correct locations for each page. Tools will be under resources, and Asking Good Questions is a guide, so will be under Guides.
2020-02-05Made searching even stricter by searching from start of each wordGravatar Shirayuki Nekomata-11/+13
- Added regex back to sub and split by non-alphabet. - Now use two pointers to move from words to words.
2020-02-05Removed regex, implemented a stricter letter searching.Gravatar Shirayuki Nekomata-10/+12
2020-02-05Increased default thresholds from just [100, 80] to [100, 90, 80, 70, 60]Gravatar Shirayuki Nekomata-2/+2
- Since it is returning as soon as there are suggestions found for a threshold, this will give a better reflection of what the bot thinks user is searching for.
2020-02-05Removed non-alphabets from both search and tag_name when scoring.Gravatar Shirayuki Nekomata-2/+5
- Added a regex to remove non-alphabet ( `[^a-z]` with `re.IGNORECASE` )
2020-02-04Refactored _get_suggestions following Mark's suggestions about inefficiency.Gravatar Shirayuki Nekomata-12/+24
- Matching scores will be calculated once now and stored in the dict `scores`. - Allow `_get_suggestions()` to go through a list of score threshold and return the first list of matching tags that's not empty and above the threshold. This avoid calling the function multiple time like before ( `self._get_suggestions(tag_name, 100) or self._get_suggestions(tag_name, 80)` for example, is calling this function twice, and is inefficient ) - Deleted commented line. - Added `typing` module for more typehints.
2020-02-04Fixed _last_fetch not being updated after each api call.Gravatar Shirayuki Nekomata-4/+6
- Changed type of `self._last_fetch` to `float` and give it the initial value of `0.0` instead of `None` - Assigned `time.time()` to `time_now` to avoid calling this function twice. - Added `self._last_fetch = time_now` after calling the api call.
2020-02-04Use a trailing underscore to avoid name conflicts. Gravatar scragly-2/+2
Previously used a leading underscore, but that's usually meant for non-used names.
2020-02-03Change typehint name for the attachment-log constantGravatar Matteo Bertucci-1/+1
2020-02-03Replace constant attachment-repost by the actual ID of #attachment-logGravatar Matteo Bertucci-4/+3
2020-02-02Update CODEOWNERSGravatar Joseph-1/+1
2020-02-02Remove prometheus related codeGravatar Joseph Banks-272/+128
2020-02-02Update config-default.ymlGravatar Thomas Petersson-0/+1