| Commit message (Collapse) | Author | Lines |
|---|
|
Co-Authored-By: Mark <[email protected]>
|
|
Kaizen:
- Cut down on the size of the import line by changing the imports from bot.constants to instead just importing the constants. This will help clarify where certain constants are coming from.
- The periodic checkpoint message will no longer ping `@everyone` or `@Admins` when the bot detects that it is being ran in a debug environment. Message is now a simple confirmation that the periodic ping method successfully ran.
Signed-off-by: Daniel Brown <[email protected]>
|
|
Bugs fixed:
- Previously, the code would check to see if `'expires_at'` was in the kwargs, which after testing I came to find out that it is regardless of the duration of the ban. It has sense been changed to use a `.get()` in order to do a proper comparison.
- Code previously attempted to load from the `"BigBrother"` cog which is the incorrect spelling. Changed it to `"Big Brother"` to correct this.
Logging Added:
- Additional trace logs added to both the `infractions.py` file as well as `bigbrother.py` to assist with future debugging or testing.
Signed-off-by: Daniel Brown <[email protected]>
|
|
- Added apply_unwatch() and migrated the code from the unwatch command to it. This will give us more control regarding testing and also determining when unwatches trigger.
- Added apply_watch() and migrated the code from the watch command to it. Again, this will assist with testing and could make it easier to automate adding to the watch list if need be.
- Added unwatch call to apply_ban. User will only be removed from the watch list if they were permanently banned. They will not be removed if it was only temporary.
Signed-off-by: Daniel Brown <[email protected]>
|
|
The usage of 127462 as a unicode start point isn't super clear for
other devs coming across the code in future, so assigning it to a nicely
named variable with an accompanying inline comment should help make
things clearer.
|
|
If the vote command receives less than 2 options, it's not being used
for it's intended usage and is considered a user input error.
|
|
The vote command takes a given list of options and generates a simple
message and corresponding reactions for each so members can quickly take
a vote on a subject during in-server discussions and meetings.
|
|
- Split `_get_tags_via_content` - introduce `_send_matching_tags`
- `_send_matching_tags` will send and paginate like `!tag`
- Simplified `is_plural` even more.
|
|
|
|
* Fix typo in file extensions list comprehension
|
|
Co-Authored-By: Mark <[email protected]>
|
|
- Show the process of sanitizing the List[str] `keywords_processed`.
- Show the process of finding tag for `matching_tags` ( was `founds` ).
- Refactored the logic to find boolean `is_plural`.
- Minor wording changes for docstring.
|
|
multiple tags are found.
- Added a truthy check for each `query` since `','.split()` returns a list of two empty strings.
- Changed from `Did you mean ...` to `Here are the tags containing the given keyword(s):` to be much more descriptive about the results - they are `tag` and not `term` to be searched.
|
|
- Refactored `if` block - change to only send result when there is any result.
- Added better type hinting for `check` argument of `_get_tags_via_content` - changed from `callable` to `Callable[[Iterable], bool]`.
Thanks to @markkoz 's reviews
Co-Authored-By: Mark <[email protected]>
|
|
instead of names
- `!tag search` will search for multiple keywords, separated by comma, and return tags that has ALL of these keywords.
` !tag search any` is the same as `!tag search` but it return tags that has ANY of the keyword instead.
|
|
If attachments are not given to `upload_log`, an empty list is used. By
default, `zip_longest` uses `None` ass the fill value, so each message
was getting paired with a `None` (AKA null) attachment. The filed in the
DB is non-nullable so an empty list must be used instead.
Fixes #792
|
|
- Added apply_unwatch() and migrated the code from the unwatch command to it. This will give us more control regarding testing and also determining when unwatches trigger.
- Added apply_watch() and migrated the code from the watch command to it. Again, this will assist with testing and could make it easier to automate adding to the watch list if need be.
- Added unwatch call to apply_ban. User will only be removed from the watch list if they were permanently banned. They will not be removed if it was only temporary.
Signed-off-by: Daniel Brown <[email protected]>
|
|
It was excluding files that are already ignored by git. Pre-commit
respects git ignore, even with --all-files, so these ignores were
redundant.
|
|
It's noisy, messy output. It's not of much benefit anyway as users can
run git diff locally if they really need to see a diff. They have to do
work locally anyway since CI won't commit the fixes pre-commit makes.
|
|
|
|
|
|
role(s)" due changes in command.
|
|
is more then 1 role.
|
|
|
|
|
|
A few docstrings in `bot.cogs.extensions` have forward slashed in them to escape Markdown rendering when our help feature uses these docstring in a Discord message. However, the use of forward slashes with an invalid escape sequence in docstrings now raises a DeprecationWarning in Python:
/home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \*
PEP 257 (Docstring Conventions, https://www.python.org/dev/peps/pep-0257/) states that raw strings should be used for docstrings that use forward slashes, so I've added the `r`-prefix to the docstrings that use forward slashes.
|
|
|
|
This was added by the now-removed Snake cog & is not used elsewhere on bot.
|
|
|
|
The mock gets used by the flake8 pre-commit hook, which invokes flake8
via `pipenv run flake8`. It's normally useful to use pipenv here cause
it ensures flake8 is invoked within the context of the venv. However, in
CI, there is no venv - dependencies are installed directly to the
system site-packages. `pipenv run` does not work in such case because it
tries to create a new venv if one doesn't exist (it doesn't consider the
system interpreter to be a venv).
This workaround (okay, it's a hack) creates an executable shell script
which replaces the original pipenv binary. The shell script simply
ignores the first argument (i.e. ignores `run` in `pipenv run`) and
executes the rest of the arguments as a command. It essentially makes
`pipenv run flake8` equivalent to just having ran `flake8`. When
pre-commit executes pipenv, the aforementioned script is what will run.
|
|
A cache for an outdated pre-commit environment may still be useful. It
may be the case that only some hooks need to be updated rather than
all.
|
|
|
|
The previous embed assumed that the messages would be sent on the server, where the channel would have a name and the message would have a jump URL. For a DM, neither of these are present and an exception will be raised when attempting to construct the embed for the webhook to send.
|
|
Co-Authored-By: Leon Sandøy <[email protected]>
|
|
* Remove trailing whitespaces
* Specify error code for a noqa in the free command
|
|
Resolves an issue mentioned in https://github.com/python-discord/bot/issues/767, giving Helpers access to post invites and other things caught by the Filtering cog.
|
|
|
|
Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
|
|
Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function
|
|
* Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests.
|
|
* Add generic handling for multi-file uploads
* Log user, id, and blocked extensions
* Provide the full list of attachment filenames as a logging extra
* Provide feedback on all blacklisted file types uploaded
|
|
|
|
|
|
title (was before in footer).
|
|
|
|
This makes it easy to add colour to the logs. Colorama is also installed
if on a Windows system.
|
|
I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks.
In particular, I had to make a few changes:
- Mocking the async post() context manager correctly
Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called).
- Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with`
Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited.
- Patch `functools.partial` as `partial` objects are compared by identity
When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
|
|
|
|
|
|
It could have caused some errors if the user delete his own message
|
Daniel Brown
scragly
Shirayuki Nekomata
S. Co1
MarkKoz
ks123
Sebastiaan Zeeff
Leon Sandøy
Joseph
Spencer Young
Matteo