| Commit message (Collapse) | Author | Lines |
|---|
|
This will help catch anything that tries to get/set an attribute/method
which doesn't exist. It'll also catch missing/too many parameters being
passed to methods.
|
|
Because some of the redis pool/connection methods return futures rather
than being coroutines, the redis pool had to be mocked using the
CustomMockMixin so it could take advantage of `additional_spec_asyncs`
to use AsyncMocks for these future-returning methods.
|
|
The fix is to mock the loop and pass it to the Bot. It will then set
it as `self.loop` rather than trying to get an event loop from asyncio.
The `create_task` patch has been moved to this loop mock rather than
being done in MockBot to ensure that it applies to anything calling it
when instantiating the Bot.
|
|
I'm not sure how it even managed to work before. It was calling the
`post` coroutine (without specifying a URL) and then changing
`__aenter__`. Now, a separate mock is created for the context manager
and the `post` simply returns that mocked context manager.
|
|
The assertion wasn't using the assertion method. Furthermore, it was
testing a non-existent function `create_loop` rather than `create_task`.
|
|
|
|
This global connection is the one we will be using in RedisCache to
power all our commands.
This also ensures that connection is closed when the bot starts its
shutdown process.
|
|
|
|
In production, we will need this password to make a connection to Redis.
|
|
In production, we will need this password to make a connection to Redis.
|
|
The `discord-py` package is no longer the official release, and so
making this change silences some warnings about deprecation.
|
|
Turns out that bumping the flake8 version up to 3.8 introduces a long
list of new linting errors. Since this PR is the one that bumps the
version, I suppose we will also fix all the linting errors in this
branch.
|
|
|
|
|
MarkKoz
Leon Sandøy