aboutsummaryrefslogtreecommitdiffstats
path: root/tests/helpers.py (unfollow)
Commit message (Collapse)AuthorLines
2020-03-04Use "pathlib" instead of "os" module and context managerGravatar RohanJnr-11/+9
The pathlib module simplifies opening and reading files, hence the os module and the context manager are no longer used.
2020-03-04Use raw strings for docstrings with forward slashesGravatar Sebastiaan Zeeff-3/+3
A few docstrings in `bot.cogs.extensions` have forward slashed in them to escape Markdown rendering when our help feature uses these docstring in a Discord message. However, the use of forward slashes with an invalid escape sequence in docstrings now raises a DeprecationWarning in Python: /home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \* PEP 257 (Docstring Conventions, https://www.python.org/dev/peps/pep-0257/) states that raw strings should be used for docstrings that use forward slashes, so I've added the `r`-prefix to the docstrings that use forward slashes.
2020-03-03Update code for pep8-naming complianceGravatar S. Co1-6/+6
2020-03-03Remove CaseInsensitiveDictGravatar S. Co1-94/+0
This was added by the now-removed Snake cog & is not used elsewhere on bot.
2020-03-03Add pep8-naming & relockGravatar S. Co1-14/+28
2020-03-03CI: mock the pipenv binaryGravatar MarkKoz-0/+10
The mock gets used by the flake8 pre-commit hook, which invokes flake8 via `pipenv run flake8`. It's normally useful to use pipenv here cause it ensures flake8 is invoked within the context of the venv. However, in CI, there is no venv - dependencies are installed directly to the system site-packages. `pipenv run` does not work in such case because it tries to create a new venv if one doesn't exist (it doesn't consider the system interpreter to be a venv). This workaround (okay, it's a hack) creates an executable shell script which replaces the original pipenv binary. The shell script simply ignores the first argument (i.e. ignores `run` in `pipenv run`) and executes the rest of the arguments as a command. It essentially makes `pipenv run flake8` equivalent to just having ran `flake8`. When pre-commit executes pipenv, the aforementioned script is what will run.
2020-03-03CI: add a restore key for the pre-commit cacheGravatar MarkKoz-1/+3
A cache for an outdated pre-commit environment may still be useful. It may be the case that only some hooks need to be updated rather than all.
2020-03-03Use pre-commit in pipenv lint scriptGravatar MarkKoz-4/+12
2020-03-03Prevent exception if a watched user sends a DM to the botGravatar S. Co1-2/+9
The previous embed assumed that the messages would be sent on the server, where the channel would have a name and the message would have a jump URL. For a DM, neither of these are present and an exception will be raised when attempting to construct the embed for the webhook to send.
2020-03-03Fix typo in commentGravatar Mark-1/+1
Co-Authored-By: Leon Sandøy <[email protected]>
2020-03-02Add more pre-commit hooksGravatar MarkKoz-10/+27
* Remove trailing whitespaces * Specify error code for a noqa in the free command
2020-03-02Adding helpers to the Filtering whitelistGravatar Leon Sandøy-0/+1
Resolves an issue mentioned in https://github.com/python-discord/bot/issues/767, giving Helpers access to post invites and other things caught by the Filtering cog.
2020-03-01Add grabify (IP logger) domains to banned domainsGravatar Joseph-0/+24
2020-03-01Modify log test regex to be non-os-specificGravatar S. Co1-1/+1
Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
2020-03-01Move syncer confirmation reaction check out of finally clauseGravatar S. Co1-11/+11
Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function
2020-03-01Bump Dependencies & RelockGravatar S. Co1-78/+76
* Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests.
2020-03-01Add logging to antimalware cog & expand user feedbackGravatar S. Co1-17/+24
* Add generic handling for multi-file uploads * Log user, id, and blocked extensions * Provide the full list of attachment filenames as a logging extra * Provide feedback on all blacklisted file types uploaded
2020-03-01Optimize DockerfileGravatar Spencer Young-2/+5
2020-02-29Make logs coloured!Gravatar MarkKoz-7/+23
2020-02-29Install the coloredlogs packageGravatar MarkKoz-40/+66
This makes it easy to add colour to the logs. Colorama is also installed if on a Windows system.
2020-02-29Caching all the tags when the bot has loaded(caching only once) insted of ↵Gravatar RohanJnr-21/+18
caching it after the tags command is used.
2020-02-29Migrate snekbox tests to Python 3.8's unittestGravatar Sebastiaan Zeeff-41/+27
I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks. In particular, I had to make a few changes: - Mocking the async post() context manager correctly Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called). - Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with` Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited. - Patch `functools.partial` as `partial` objects are compared by identity When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
2020-02-29Re-corrected the lines which I had changed by mistakeGravatar RohanJnr-1/+2
2020-02-29added white spaces on statements before bullet points for proper rendering ↵Gravatar RohanJnr-75/+75
of points on github
2020-02-29Added all the tag files in resources and modified cogs/tags.py file to ↵Gravatar RohanJnr-84/+919
access the static tag files rather than sending an API get request. Removed all methods calling the API so the tags cannot be edited, added nor deleted.
2020-02-28Scheduler: correct type annotationsGravatar MarkKoz-6/+6
2020-02-28Snekbox: mention re-evaluation feature in the command's docstringGravatar MarkKoz-1/+4
2020-02-28Ignore NotFound errors inside continue_evalGravatar Matteo-24/+25
It could have caused some errors if the user delete his own message
2020-02-28Return only the new code in continue_eval and check for truthiness insteadGravatar Matteo-11/+10
2020-02-27Scheduler: log the exception instead of raisingGravatar MarkKoz-2/+5
Logging it ourselves has a cleaner traceback and gives more control over the output, such as including the task ID.
2020-02-27Remove unnecessary newlines from call.Gravatar Numerlor-4/+1
2020-02-27Moderation: fix task cancellation for permanent infraction when editingGravatar MarkKoz-1/+3
A task should not be cancelled if an infraction is permanent because tasks don't exist for permanent infractions. Fixes BOT-1V
2020-02-27Use unicode code point instead of literal for the snekbox re-eval emojiGravatar Matteo-6/+8
Unicode literals aren't really safe compared to code points
2020-02-27Split the eval command procedure into two functions.Gravatar Matteo-114/+148
Two functions were created: send_eval and continue_eval, in order to facilitate testing. The corresponding tests are also changed in this commit.
2020-02-26Add clarifying comment to role checking logic implementationGravatar S. Co1-0/+1
2020-02-26Log invalid tag names in the error handler tag fallback.Gravatar Numerlor-5/+13
2020-02-26Remove logging from tag converters.Gravatar Numerlor-10/+0
2020-02-26Disable TRACE logging for Sentry breadcrumbs.Gravatar Joseph-1/+1
2020-02-26Adjust tests for new converter behavior.Gravatar Numerlor-1/+1
2020-02-26Remove number check on tags.Gravatar Numerlor-14/+0
This case is already covered by checking if at least one letter is included.
2020-02-26Pass error handler tag fallback through TagNameConverter.Gravatar Numerlor-2/+6
The tag fallback didn't convert tags, resulting in possible invalid tag names being passed to the `tags_get_command`. This makes sure they're valid and ignores the risen exception if they are not.
2020-02-26Make sure tag name contains at least one letter.Gravatar Numerlor-0/+6
With only ascii and numbers being allowed to go through, possible values still included things like `$()` which don't match anything in `REGEX_NON_ALPHABET` from tags.py resulting in an error.
2020-02-26Added DMs ignoring to antimalware checkGravatar ks123-1/+2
2020-02-26Fix comparison operator when checking token expiration.Gravatar Numerlor-1/+1
With `<` the check only went through when the token was already expired, making revoking redundant; and didn't go through when the token still had some time before expiration.
2020-02-26Added to AntiMalware staff ignore check.Gravatar Karlis. S-1/+5
2020-02-26Check for falsy values instead of ``""` and `None` explicitly.Gravatar Numerlor-2/+1
After the change to also check empty strings to avoid unucessary requests, it is no longer necessary to do an explicit value check, as the only values that can come from the .env file are `None` and strings Co-authored-by: Karlis S <[email protected]>
2020-02-26Specify the logged time is in UTC.Gravatar Numerlor-1/+1
2020-02-26Create task for `revoke_access_token` when unloading cog to ensure it's ↵Gravatar Numerlor-1/+1
executed.
2020-02-25Scheduler: only send warning in callback if task isn't cancelledGravatar MarkKoz-1/+1
If a task is cancelled it is assumed it was done via cancel_task. That method deletes the task after cancelling so the warning isn't relevant.
2020-02-25Scheduler: properly raise task's exception the done callbackGravatar MarkKoz-1/+4
Task.exception() only returns the exception. It still needs to be explicitly raised.