| Commit message (Collapse) | Author | Lines |
|
The pathlib module simplifies opening and reading files, hence the os module and the context manager are no longer used.
|
|
A few docstrings in `bot.cogs.extensions` have forward slashed in them to escape Markdown rendering when our help feature uses these docstring in a Discord message. However, the use of forward slashes with an invalid escape sequence in docstrings now raises a DeprecationWarning in Python:
/home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \*
PEP 257 (Docstring Conventions, https://www.python.org/dev/peps/pep-0257/) states that raw strings should be used for docstrings that use forward slashes, so I've added the `r`-prefix to the docstrings that use forward slashes.
|
|
|
|
This was added by the now-removed Snake cog & is not used elsewhere on bot.
|
|
|
|
The mock gets used by the flake8 pre-commit hook, which invokes flake8
via `pipenv run flake8`. It's normally useful to use pipenv here cause
it ensures flake8 is invoked within the context of the venv. However, in
CI, there is no venv - dependencies are installed directly to the
system site-packages. `pipenv run` does not work in such case because it
tries to create a new venv if one doesn't exist (it doesn't consider the
system interpreter to be a venv).
This workaround (okay, it's a hack) creates an executable shell script
which replaces the original pipenv binary. The shell script simply
ignores the first argument (i.e. ignores `run` in `pipenv run`) and
executes the rest of the arguments as a command. It essentially makes
`pipenv run flake8` equivalent to just having ran `flake8`. When
pre-commit executes pipenv, the aforementioned script is what will run.
|
|
A cache for an outdated pre-commit environment may still be useful. It
may be the case that only some hooks need to be updated rather than
all.
|
|
|
|
The previous embed assumed that the messages would be sent on the server, where the channel would have a name and the message would have a jump URL. For a DM, neither of these are present and an exception will be raised when attempting to construct the embed for the webhook to send.
|
|
Co-Authored-By: Leon Sandøy <[email protected]>
|
|
* Remove trailing whitespaces
* Specify error code for a noqa in the free command
|
|
Resolves an issue mentioned in https://github.com/python-discord/bot/issues/767, giving Helpers access to post invites and other things caught by the Filtering cog.
|
|
|
|
Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
|
|
Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function
|
|
* Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests.
|
|
* Add generic handling for multi-file uploads
* Log user, id, and blocked extensions
* Provide the full list of attachment filenames as a logging extra
* Provide feedback on all blacklisted file types uploaded
|
|
|
|
|
|
This makes it easy to add colour to the logs. Colorama is also installed
if on a Windows system.
|
|
caching it after the tags command is used.
|
|
I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks.
In particular, I had to make a few changes:
- Mocking the async post() context manager correctly
Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called).
- Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with`
Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited.
- Patch `functools.partial` as `partial` objects are compared by identity
When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
|
|
|
|
of points on github
|
|
access the static tag files rather than sending an API get request. Removed all methods calling the API so the tags cannot be edited, added nor deleted.
|
|
|
|
|
|
It could have caused some errors if the user delete his own message
|
|
|
|
Logging it ourselves has a cleaner traceback and gives more control
over the output, such as including the task ID.
|
|
|
|
A task should not be cancelled if an infraction is permanent because
tasks don't exist for permanent infractions.
Fixes BOT-1V
|
|
Unicode literals aren't really safe compared to code points
|
|
Two functions were created: send_eval and continue_eval, in order to facilitate testing. The corresponding tests are also changed in this commit.
|
|
|
|
|
|
|
|
|
|
|
|
This case is already covered by checking if at least one letter is included.
|
|
The tag fallback didn't convert tags, resulting in possible invalid tag names being passed to the `tags_get_command`. This makes sure they're valid and ignores the risen exception if they are not.
|
|
With only ascii and numbers being allowed to go through, possible values still included things like `$()` which don't match anything in `REGEX_NON_ALPHABET` from tags.py resulting in an error.
|
|
|
|
With `<` the check only went through when the token was already expired, making revoking redundant; and didn't go through when the token still had some time before expiration.
|
|
|
|
After the change to also check empty strings to avoid unucessary requests, it is no longer necessary to do an explicit value check, as the only values that can come from the .env file are `None` and strings
Co-authored-by: Karlis S <[email protected]>
|
|
|
|
executed.
|
|
If a task is cancelled it is assumed it was done via cancel_task. That
method deletes the task after cancelling so the warning isn't relevant.
|
|
Task.exception() only returns the exception. It still needs to be
explicitly raised.
|