|  | Commit message (Collapse) | Author | Lines | 
|---|
|  | empty and with this message formatting go wrong. | 
|  | Fixed `!tag search any` raises `AttributeError`.
Changed default value of `keywords` from `None` to `'any'`.
This will make it search for keyword `'any'` when there is no keyword. | 
|  |  | 
|  |  | 
|  |  | 
|  | * Add a constant for the footer text
* Import constants module rather than its classes | 
|  | The tags have now been shifted from the database to being static files and hence the get_tags()
method has undergone changes. It now dosen't fetch from the database but looks at the local files
and we need not call it more than once. | 
|  |  | 
|  |  | 
|  |  | 
|  | The usage of 127462 as a unicode start point isn't super clear for
other devs coming across the code in future, so assigning it to a nicely
named variable with an accompanying inline comment should help make
things clearer. | 
|  | If the vote command receives less than 2 options, it's not being used
for it's intended usage and is considered a user input error. | 
|  | The vote command takes a given list of options and generates a simple
message and corresponding reactions for each so members can quickly take
a vote on a subject during in-server discussions and meetings. | 
|  | - Split `_get_tags_via_content` - introduce `_send_matching_tags`
- `_send_matching_tags` will send and paginate like `!tag`
- Simplified `is_plural` even more. | 
|  |  | 
|  | * Fix typo in file extensions list comprehension | 
|  | Co-Authored-By: Mark <[email protected]> | 
|  | - Show the process of sanitizing the List[str] `keywords_processed`.
- Show the process of finding tag for `matching_tags` ( was `founds` ).
- Refactored the logic to find boolean `is_plural`.
- Minor wording changes for docstring. | 
|  | multiple tags are found.
- Added a truthy check for each `query` since `','.split()` returns a list of two empty strings.
- Changed from `Did you mean ...` to `Here are the tags containing the given keyword(s):` to be much more descriptive about the results - they are `tag` and not `term` to be searched. | 
|  | - Refactored `if` block - change to only send result when there is any result.
- Added better type hinting for `check` argument of `_get_tags_via_content` - changed from `callable` to `Callable[[Iterable], bool]`.
Thanks to @markkoz 's reviews
Co-Authored-By: Mark <[email protected]> | 
|  | instead of names
- `!tag search` will search for multiple keywords, separated by comma, and return tags that has ALL of these keywords.
` !tag search any` is the same as `!tag search` but it return tags that has ANY of the keyword instead. | 
|  | If attachments are not given to `upload_log`, an empty list is used. By
default, `zip_longest` uses `None` ass the fill value, so each message
was getting paired with a `None` (AKA null) attachment. The filed in the
DB is non-nullable so an empty list must be used instead.
Fixes #792 | 
|  | It was excluding files that are already ignored by git. Pre-commit
respects git ignore, even with --all-files, so these ignores were
redundant. | 
|  | It's noisy, messy output. It's not of much benefit anyway as users can
run git diff locally if they really need to see a diff. They have to do
work locally anyway since CI won't commit the fixes pre-commit makes. | 
|  |  | 
|  |  | 
|  | role(s)" due changes in command. | 
|  | is more then 1 role. | 
|  |  | 
|  |  | 
|  |  | 
|  | "get_tags()" and "_get_tag()" functions need not be async as we are no longer doing any API call but instead reading from local files. | 
|  | The pathlib module simplifies opening and reading files, hence the os module and the context manager are no longer used. | 
|  | A few docstrings in `bot.cogs.extensions` have forward slashed in them to escape Markdown rendering when our help feature uses these docstring in a Discord message. However, the use of forward slashes with an invalid escape sequence in docstrings now raises a DeprecationWarning in Python:
/home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \*
PEP 257 (Docstring Conventions, https://www.python.org/dev/peps/pep-0257/) states that raw strings should be used for docstrings that use forward slashes, so I've added the `r`-prefix to the docstrings that use forward slashes. | 
|  |  | 
|  | This was added by the now-removed Snake cog & is not used elsewhere on bot. | 
|  |  | 
|  | The mock gets used by the flake8 pre-commit hook, which invokes flake8
via `pipenv run flake8`. It's normally useful to use pipenv here cause
it ensures flake8 is invoked within the context of the venv. However, in
CI, there is no venv - dependencies are installed directly to the
system site-packages. `pipenv run` does not work in such case because it
tries to create a new venv if one doesn't exist (it doesn't consider the
system interpreter to be a venv).
This workaround (okay, it's a hack) creates an executable shell script
which replaces the original pipenv binary. The shell script simply
ignores the first argument (i.e. ignores `run` in `pipenv run`) and
executes the rest of the arguments as a command. It essentially makes
`pipenv run flake8` equivalent to just having ran `flake8`. When
pre-commit executes pipenv, the aforementioned script is what will run. | 
|  | A cache for an outdated pre-commit environment may still be useful. It
may be the case that only some hooks need to be updated rather than
all. | 
|  |  | 
|  | The previous embed assumed that the messages would be sent on the server, where the channel would have a name and the message would have a jump URL. For a DM, neither of these are present and an exception will be raised when attempting to construct the embed for the webhook to send. | 
|  | Co-Authored-By: Leon Sandøy <[email protected]> | 
|  | * Remove trailing whitespaces
* Specify error code for a noqa in the free command | 
|  | Resolves an issue mentioned in https://github.com/python-discord/bot/issues/767, giving Helpers access to post invites and other things caught by the Filtering cog. | 
|  |  | 
|  | Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\` | 
|  | Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function | 
|  | * Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests. | 
|  | * Add generic handling for multi-file uploads
* Log user, id, and blocked extensions
* Provide the full list of attachment filenames as a logging extra
* Provide feedback on all blacklisted file types uploaded | 
|  |  |