| Commit message (Collapse) | Author | Lines |
|
|
|
|
|
Previously silencing a channel reset all overwrites excluding `send_messages`
and unsilencing them removed all overwrites.
This is prevented by getting the current overwrite
and applying it with only send_messages changed.
|
|
|
|
Separating the notifier allows us to keep the Silence class
and its methods to be more focused on the class' purpose,
handling the logic of adding/removing channels
and the loop itself behind `SilenceNotifier`'s interface.
|
|
|
|
Calling the command coro directly did unnecessary checks and
made tests for the method harder to realize.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
FirstHash is used for handling channels in `loop_alert_channels` set as tuples without considering other elements.
|
|
|
|
|
|
Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
|
|
Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function
|
|
* Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests.
|
|
|
|
|
|
This makes it easy to add colour to the logs. Colorama is also installed
if on a Windows system.
|
|
I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks.
In particular, I had to make a few changes:
- Mocking the async post() context manager correctly
Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called).
- Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with`
Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited.
- Patch `functools.partial` as `partial` objects are compared by identity
When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
|
|
|
|
|
|
It could have caused some errors if the user delete his own message
|
|
|
|
Logging it ourselves has a cleaner traceback and gives more control
over the output, such as including the task ID.
|
|
|
|
A task should not be cancelled if an infraction is permanent because
tasks don't exist for permanent infractions.
Fixes BOT-1V
|
|
Unicode literals aren't really safe compared to code points
|
|
Two functions were created: send_eval and continue_eval, in order to facilitate testing. The corresponding tests are also changed in this commit.
|
|
|
|
|
|
|
|
|
|
|
|
This case is already covered by checking if at least one letter is included.
|
|
The tag fallback didn't convert tags, resulting in possible invalid tag names being passed to the `tags_get_command`. This makes sure they're valid and ignores the risen exception if they are not.
|
|
With only ascii and numbers being allowed to go through, possible values still included things like `$()` which don't match anything in `REGEX_NON_ALPHABET` from tags.py resulting in an error.
|
|
|
|
With `<` the check only went through when the token was already expired, making revoking redundant; and didn't go through when the token still had some time before expiration.
|
|
|
|
After the change to also check empty strings to avoid unucessary requests, it is no longer necessary to do an explicit value check, as the only values that can come from the .env file are `None` and strings
Co-authored-by: Karlis S <[email protected]>
|
|
|
|
executed.
|
|
If a task is cancelled it is assumed it was done via cancel_task. That
method deletes the task after cancelling so the warning isn't relevant.
|
|
Task.exception() only returns the exception. It still needs to be
explicitly raised.
|
|
To prevent a deletion of task rescheduled with the same ID, the callback
checks that the stored task is the same as the done task being handled.
* Only delete the task; it doesn't need to be cancelled because the it
is already done
* Revise the callback's docstring to explain the new behaviour
* Rename `task` parameter to `done_task`
|