aboutsummaryrefslogtreecommitdiffstats
path: root/tests/helpers.py (unfollow)
Commit message (Collapse)AuthorLines
2021-03-05Use scheduling's create_taskGravatar Numerlor-1/+1
2021-03-05Add comment explaining purpose of create_task over awaitGravatar Numerlor-0/+1
2021-03-05Set future result to None on exceptionsGravatar Numerlor-7/+2
We can still provide th user with at least the link to the docs, for which we already have handling in the cog with a generic "unable to parse message", using exceptions for that would mean setting it here, immediately catching it and then providing the same or very similar message.
2021-03-05Correct typehintGravatar Numerlor-2/+2
2021-03-05Move future assignment and check outside of the tryGravatar Numerlor-5/+6
No exceptions can be raised from the two lines of code because of the data structures used, moving it out makes for flatter code.
2021-03-05Rename params to clearer and more concise alternativesGravatar Numerlor-6/+6
2021-03-05Explain use of various containers in the cogGravatar Numerlor-1/+4
Co-authored-by: MarkKoz <[email protected]>
2021-03-05Use placeholder consistent with others in the cogGravatar Numerlor-1/+1
2021-03-05Add comments to the parsing moduleGravatar Numerlor-3/+8
Co-authored-by: MarkKoz <[email protected]>
2021-03-05Account for ellipses when determining the truncation description indexGravatar Numerlor-3/+3
2021-03-05Remove placeholder in shorten callGravatar Numerlor-1/+1
2021-03-05Use clearer branchingGravatar Numerlor-5/+3
Co-authored-by: MarkKoz <[email protected]>
2021-03-05Add comments for purpose of DocItem attributesGravatar Numerlor-5/+5
2021-03-05Do _item_futures cleanup in _parse_queue instead of a concurrent taskGravatar Numerlor-33/+4
The doc_cache coro was changed to be awaited directly instead of creating a task to ensure the cache is populated before the item is deleted
2021-03-05Set the result of the future instead of an exception when avaialbleGravatar Numerlor-1/+5
2021-03-05Do not set redis results in get_symbol_embedGravatar Numerlor-3/+1
The redis results are already being set in the BatchParser for all symbols
2021-03-05Typo and docstring style changesGravatar Numerlor-11/+11
Co-authored-by: MarkKoz <[email protected]> fixup! Docstring typos and style changes
2021-03-05Move the seconds of a week timedelta into a constantGravatar Numerlor-1/+3
2021-03-05Use deque instead of a listGravatar Numerlor-5/+7
As we extend the left side of a list now, using a deque that provides a direct method for it is more fitting. fixup! Use deque instead of a list
2021-03-05Use common check for early exitGravatar Numerlor-11/+8
This introduces a possibly redundant check for the doc_item being None but results in flatter code with less duplication
2021-02-28Add new symbols to front of queue instead of extending the endGravatar Numerlor-1/+1
Using extend caused old items, including the ones that were requested by users and pushed to the front, to be pushed back by all of the items on the new page, possibly significantly delaying their parsing
2021-02-27Add digits to package covnerterGravatar Numerlor-2/+2
2021-02-27Get the last index instead of using maxGravatar Numerlor-1/+1
The last index will always be the largest one so there's no need for max to search for it
2021-02-24Use 4 spaces for hanging indentGravatar Numerlor-19/+19
2021-02-24Allow wildcard match for clear cache commandGravatar Numerlor-3/+7
2021-02-23Update docstringsGravatar Numerlor-2/+2
2021-02-23Remove redundant group checkGravatar Numerlor-1/+1
As we check for non dt symbol names to be sure in case something pops up , we can skip the initial group check as all the symbols from those groups should point to non dt tags.
2021-02-23Correct length adjustmentGravatar Numerlor-1/+1
the placeholder contains a space and is actually 4 chars because of that with a comma that adds up to 5 characters in the signature instead of 4
2021-02-23Add unittests for _split_signatureGravatar Numerlor-0/+59
2021-02-23Add lt and gt angle brackets to bracket pairsGravatar Numerlor-0/+1
2021-02-23Add deletedoccache alias to the clear cache commandGravatar Numerlor-1/+1
2021-02-23cleanup->clean_upGravatar Numerlor-2/+2
2021-02-23Remove unnecessary commentsGravatar Numerlor-10/+0
The comments explain things that should be clear, or basic concepts
2021-02-23Use "inventories" when referring to the cog's collection of sphinx invsGravatar Numerlor-9/+9
Previously in some context inventory referred both to a single "inventory" that we got from a remote objects.inv and to the internal cog inventories. Always referring to the cog's inventories as plural The update_single docstring was also changed from rebuild to build, as the method doesn't handle anything with a preexisting inventory with the same symbols being in the cog's inventories
2021-02-23Simplify conditionGravatar Numerlor-1/+1
2021-02-23Simplify the _split_parameters implementationGravatar Numerlor-30/+18
The main simplification was getting rid of keeping track of string depth which was unnecessary, as we can just always skip them as was being done for strings inside of brackets. The branching was also simplified to make sure less unnecessary checks were being done with a bit less confusing elifs.
2021-02-23Fix docstring typosGravatar Numerlor-10/+10
2021-02-05Remove unnecessary use of partialGravatar Numerlor-6/+4
run_in_executor can provide args to the func it's passed in, making the use of partial unnecessary. This will also make it more convenient to move to asyncio.to_thread when the codebase is switched to python 3.9
2021-02-03Avoid from import on _batch_parserGravatar Numerlor-3/+2
The tests import the modules the other way around causing a circular import
2021-02-03Use create_task utilGravatar Numerlor-2/+3
2021-02-03Create a task for setting the redis result instead of awaitingGravatar Numerlor-1/+1
The queue parsing doesn't depend on anything with redis, so the await only delays the result being set on the future.
2021-02-03Move BeautifulSoup parsing into an executorGravatar Numerlor-1/+4
2021-02-03Remove url lockGravatar Numerlor-3/+1
The items are added to the futures dict before a context switch can occur, making the subsequent requests to the url skip the queue extend and suspend at the future await
2021-02-03Use more consistent naming for doc items and symbolsGravatar Numerlor-71/+71
Trailing commas were also added where missing
2021-02-03Import module directly to avoid circular dependency and use of typeGravatar Numerlor-13/+11
2021-02-02Attempt to resolve first part of the argument in case of a failed lookupGravatar Numerlor-2/+12
2021-01-30Require a set of names to ignore instead of a blanket ignoringGravatar Numerlor-16/+16
As work is done on the modules the wrapper and wrapped functions are in more conflicts can occur, previously this could be missed as the info log that was done in case the error was suppressed was done when modules were being initialized during which there is a logging spam.
2021-01-23Cancel current task inside coro to not keep track of attempts manuallyGravatar Numerlor-8/+5
The scheduler shields the coroutine from cancellation so we can cancel the scheduler's tasks inside of it to avoid the error from multiple tasks with the same id trying to be scheduled which the manual tracking of attempts solved Co-authored-by: MarkKoz <[email protected]>
2021-01-23Wrap whole string in shortenGravatar Numerlor-1/+1
This helps avoid subtracting the length of "Moved: " from the shorten index Co-authored-by: MarkKoz <[email protected]>
2021-01-23Avoid errors when the first element is longer than the truncation indexGravatar Numerlor-3/+10
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-26 10:01:06 +0000