| Commit message (Collapse) | Author | Lines |
|---|
|
The edit causes two channel update events to dispatch simultaneously:
one for the channel topic changing and one for the category changing.
The ModLog cog currently doesn't support ignoring multiple events of
the same type for the same channel. Therefore, the ignore was hard coded
rather than using the typical ignore mechanism.
This is intended to be a temporary solution; it should be removed once
the ModLog is changed to support this situation.
|
|
|
|
Co-Authored-By: Leon Sandøy <[email protected]>
|
|
|
|
|
|
There is no longer a reliance on static alphabetical position numbers.
|
|
When a channel is moved, all channels below have their positions
incremented by 1. This threw off the previous implementation which
relied on position numbers being static.
Co-authored-by: Sebastiaan Zeeff <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
Resetting a specific permission still keeps the overwrite for the member
around despite having default values. These will accumulate over time so
they should be completely removed once the permission needs to be reset.
|
|
|
|
This was happening when attempting to schedule a task twice for a user.
Because the scheduler refuses to schedule a duplicate, the coroutine
is deallocated right away without being awaited (or closed explicitly
by `scheduled_task`).
To fix, any existing task is cancelled before scheduling. This also
means if somehow a user bypasses the lack of permissions, their
cooldown will be updated. However, it probably doesn't make a difference
as if they can bypass once, they likely can bypass again.
|
|
Explicitly close the callback if it's a coroutine.
|
|
Can rely on `__str__` already being a channel's name.
|
|
Replace retrieval of all channels of a category with a direct comparison
of the categories themselves. In the case of the `on_message` listener,
the change enables the check to be done before the lock acquisition.
This is because it doesn't rely on the channels in the category to be up
to date. In fact, it doesn't even need the category object so it can
exit early without needing to wait for the cog to be ready.
|
|
|
|
This ensures everyone has a clean slate when the bot restarts or the
cog reloads since the tasks to reinstate permissions would have been
cancelled in those cases.
|
|
|
|
To support scheduling different coroutines, `_scheduled_task` now
accepts an awaitable in the data arg. The data arg is actually a
named tuple of the wait time and the awaitable.
|
|
They must be greater than 0 because the cog obviously couldn't do
anything without any channels to work with. It must be greater than
max_available because it'd otherwise be impossible to maintain that many
channels in the Available category.
* Create a new function to validate the value
* Move validation against MAX_CHANNELS_PER_CATEGORY into the function
rather than just logging a warning
|
|
This will ensure the maximum amount of dormant channels possible before
attempting to move any to the available category. It also allows the
dormant command to already be enabled in case there are still no
dormant channels when trying to init available channels.
|
|
The ready event wasn't used because channels could change categories
between the time the command is invoked and the cog is ready (e.g. if
move_idle_channel wasn't called yet). his may confused users. So would
potentially long delays for the cog to become ready.
|
|
* Make a copy of the dict
* Add a `ignore_missing` param to `cancel_task` to suppress the warning
for a task not being found
|
|
|
|
|
|
|
|
|
|
|
|
|
|
When rescheduling an idle channel, the task will only be cancelled if
the function was told the channel should currently have a task
scheduled. This means warnings for missing tasks will appear when they
should.
The previous approach of checking if a task exists was flawed because
it had no way to tell whether a task *should* exist. It assumed nothing
is wrong if a task doesn't exist.
Currently, the only case when a task shouldn't exist is when the
cog is initialised and channels from the bot's previous life are being
scheduled.
|
|
The dictionary which was iterated to cancel tasks is now "private".
Therefore, the scheduler should provide a public API for cancelling
tasks.
* Delete the task before cancelling it to prevent the done callback,
however unlikely it may be, from deleting the task first
|
|
|
|
Prefixing them early on means subsequent code doesn't have to deal with
stripping the prefix from channel names in order to get their positions.
* Remove `count` parameter from `get_names`; define it in the body
|
|
* Store queue get() tasks in a list
* Create a separate function to wait for a channel from the queue
* Add comments for the various groups of attributes defined in __init__
|
|
|
|
This gives the newest questions the most visibility.
|
|
Initialising the dictionary with help channel IDs doesn't work anymore
since help channels are now dynamic.
|
|
|
|
The notification feature is not critical for the functionality of the
help channel system. Therefore, the exception should not be allowed to
propagate and halt the system in some way.
|
|
* Rename function `notify_helpers` -> `notify`
* Use bullet-point list for config options in the docstring
|
|
|
|
|
|
|
|
|
|
* Add configurable constant for minimum interval
* Move helper notifications to a separate function
|
|
|
|
Send a message in the #helpers channel pinging the @helpers role to
notify them of a lack of help channels. Can be toggled off in the
config.
|
MarkKoz