| Commit message (Collapse) | Author | Lines |
|
Python joins two string adjacent string literals implicitly, which may
cause unintended side effects when used with certain string methods.
>>> 'A' ' '.join(['1', '2', '3'])
'1A 2A 3'
|
|
|
|
Co-authored-by: Kieran Siek <[email protected]>
|
|
|
|
Pagination means more characters can be supported without cluttering
anything. It also means infinite lines, so there's no longer a need to
squeeze out the most from a single page. Reducing the line limit leads
to a smaller, tidier presentation.
|
|
Since the raw field is displayed on every page, but pages are
incomplete, it may be unclear whether the field's value is for the
current page or for all pages.
Co-authored-by: Kieran Siek <[email protected]>
|
|
It's clearer to write MAX_CHANNELS - 2 than a literal 48.
|
|
|
|
The test has to account for not only the name not matching, but also
a lack of available spaces for new channels.
|
|
|
|
|
|
|
|
Kind of redundant since it's only used by two tests.
|
|
|
|
stop needs to be called on the patcher, not the mock. Furthermore,
using addCleanup is safer than tearDown because the latter may not be
called if an exception is raised in setUp.
|
|
Pagination ensures the results will never go over the char limit for
an embed.
Fixes #897
Fixes BOT-3D
|
|
|
|
|
|
|
|
|
|
This reverts commit 776b4379c478284803a4a526b5f14fe63d8e7c01.
This is already being fixed in #835, and therefore is no longer
required.
|
|
This also accounts for the author passing themselves to mention, and
therefore avoids the user from being told they're not allowed to mention
themselves even though they could.
|
|
|
|
|
|
The reminder expiration returnedfrom the API call is also now parsed
again even when the edit is to the duration since it does not matter and
trying to keep it DRY while still doing that check is a pain.
|
|
|
|
|
|
|
|
|
|
Co-authored-by: Mark <[email protected]>
|
|
In addition to 404, this shouldn't send Sentry notifs.
Co-authored-by: MarkKoz <[email protected]>
|
|
|
|
Co-authored-by: MarkKoz <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The function `_delete_reminder` was called twice, once in
`schedule_reminder`, which calls `send_reminder`, then another in
`send_reminder` itself. This led to a 404 response from the site api, as
the reminder was already deleted the first time.
Fixes BOT-6W
|
|
|
|
|
|
https://github.com/python-discord/bot/issues/1041
|
|
Weird.
https://github.com/python-discord/bot/issues/1041
|
|
When we're using the !reply command, using a regular UserConverter is
somewhat problematic. For example, if I wanted to send the message
"lemon loves you", then I'd try to write `!reply lemon loves you` -
however, the optional User converter would then try to convert `lemon`
into a User, which it would successfully do since there's like 60 lemons
on our server.
As a result, the message "loves you" would be sent to a user called
lemon.. god knows which one.
To solve this bit of ambiguity, I introduce a new converter which only
converts user mentions or user IDs into User, not strings that may be
intended as part of the message you are sending.
https://github.com/python-discord/bot/issues/1041
|
|
Co-authored-by: Sebastiaan Zeeff <[email protected]>
|
|
https://github.com/python-discord/bot/issues/1041
|
|
Without this, it is difficult to know precisely who the user that is
DMing us is, which might be useful to us.
https://github.com/python-discord/bot/issues/1041
|