aboutsummaryrefslogtreecommitdiffstats
path: root/tests/helpers.py (unfollow)
Commit message (Collapse)AuthorLines
2020-05-25Token remover: use finditer instead of findallGravatar MarkKoz-4/+3
It makes more sense to use the lazy function when the loop is already short-circuiting on the first valid token it finds.
2020-05-25Token remover: use regex groups and pass the token as a NamedTupleGravatar MarkKoz-27/+20
It felt redundant to be splitting the token in two different functions when regex could take care of this from the outset. ' A NamedTuple was created to house the token. This is nicer than passing an re.Match object, because it's clearer which attributes are available. Even if the regex used named groups, it wouldn't be as obvious which group names exist. Without the split, `is_maybe_token` is dwindled down to a redundant function. Therefore, it's been removed.
2020-05-23Token remover: escape dashes in regexGravatar MarkKoz-1/+1
They need to be escaped when they're in a character set. By default, they are interpreted as part of the character range syntax.
2020-05-21Token remover: match only base64 in regexGravatar MarkKoz-7/+6
Making the regex more accurate reduces false positives at an earlier stage. There's no benefit to matching non-base64 as that would just be weeded out as invalid at a later stage anyway when it tries to decode it.
2020-05-21Token remover: decode ID using URL-safe base64Gravatar MarkKoz-1/+1
Though I've not seen an ID with neither + and \ nor - and _, given that the timestamp uses URL-safe encoding, the ID probably does too.
2020-05-16Add a utility function to pad base64 dataGravatar MarkKoz-2/+8
2020-05-15Token remover: use strict check for digits in token IDGravatar MarkKoz-2/+5
`isnumeric` would be true for a wide range of characters in Unicode, but the ID must only consist of the characters 0-9 (ASCII digits). In fact, `isdigit` on its own would also match other Unicode characters too.
2020-05-14Token remover: fix timestamp checkGravatar MarkKoz-10/+16
The timestamp calculation was incorrect. The bytes need to be interpreted as big-endian and the result is just a timestamp rather than a snowflake.
2020-05-13Token remover: add logs to clarify why token is invalidGravatar MarkKoz-2/+4
2020-05-13Add missing comma to token remover log messageGravatar MarkKoz-1/+1
2020-05-13Fix a test needlessly being a coroutineGravatar MarkKoz-1/+1
2020-05-11Use subtests for valid ID/timestamp tests and test non-ASCII inputsGravatar MarkKoz-18/+25
2020-05-11Clean up token remover test importsGravatar MarkKoz-16/+12
2020-05-11Replace deprecated assertion methodsGravatar MarkKoz-2/+2
2020-05-11Refactor `TokenRemoverSetupTests` and add a more thorough testGravatar MarkKoz-4/+8
The test now ensures the cog is instantiated and that the instance is passed as an argument to `add_cog`.
2020-05-11Test TokenRemover.take_actionGravatar MarkKoz-43/+30
* Remove `bot.get_cog` mocks in `setUp` * Mock the logger cause it's easier to assert logs * Remove subtests * Assert helper functions were called * Create an autospec for ModLog
2020-05-11Test TokenRemover.format_log_messageGravatar MarkKoz-0/+16
2020-05-11Test token remover's message deletionGravatar MarkKoz-0/+9
2020-05-11Simplify token remover's message mockGravatar MarkKoz-9/+3
* Rely on default values for the author * Set the content to a non-empty string
2020-05-11Avoid instantiating the cog when testing static/class methodsGravatar MarkKoz-10/+5
2020-05-11Token remover: use a string template for the log messageGravatar MarkKoz-4/+11
2020-05-11Token remover: split some of `take_action` into separate functionsGravatar MarkKoz-11/+21
2020-05-11Correct the return type annotation for the autospec decoratorGravatar MarkKoz-2/+2
2020-05-11Test token regex matches valid tokensGravatar MarkKoz-0/+21
2020-05-11Test is_maybe_tokenGravatar MarkKoz-7/+24
2020-05-11Token remover: fix `is_maybe_token` returning None instead of FalseGravatar MarkKoz-0/+2
It's annotated as returning a bool and when the split fails it already returns False. To be consistent, it should always return a bool.
2020-05-11Test `is_maybe_token` returns False for missing partsGravatar MarkKoz-0/+10
In practice, this won't ever happen since the regex wouldn't match strings with missing parts. However, the function does check it so may as well test it. It's not necessarily bound to always use inputs from the regex either I suppose.
2020-05-11Fix autospec decorator when used with multiple attributesGravatar MarkKoz-16/+12
The original approach of messing with the `attribute_name` didn't work for reasons I won't discuss here (would require knowledge of patcher internals). The new approach doesn't use patch.multiple but mimics it by applying multiple patch decorators to the function. As a consequence, this can no longer be used as a context manager.
2020-05-11Test token regex doesn't match invalid tokensGravatar MarkKoz-7/+25
2020-05-11Test `find_token_in_message` returns the found tokenGravatar MarkKoz-0/+24
2020-05-11Test `find_token_in_message` returns None if no matches foundGravatar MarkKoz-0/+14
2020-05-11Fix test for token remover ignoring bot messagesGravatar MarkKoz-4/+9
It's not possible to test this via asserting the return value of `on_message` since it never returns anything. Instead, the actual relevant unit, `find_token_in_message,` should be tested.
2020-05-11Allow using arbitrary parameter names with the autospec decoratorGravatar MarkKoz-2/+15
This gives the caller more flexibility. Sometimes attribute names are too long or they don't follow a naming scheme accepted by the linter.
2020-05-11Test token remover skips messages without tokensGravatar MarkKoz-0/+11
2020-05-11Test token remover takes action if a token is foundGravatar MarkKoz-1/+13
2020-05-11Add a test helper function to patch multiple attributes with autospecsGravatar MarkKoz-0/+9
This helper reduces redundancy/boilerplate by setting default values. It also has the consequence of shortening the length of the invocation, which makes it faster to use and easier to read.
2020-05-11Test on_message_edit of token remover uses on_messageGravatar MarkKoz-2/+10
2020-05-11Token remover: reduce duplicated code in `on_message_edit`Gravatar MarkKoz-3/+1
2020-05-11Token remover: catch ValueError when non-ASCII chars are presentGravatar MarkKoz-2/+2
The token uses base64 and base64 only allows ASCII characters. Thus, if a match has non-ASCII characters, it's not a valid token. Catching the ValueError is simpler than trying to adjust the regex to only match valid base64. Fixes #928 Fixes BOT-3X
2020-05-11Restructure `apply_ban()` logic Gravatar Daniel Brown-12/+7
Another refactor/cleaning to make the logic clearer and easier to understand. Also cleaned up the trace logs to be shorter and more concise. Thanks, @scragly! Co-authored-by: scragly <[email protected]>
2020-05-10Add remindme alias for the remind commandGravatar Suhail-1/+1
2020-05-07apply_ban() logic refinedGravatar Daniel Brown-15/+15
- Refined the logic for `apply_ban()` even further to be cleaner. (Thanks, @MarkKoz!) Signed-off-by: Daniel Brown <[email protected]>
2020-05-07Addressing Review ChangesGravatar Daniel Brown-25/+31
- Changed docstring explanation and function name of `get_active_infractions` to `get_active_infraction()` to better convey that only one infraction is returned. Also changed all relevant uses to reflect that change. - Added explanation of parameter `send_msg` to the doc strings of `pardon_infraction()` and `get_active_infraction()` - Adjusted placement of `log.trace()` in `pardon_infraction()` - Adjusted logic in `apply_ban()` to remove redundant check. - Adjusted logic in `apply_ban()` to be consistent with other checks. Signed-off-by: Daniel Brown <[email protected]>
2020-05-04Update antimalware to filter txt files in cases where messages were longer ↵Gravatar Savant-Dev-5/+5
than 2000 chars
2020-05-04Perma Bans now Overwrite Temp BansGravatar Daniel Brown-18/+55
- Changed `has_active_infraction` to `get_active_infractions` in order to add additional logic in `apply_ban`. - Added `send_msg` parameters to `pardon_infraction` and `get_active_infractions` so that multi-step checks and actions don't need to send additional messages unless told to do so. Signed-off-by: Daniel Brown <[email protected]>
2020-05-02Remove mention command constantsGravatar MarkKoz-10/+0
2020-05-01Remove the mention commandGravatar MarkKoz-46/+2
It was made obsolete by a new Discord feature. Users can be granted a permission to mention a role despite the role being set as non-mentionable.
2020-05-01Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev-1/+1
longer than 2000 characters
2020-05-01Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev-0/+12
longer than 2000 characters
2020-04-30Tests: change avatar_url_as assertion to use static_formatGravatar MarkKoz-1/+1
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-27 12:49:55 +0000