aboutsummaryrefslogtreecommitdiffstats
path: root/tests/helpers.py (unfollow)
Commit message (Collapse)AuthorLines
2020-03-09Check lower bound for vote options.Gravatar scragly-0/+2
If the vote command receives less than 2 options, it's not being used for it's intended usage and is considered a user input error.
2020-03-09Implement vote command.Gravatar scragly-0/+18
The vote command takes a given list of options and generates a simple message and corresponding reactions for each so members can quickly take a vote on a subject during in-server discussions and meetings.
2020-03-09Refactored to use paginator like normal `!tag`Gravatar Shirayuki Nekomata-12/+20
- Split `_get_tags_via_content` - introduce `_send_matching_tags` - `_send_matching_tags` will send and paginate like `!tag` - Simplified `is_plural` even more.
2020-03-08Refactor token detection to check all potential substrings in messageGravatar S. Co1-3/+10
2020-03-08Fix filtered extension string out of scope for log messageGravatar S. Co1-2/+2
* Fix typo in file extensions list comprehension
2020-03-08Fixed `is_plural` counting 1 less space.Gravatar Shirayuki Nekomata-1/+1
Co-Authored-By: Mark <[email protected]>
2020-03-08Refactored dense codes, removed obvious type hint.Gravatar Shirayuki Nekomata-15/+25
- Show the process of sanitizing the List[str] `keywords_processed`. - Show the process of finding tag for `matching_tags` ( was `founds` ). - Refactored the logic to find boolean `is_plural`. - Minor wording changes for docstring.
2020-03-08Fixed searching for `,` returing all tags. Made it more descriptive when ↵Gravatar Shirayuki Nekomata-3/+7
multiple tags are found. - Added a truthy check for each `query` since `','.split()` returns a list of two empty strings. - Changed from `Did you mean ...` to `Here are the tags containing the given keyword(s):` to be much more descriptive about the results - they are `tag` and not `term` to be searched.
2020-03-08Refactored tag searching via keywords in contentsGravatar Shirayuki Nekomata-8/+6
- Refactored `if` block - change to only send result when there is any result. - Added better type hinting for `check` argument of `_get_tags_via_content` - changed from `callable` to `Callable[[Iterable], bool]`. Thanks to @markkoz 's reviews Co-Authored-By: Mark <[email protected]>
2020-03-08Implemented `search` as a subcommand for `tag` that will search in contents ↵Gravatar Shirayuki Nekomata-1/+50
instead of names - `!tag search` will search for multiple keywords, separated by comma, and return tags that has ALL of these keywords. ` !tag search any` is the same as `!tag search` but it return tags that has ANY of the keyword instead.
2020-03-05Remove excludes from pre-commitGravatar MarkKoz-1/+0
It was excluding files that are already ignored by git. Pre-commit respects git ignore, even with --all-files, so these ignores were redundant.
2020-03-05CI: don't show diff after pre-commit hooksGravatar MarkKoz-1/+1
It's noisy, messy output. It's not of much benefit anyway as users can run git diff locally if they really need to see a diff. They have to do work locally anyway since CI won't commit the fixes pre-commit makes.
2020-03-05Raise BadArgument if no string match.Gravatar scragly-0/+3
2020-03-05Re-use embed, use command converter, raise BadArgument.Gravatar scragly-37/+22
2020-03-05(Information Cog, !roles command test): Removed 's' at end of "Total 1 ↵Gravatar ks123-1/+1
role(s)" due changes in command.
2020-03-05(Information Cog, !roles command): Added 's' to end of 'role' only if there ↵Gravatar ks123-1/+1
is more then 1 role.
2020-03-05(Information Cog, !roles command test): Applied empty parameter change.Gravatar ks123-1/+1
2020-03-05(Information Cog, !roles command): Added empty parameter to pagination (False)Gravatar ks123-1/+1
2020-03-04Use raw strings for docstrings with forward slashesGravatar Sebastiaan Zeeff-3/+3
A few docstrings in `bot.cogs.extensions` have forward slashed in them to escape Markdown rendering when our help feature uses these docstring in a Discord message. However, the use of forward slashes with an invalid escape sequence in docstrings now raises a DeprecationWarning in Python: /home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \* PEP 257 (Docstring Conventions, https://www.python.org/dev/peps/pep-0257/) states that raw strings should be used for docstrings that use forward slashes, so I've added the `r`-prefix to the docstrings that use forward slashes.
2020-03-03Update code for pep8-naming complianceGravatar S. Co1-6/+6
2020-03-03Remove CaseInsensitiveDictGravatar S. Co1-94/+0
This was added by the now-removed Snake cog & is not used elsewhere on bot.
2020-03-03Add pep8-naming & relockGravatar S. Co1-14/+28
2020-03-03CI: mock the pipenv binaryGravatar MarkKoz-0/+10
The mock gets used by the flake8 pre-commit hook, which invokes flake8 via `pipenv run flake8`. It's normally useful to use pipenv here cause it ensures flake8 is invoked within the context of the venv. However, in CI, there is no venv - dependencies are installed directly to the system site-packages. `pipenv run` does not work in such case because it tries to create a new venv if one doesn't exist (it doesn't consider the system interpreter to be a venv). This workaround (okay, it's a hack) creates an executable shell script which replaces the original pipenv binary. The shell script simply ignores the first argument (i.e. ignores `run` in `pipenv run`) and executes the rest of the arguments as a command. It essentially makes `pipenv run flake8` equivalent to just having ran `flake8`. When pre-commit executes pipenv, the aforementioned script is what will run.
2020-03-03CI: add a restore key for the pre-commit cacheGravatar MarkKoz-1/+3
A cache for an outdated pre-commit environment may still be useful. It may be the case that only some hooks need to be updated rather than all.
2020-03-03Use pre-commit in pipenv lint scriptGravatar MarkKoz-4/+12
2020-03-03Prevent exception if a watched user sends a DM to the botGravatar S. Co1-2/+9
The previous embed assumed that the messages would be sent on the server, where the channel would have a name and the message would have a jump URL. For a DM, neither of these are present and an exception will be raised when attempting to construct the embed for the webhook to send.
2020-03-03Fix typo in commentGravatar Mark-1/+1
Co-Authored-By: Leon Sandøy <[email protected]>
2020-03-02Add more pre-commit hooksGravatar MarkKoz-10/+27
* Remove trailing whitespaces * Specify error code for a noqa in the free command
2020-03-02Adding helpers to the Filtering whitelistGravatar Leon Sandøy-0/+1
Resolves an issue mentioned in https://github.com/python-discord/bot/issues/767, giving Helpers access to post invites and other things caught by the Filtering cog.
2020-03-01Add grabify (IP logger) domains to banned domainsGravatar Joseph-0/+24
2020-03-01Modify log test regex to be non-os-specificGravatar S. Co1-1/+1
Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
2020-03-01Move syncer confirmation reaction check out of finally clauseGravatar S. Co1-11/+11
Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function
2020-03-01Bump Dependencies & RelockGravatar S. Co1-78/+76
* Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests.
2020-03-01Add logging to antimalware cog & expand user feedbackGravatar S. Co1-17/+24
* Add generic handling for multi-file uploads * Log user, id, and blocked extensions * Provide the full list of attachment filenames as a logging extra * Provide feedback on all blacklisted file types uploaded
2020-03-01Optimize DockerfileGravatar Spencer Young-2/+5
2020-03-01!roles Command Test: Applied !roles command changesGravatar Karlis. S-3/+2
2020-03-01!roles Command: Added pagination (LinePaginator), moved roles amount to ↵Gravatar Karlis. S-8/+7
title (was before in footer).
2020-02-29Make logs coloured!Gravatar MarkKoz-7/+23
2020-02-29Install the coloredlogs packageGravatar MarkKoz-40/+66
This makes it easy to add colour to the logs. Colorama is also installed if on a Windows system.
2020-02-29Migrate snekbox tests to Python 3.8's unittestGravatar Sebastiaan Zeeff-41/+27
I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks. In particular, I had to make a few changes: - Mocking the async post() context manager correctly Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called). - Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with` Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited. - Patch `functools.partial` as `partial` objects are compared by identity When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
2020-02-28Scheduler: correct type annotationsGravatar MarkKoz-6/+6
2020-02-28Snekbox: mention re-evaluation feature in the command's docstringGravatar MarkKoz-1/+4
2020-02-28Ignore NotFound errors inside continue_evalGravatar Matteo-24/+25
It could have caused some errors if the user delete his own message
2020-02-28Return only the new code in continue_eval and check for truthiness insteadGravatar Matteo-11/+10
2020-02-27Scheduler: log the exception instead of raisingGravatar MarkKoz-2/+5
Logging it ourselves has a cleaner traceback and gives more control over the output, such as including the task ID.
2020-02-27Remove unnecessary newlines from call.Gravatar Numerlor-4/+1
2020-02-27Moderation: fix task cancellation for permanent infraction when editingGravatar MarkKoz-1/+3
A task should not be cancelled if an infraction is permanent because tasks don't exist for permanent infractions. Fixes BOT-1V
2020-02-27Use unicode code point instead of literal for the snekbox re-eval emojiGravatar Matteo-6/+8
Unicode literals aren't really safe compared to code points
2020-02-27Split the eval command procedure into two functions.Gravatar Matteo-114/+148
Two functions were created: send_eval and continue_eval, in order to facilitate testing. The corresponding tests are also changed in this commit.
2020-02-26Add clarifying comment to role checking logic implementationGravatar S. Co1-0/+1