| Commit message (Collapse) | Author | Lines | ||
|---|---|---|---|---|
| 2021-10-11 | Remove unnecessary check for embed when sending | -1/+1 | ||
| 2021-10-11 | Correct log trace link to show the correct behaviour | -1/+1 | ||
| 2021-10-11 | Mock id,content attribute rather than type casting | -5/+6 | ||
| 2021-10-11 | Update tests for message link embeds | -15/+29 | ||
| This commit updates the test in accordance with 0b35f2a and 0c5561d. | ||||
| 2021-10-11 | Use raw message delete listener | -8/+8 | ||
| 2021-10-11 | Use `on_raw_message_edit` | -3/+12 | ||
| Originally it was using `on_message_edit` which would have failed if the message was not in the bot' cache. Therefore we would have to use a raw listener. | ||||
| 2021-10-11 | Delete msg link embed if no link on edit | -0/+4 | ||
| Earlier, if we edited a message which contained message links originally but not now, then the webhook message wouldn't get deleted. This commits fixes that bug. | ||||
| 2021-10-11 | Make `extract_message_links` an instance method | -31/+30 | ||
| Since it was used cog's state (`self.bot`), it would be better to move it to the cog. | ||||
| 2021-10-11 | Use better variable names | -2/+4 | ||
| This commit also adds a line which was got removed by mistake earlier. | ||||
| 2021-10-11 | Apply requested changes to doc strings | -4/+4 | ||
| 2021-10-11 | Only process the first 10 message links | -3/+1 | ||
| 2021-10-11 | (incidents):Log with error if webhook not found | -0/+3 | ||
| 2021-10-11 | (incidents): Use subtests for test_shorten_text | -4/+4 | ||
| 2021-10-11 | (incidents): Add test for text shortner | -10/+18 | ||
| Pass all 3 cases of text shortening to the test case and test them, the cases being: i. If the message is just one word, then shorten to 50 characters. ii. Maximum lines being 3. iii. Maximum characters being 300. This commit also removes a misc bug, of passing self, while asserting equal. | ||||
| 2021-10-11 | (incidents): Refactor text shortner | -10/+16 | ||
| 2021-10-11 | Rework text shortner. | -4/+19 | ||
| Explanation: It is unnecessary to show 300 characters, when there is only one word which is so long, so if there is only one word in the text, it would be truncated to 50 words. Also in some cases, there are messages of many lines with 1 word on each line(say), this would again make the embed big and polluting, so it would limit the number of lines to a maximum of 3. Rest of the feature is the same as before. This implementation has been inspired from the `format_output` function of snekbox cog. | ||||
| 2021-10-11 | Write tests for this feature | -3/+66 | ||
| In short, I have written two tests, one which tests the whether `extract_message_links` is called on message edits or not. And the second one to test the regex of `extract_message_links` and assert the message link embeds sent by it. Special thanks to kwzrd💜#1198 for helping me out with it. | ||||
| 2021-10-11 | Fix truncation bug | -3/+4 | ||
| When you take a long message, just one word of 400 A's then the truncated wouldn't be able to handle it properly and just return the placeholder. This is a bug in the textwrap.shorten function. To solve this, I went the long way to use slicing on the list. This commit seems to have resolved the bug. | ||||
| 2021-10-11 | Handle discord.errors.NotFound while deleting msg link webhook embeds | -1/+4 | ||
| 2021-10-11 | Remove leading whitespace from msg link embed content | -1/+1 | ||
| 2021-10-11 | Rename 'send_webhooks' to 'send_message_link_embed' | -3/+3 | ||
| Co-authored-by: Boris Muratov <[email protected]> | ||||
| 2021-10-11 | Appy requested grammar changes. | -5/+5 | ||
| Co-authored-by: Boris Muratov <[email protected]> | ||||
| 2021-10-11 | Remove redundant code | -4/+2 | ||
| 2021-10-11 | Rework message link embed. | -7/+9 | ||
| - Instead of default black colour, use gold to give it some shine! - Mention the channel also in the channel field. - Add message ID in footer, so it is easy to figure out for which message link is that embed. | ||||
| 2021-10-11 | Bug fixes | -16/+14 | ||
| - `await` message link embeds cache get - don't double send webhook embeds (edit, send) on message edits | ||||
| 2021-10-11 | Don't send errors, instead log them. | -9/+9 | ||
| Errors shouldn't be sent in #incidents. Instead, log them with log.exception and make the function return. | ||||
| 2021-10-11 | Do required flake8 changes in docstrings. | -4/+8 | ||
| 2021-10-11 | Use tasks to fetch incidents channel webhook. | -9/+13 | ||
| 2021-10-11 | On msg edits, edit the msg link embed rather than deleting it | -4/+9 | ||
| 2021-10-11 | Make incidents channel webhook a cog level attribute | -6/+6 | ||
| This would not fetch it everytime. | ||||
| 2021-10-11 | Use str() rather than f string for single variable. | -1/+1 | ||
| Makes the intent much more clear. | ||||
| 2021-10-11 | Don't allow more than 10 embeds per report. | -53/+32 | ||
| If more than 10 embeds found, just get the first 10 and ignore the rest. | ||||
| 2021-10-11 | Revert changes done by black. | -43/+13 | ||
| 2021-10-11 | Updates type hints for `message_link_embeds_cache`. | -1/+7 | ||
| 2021-10-11 | Refactors code. | -26/+94 | ||
| Earlier on message edit the message wasn't run through extract message links to see if new message links are added or if some got deleted. Similarly the cache was updated when a message got deleted. Now it makes extract message links a helper function and runs it on message edits and deletes in case there are some changes in the message links. This commit also updates the doc strings for functions according to the new changes done. | ||||
| 2021-10-11 | Use `DiscordException` instead of broad exception clause. | -2/+2 | ||
| 2021-10-11 | Apply grammar and style changes. | -13/+20 | ||
| 2021-10-11 | Run black code formatter. | -21/+53 | ||
| 2021-10-11 | Ignore N802 in 'asyncSetUp' and 'asyncTearDown' function in test_incidents.py | -2/+2 | ||
| 2021-10-11 | Allign comments to maintain readability | -3/+3 | ||
| 2021-10-11 | Modify tests to support redis cache, done with the help @SebastiaanZ | -16/+16 | ||
| 2021-10-11 | Run webhook message deletion if webhook_msg_id var is True | -5/+7 | ||
| 2021-10-11 | Update regex to support all message links i.e. support for 'app', 'canary', ↵ | -3/+4 | ||
| 'ptb' | ||||
| 2021-10-11 | Add a docstring to 'send_webhooks' function | -0/+9 | ||
| 2021-10-11 | If message content more than 500 characters shorten it done to 300 characters | -24/+34 | ||
| 2021-10-11 | Rollback to changes which aren't required | -6/+6 | ||
| 2021-10-11 | Fix tests according to the changes done to incidents.py | -3/+19 | ||
| 2021-10-11 | Use str() when checking for message.content | -1/+1 | ||
| 2021-10-11 | Use MessageConverter to find messages | -25/+35 | ||
| 2021-10-11 | Send multiple webhook messages in case of more than 10 message links | -9/+22 | ||