| Commit message (Collapse) | Author | Lines |
|---|
|
|
|
|
|
|
|
|
|
Co-Authored-By: Mark <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Unfortunately, trying to set positions for the help channels during their move from one category to another does not work to well. It introduces a number of glitches and we haven't been able to reliably get a channel to go to a specific position either.
This commit simply removes any attempt to set a position and lets Discord handle it.
|
|
The help channels in the `Help: Available` category should automatically synchronize their permissions with the category permissions to ensure that the overwrites we use to prevent people from claiming multiple help channels are properly enforced. Unfortunately, for unknown reasons, they sometimes get in an "out of sync" state that requires intervention to get them back in sync.
This PR mitigates that issue by checking the available channel for their synchronisation status during certain critical times in our help channel system:
1. Whenever the overwrites for the category change
2. Whenever a channel is moved into the new category
3. After the categories have been reset during the initialization process
The check is straightforward: The `ensure_permissions_synchronization` method iterates over all the channels in the category and checks if the channels are currently synchronizing their permissions. If not, we remedy that by making a channel edit request to the Discord API. If all channels were already "in sync", no API calls are made. The latter should make this an inexpensive mitigation procedure: As we typically have very few channels in the available category and channels mostly stay in sync, we typically do very little.
To make this process a bit easier, I've factored out `set_permissions` calls to a helper function that also calls the `ensure_permissions_synchronization` method. The only exception is during the reset process: As we may edit multiple permissions in this loop, it's better to only ensure the synchronization after we're done with all permission changes.
|
|
The embed displayed in available help channels still used the term "in use" instead of "occupied". I've updated the embed to reflect the new name of the "occupied" category.
|
|
As Discord is having a rather persistent issue with one of the channels in the current `Help: In Use` category, we're going to start using a new category that excludes the old channel.
The old channel, help-argon, appears to be completely broken on Discord's end, resulting in "Not found" errors for any kind of interaction, including channel move and/or channel delete admin actions. As it's still visible, it's currently triggering a lot questions from our members. We hope that using a new category will fix that.
|
|
The set that keeps track of the used channel names should discard emojis. To do that, I'm cleaning the names before they're added to the set of channel names.
|
|
The help channel prefix is configurable as a constant, but I accidentally used a static prefix in the utility function that cleaned the channel names. This commit makes sure the utility method uses the prefix defined in the constants.
|
|
The current approach of trying to find the maximum channel position, adding one, and using that as the position integer for channels does not seem to work reliably. An approach that seems to work in the testing environment is using a very large integer for the position attribute of the channel: It wil be sorted at the bottom and Discord will automatically scale the integer down to `max + 1`.
This also means the `get_position` utility function is no longer needed; it has been removed.
|
|
I've added channel status emojis as a prefix to our help channels to make it more obvious to the end user what the current status of a channel is. All channels in the Available category will be marked with a green checkmark emoji, while all channels in the In Use category will be marked with an hourglass. Channels in the Dormant category stay unadorned.
Channels will be stripped of their previous prefix when moved to another category. This relies on the `help-` naming convention, as that is the most reliable way to do it that does not break if we ever opt for another emoji.
|
|
The current sorting algorithm we used created unpredictable channel order (for our human end-users) and induced a flickering channel light-show in Discord clients. To combat these undesirable side-effects, I've changed the ordering to always order channels at the bottom of a category. This also means that channels looking for answers the longest will naturally float up.
|
|
|
|
|
|
|
|
The Coding Den is a language agnostic community that's been around for years with over 12000 members.
I think we can allow that invite in our community.
|
|
Co-Authored-By: Mark <[email protected]>
|
|
infraction that is already expired and reason not specified.
|
|
existing function.
|
|
custom/new one.
|
|
`send_embed_with_trashcan` function.
|
|
|
|
`send_embed_with_trashcan`, applied to docstring and to command.
|
|
|
|
The edit causes two channel update events to dispatch simultaneously:
one for the channel topic changing and one for the category changing.
The ModLog cog currently doesn't support ignoring multiple events of
the same type for the same channel. Therefore, the ignore was hard coded
rather than using the typical ignore mechanism.
This is intended to be a temporary solution; it should be removed once
the ModLog is changed to support this situation.
|
|
|
|
Co-Authored-By: Leon Sandøy <[email protected]>
|
|
The "unsilence" action of the silence/hush command used `send_messages=True` when unsilencing a hushed channel. This had the side effect of also enabling send messages permissions for those with the Muted rule, as an explicit True permission apparently overwrites an explicit False permission, even if the latter was set for a higher top-role.
The solution is to revert back to the `Inherit` permission by assigning `None`. This is what we normally use when Developers are allowed to send messages to a channel.
|
|
|
|
|
|
deletion handling.
|
|
|
|
|
|
There is no longer a reliance on static alphabetical position numbers.
|
|
When a channel is moved, all channels below have their positions
incremented by 1. This threw off the previous implementation which
relied on position numbers being static.
Co-authored-by: Sebastiaan Zeeff <[email protected]>
|
|
|
|
|
|
moved PEP 0 sending to function.
|
|
|
|
|
|
docstrings, string formatting and URL hiding to show in logs.
Co-Authored-By: Mark <[email protected]>
|
|
|
Joseph Banks
Sebastiaan Zeeff
S. Co1
Leon Sandøy
Karlis S
ks123
MarkKoz