| Commit message (Collapse) | Author | Lines |
|
This will be used to prevent race conditions on a resource by stopping
all other access to the resource once its been acquired.
|
|
|
|
|
|
|
|
It's fine to accept an int since it'll get converted to a string anyway.
|
|
Only one call was benefiting from that function also cancelling the
task. Therefore, the function was redundant and has been replaced with
a direct request to delete.
This change has the consequence of also fixing reminder tasks cancelling
themselves. That issue was potentially suppressing errors (such as the
duplicate DELETE request which was fixed earlier). Under normal
circumstances, the scheduler will automatically removed finished tasks
so tasks won't need to cancel/remove themselves.
|
|
`send_reminder` already deletes the reminder so it's redundant to
delete it in the scheduled task too.
|
|
This adds a little bit of logic to the Help Channel `init_available`
coroutine, which runs when the cog loads. This ensures that if there are
more help channels in available than there should be, we remove the
superfluos ones.
Previously, if the bot started with too many channels, it would maintain
and defend that excessive amount. This is because we never actually
count the number of channels before adding in new available channels
whenever one disappears.
If we ever get too many available channels in the future, this can be
solved by simply reloading this cog.
|
|
requested by lemon
|
|
|
|
|
|
|
|
|
|
We don't need a ping in #mod-alerts whenever someone is tripping a
filter (like invites or bad language) in a DM to the bot. We can still
send an embed, so that we can action it, but there is no urgent need to
respond if it's just a direct message to the bot.
This is particularly true now that we have #dm-log.
|
|
|
|
|
|
|
|
|
|
I've updated the IDs of the two Code Jam Roles to the
newly create roles we have.
|
|
Python joins two string adjacent string literals implicitly, which may
cause unintended side effects when used with certain string methods.
>>> 'A' ' '.join(['1', '2', '3'])
'1A 2A 3'
|
|
|
|
Co-authored-by: Kieran Siek <[email protected]>
|
|
|
|
Pagination means more characters can be supported without cluttering
anything. It also means infinite lines, so there's no longer a need to
squeeze out the most from a single page. Reducing the line limit leads
to a smaller, tidier presentation.
|
|
Since the raw field is displayed on every page, but pages are
incomplete, it may be unclear whether the field's value is for the
current page or for all pages.
Co-authored-by: Kieran Siek <[email protected]>
|
|
It's clearer to write MAX_CHANNELS - 2 than a literal 48.
|
|
|
|
The test has to account for not only the name not matching, but also
a lack of available spaces for new channels.
|
|
|
|
|
|
|
|
Kind of redundant since it's only used by two tests.
|
|
|
|
stop needs to be called on the patcher, not the mock. Furthermore,
using addCleanup is safer than tearDown because the latter may not be
called if an exception is raised in setUp.
|
|
Pagination ensures the results will never go over the char limit for
an embed.
Fixes #897
Fixes BOT-3D
|
|
|
|
|
|
|
|
|
|
This reverts commit 776b4379c478284803a4a526b5f14fe63d8e7c01.
This is already being fixed in #835, and therefore is no longer
required.
|
|
This also accounts for the author passing themselves to mention, and
therefore avoids the user from being told they're not allowed to mention
themselves even though they could.
|
|
|
|
|
|
The reminder expiration returnedfrom the API call is also now parsed
again even when the edit is to the duration since it does not matter and
trying to keep it DRY while still doing that check is a pain.
|
|
|
|
|
|
|
|
|
|
Co-authored-by: Mark <[email protected]>
|
|
In addition to 404, this shouldn't send Sentry notifs.
Co-authored-by: MarkKoz <[email protected]>
|