aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | | | | | | | * | Log invalid tag names in the error handler tag fallback.Gravatar Numerlor2020-02-26-5/+13
| | | | | | | | | |
| | | | | | | | * | Remove logging from tag converters.Gravatar Numerlor2020-02-26-10/+0
| | | | | | | | | |
| | | | | | | | * | Adjust tests for new converter behavior.Gravatar Numerlor2020-02-26-1/+1
| | | | | | | | | |
| | | | | | | | * | Remove number check on tags.Gravatar Numerlor2020-02-26-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This case is already covered by checking if at least one letter is included.
| | | | | | | | * | Pass error handler tag fallback through TagNameConverter.Gravatar Numerlor2020-02-26-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tag fallback didn't convert tags, resulting in possible invalid tag names being passed to the `tags_get_command`. This makes sure they're valid and ignores the risen exception if they are not.
| | | | | | | | * | Make sure tag name contains at least one letter.Gravatar Numerlor2020-02-26-0/+6
| |_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | With only ascii and numbers being allowed to go through, possible values still included things like `$()` which don't match anything in `REGEX_NON_ALPHABET` from tags.py resulting in an error.
| | | | | | | | * Scheduler: correct type annotationsGravatar MarkKoz2020-02-28-6/+6
| | | | | | | | |
| | | | | | | | * Scheduler: log the exception instead of raisingGravatar MarkKoz2020-02-27-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Logging it ourselves has a cleaner traceback and gives more control over the output, such as including the task ID.
| | | | | | | | * Scheduler: only send warning in callback if task isn't cancelledGravatar MarkKoz2020-02-25-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a task is cancelled it is assumed it was done via cancel_task. That method deletes the task after cancelling so the warning isn't relevant.
| | | | | | | | * Scheduler: properly raise task's exception the done callbackGravatar MarkKoz2020-02-25-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Task.exception() only returns the exception. It still needs to be explicitly raised.
| | | | | | | | * Scheduler: only delete the task in the done callback if tasks are sameGravatar MarkKoz2020-02-25-16/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To prevent a deletion of task rescheduled with the same ID, the callback checks that the stored task is the same as the done task being handled. * Only delete the task; it doesn't need to be cancelled because the it is already done * Revise the callback's docstring to explain the new behaviour * Rename `task` parameter to `done_task`
| | | | | | | | * Scheduler: improve cancel_task's docstringGravatar MarkKoz2020-02-25-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use imperative mood for docstring * Explain the purpose of the parameter in the docstring * Make log message after cog name lowercase
| | | | | | | | * Moderation: use asyncio.shield to prevent self-cancellationGravatar MarkKoz2020-02-25-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The shield exists to be used for exactly this purpose so its a better fit than create_task.
| | | | | | | | * Merge remote-tracking branch 'origin/master' into ↵Gravatar MarkKoz2020-02-25-1158/+2658
| | | | | | | | |\ | |_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | bug/backend/b754/scheduler-suppresses-errors
* | | | | | | | | Merge pull request #781 from ↵Gravatar S. Co12020-02-25-6/+11
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | python-discord/bug/utils/bot-1c/reminder-unschedule-failure Reminders: don't cancel task if reminder is invalid when rescheduling
| * | | | | | | | Merge branch 'master' into bug/utils/bot-1c/reminder-unschedule-failureGravatar Joseph2020-02-25-551/+1704
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #711 from python-discord/bug/backend/b704/ready-missing-cacheGravatar Mark2020-02-23-536/+1657
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | Prevent the role syncer from wiping the database table during API latency
| * | | | | | | | Merge remote-tracking branch 'origin/master' into ↵Gravatar MarkKoz2020-02-23-621/+997
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | bug/backend/b704/ready-missing-cache
* | | | | | | | | Merge pull request #749 from python-discord/reminder-enhancementsGravatar Leon Sandøy2020-02-23-15/+47
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | Reminder Embed Enhancements & Whitelist Expansion
| * | | | | | | | Merge branch 'master' into reminder-enhancementsGravatar S. Co12020-02-23-607/+951
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
| * | | | | | | | Add missed signature reformat from reviewGravatar S. Co12020-02-15-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Co-Authored-By: Mark <[email protected]>
| * | | | | | | | Add "cancel" as a reminder delete aliasGravatar S. Co12020-02-15-1/+1
| | | | | | | | |
| * | | | | | | | Add full capture of reason string to superstarify invocationGravatar S. Co12020-02-15-1/+2
| | | | | | | | |
| * | | | | | | | Styling & refactors from reviewGravatar S. Co12020-02-15-17/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Refactor confirmation embed footer string generation to be more concise * Multiline long method calls * Refactor humanized delta f string generation for readability * Switch from `datetime.isoformat` to `dateutils.parser.isoparse` to align with changes elsewhere in the codebase (should be more robust) * Shift reminder channel whitelist to constants Co-Authored-By: Mark <[email protected]>
| * | | | | | | | Expand reminder channel whitelist to dev-contrib for non-staffGravatar S. Co12020-02-12-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add channel ID to config files
| * | | | | | | | Add reminder target datetime to footer of confirmation messageGravatar S. Co12020-02-12-5/+16
| | | | | | | | |
| * | | | | | | | Add reminder ID to footer of confirmation messageGravatar S. Co12020-02-12-5/+8
| | | | | | | | |
| | * | | | | | | Sync: code style refactoringGravatar MarkKoz2020-02-23-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Convert diff namedtuple to dict outside the dict comprehension * Define long condition as a boolean instead of in the if statement * Pass role and user dicts to aiohttp normally instead of unpacking
| | * | | | | | | Bot: send empty cache warning to a webhookGravatar MarkKoz2020-02-21-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is more visible than it would be if it was only logged. * Add a webhook for the dev-log channel to constants
| | * | | | | | | API: add comment explaining class attributesGravatar MarkKoz2020-02-19-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explain changes caused by 22a55534ef13990815a6f69d361e2a12693075d5.
| | * | | | | | | Sync: add confirmation timeout and max diff to configGravatar MarkKoz2020-02-19-16/+24
| | | | | | | | |
| | * | | | | | | Tests: fix unawaited error for MockAPIClientGravatar MarkKoz2020-02-12-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This error is due to the use of an actual instance of APIClient as the spec for the mock. recreate() is called in __init__ which in turn creates a task for the _create_session coroutine. The approach to the solution is to use the type for the spec rather than and instance, thus avoiding any call of __init__. However, without an instance, instance attributes will not be included in the spec. Therefore, they are defined as class attributes on the actual APIClient class definition and given default values. Alternatively, a subclass of APIClient could have been made in the tests.helpers module to define those class attributes. However, it seems easier to maintain if the attributes are in the original class definition.
| | * | | | | | | Sync tests: use async_test decoratorGravatar MarkKoz2020-02-12-94/+135
| | | | | | | | |
| | * | | | | | | Sync tests: test on_member_joinGravatar MarkKoz2020-02-12-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Should PUT user's data or POST it if the user doesn't exist. ResponseCodeError should be re-raised if status code isn't a 404. A helper method was added to reduce code redundancy between the 2 tests.
| | * | | | | | | Sync tests: add a third role with a lower ID to on_member_update testGravatar MarkKoz2020-02-12-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This better ensures that roles are being sorted when patching.
| | * | | | | | | Sync tests: fix on_member_remove listener testGravatar MarkKoz2020-02-12-13/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The listener was changed earlier to simply set in_guild to False. This commit accounts for that in the test.
| | * | | | | | | Sync tests: assert that listeners are actually added as listenersGravatar MarkKoz2020-02-12-0/+14
| | | | | | | | |
| | * | | | | | | Sync tests: test sync commands require the admin permissionGravatar MarkKoz2020-02-12-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sync commands should only run if the author has the administrator permission. * Add missing spaces after class docstrings * Add missing docstring to SyncCogCommandTests
| | * | | | | | | Tests: create TestCase subclass with a permissions check assertionGravatar MarkKoz2020-02-12-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The subclass will contain assertions that are useful for testing Discord commands. The currently included assertion tests that a command will raise a MissingPermissions exception if the author lacks permissions.
| | * | | | | | | Sync: only update in_guild field when a member leavesGravatar MarkKoz2020-02-12-16/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The member and user update listeners should already be detecting and updating other fields so by the time a user leaves, the rest of the fields should be up-to-date. * Dedent condition which was indented too far
| | * | | | | | | Sync tests: test sync users commandGravatar MarkKoz2020-02-12-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sync() should be called on the UserSyncer.
| | * | | | | | | Sync tests: test sync roles commandGravatar MarkKoz2020-02-12-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sync() should be called on the RoleSyncer.
| | * | | | | | | Sync tests: test Sync cog's on_user_updateGravatar MarkKoz2020-02-12-1/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A user should be patched only if the name, discriminator, or avatar changes.
| | * | | | | | | Sync tests: fix ID in endpoint for test_sync_cog_on_member_removeGravatar MarkKoz2020-02-12-1/+1
| | | | | | | | |
| | * | | | | | | Sync tests: test Sync cog's on_member_update for other attributesGravatar MarkKoz2020-02-12-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Members should not be patched if other attributes have changed.
| | * | | | | | | Sync tests: test Sync cog's on_member_update for rolesGravatar MarkKoz2020-02-12-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Members should be patched if their roles have changed.
| | * | | | | | | Sync tests: test Sync cog's on_member_removeGravatar MarkKoz2020-02-12-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A PUT request should be sent to set in_guild as False and update other fields.
| | * | | | | | | Sync tests: test Sync cog's on_guild_role_updateGravatar MarkKoz2020-02-12-0/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A PUT request should be sent if the colour, name, permissions, or position changes.
| | * | | | | | | Sync tests: remove mock_role fixtureGravatar MarkKoz2020-02-12-19/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is obsolete because MockRole now takes care of creating the Colour and Permissions objects.
| | * | | | | | | Tests: use objects for colour and permissions of MockRoleGravatar MarkKoz2020-02-12-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instances of discord.Colour and discord.Permissions will be created by default or when ints are given as values for those attributes.
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-28 11:51:36 +0000