aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | * | | | | | | | | Few changes to keep formatting same as currentGravatar mathsman51332019-10-13-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Change `add_field` back to `description` for error message possible matches - Only add `Commands` and `Subcommands` if subcommands exist to cog/group/command help
| | * | | | | | | | | Add a special case for when the help command invokes wolfram checks.Gravatar mathsman51332019-10-13-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Before, running `!help` would invoke the cooldown check, and increase the cooldown counter unnecessarily as no wolfram API calls were being made. - Once `!help` was called enough, the bot would send an error embed to let you know your wolfram cooldown has expired.
| | * | | | | | | | | Minor formatting changes to align with current help.Gravatar mathsman51332019-10-12-2/+2
| | | | | | | | | | |
| | * | | | | | | | | Refactor the `Help` command.Gravatar mathsman51332019-10-12-475/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - `redirect_output` has been adjusted to run the `delete_invocation` inside a task as the help command will wait for that to run before sending the help or doing anything else. - `pagination` has been adjusted to support deleting the paginated message if `cleanup` is True, and an optional `description` that is present through all pages of pagination. - The help command has been refactored to subclass `commands.HelpCommand`. This means that it now supports methods such as `ctx.send_help(ctx.command)`. - `help_cleanup` provides the opportunity to use the :x: reaction to cleanup help even with no pagination. - Pagination purely happens through the `LinePaginator`, forcing a pagination session with 1 line per page where we format the page style before sending it through. - Categories are properly dealt with by finding a match and sending a seperate help where a named tuple of the Category name, description and relevant cogs is the only parameter. - Choices for when a command was not found has been updated to include category names, cog names, aliases of group and command names, and include all subcommands and aliases. This should provide a more helpful output when an error message is sent - Sending command, group, cog, category and bot help has been split into different functions that are called from `command_callback`. This provides an easier way to alter future changes, and cleans up code considerably. - Important note: no outward facing formatting should have changed. Any desired changes can be discussed in review.
* | | | | | | | | | | Fix linting errors introduced by flake8 3.8Gravatar Leon Sandøy2020-05-17-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turns out that bumping the flake8 version up to 3.8 introduces a long list of new linting errors. Since this PR is the one that bumps the version, I suppose we will also fix all the linting errors in this branch.
* | | | | | | | | | | Merge branch 'master' into redis_persistenceGravatar Leon Sandøy2020-05-17-1/+1
|\| | | | | | | | | |
| * | | | | | | | | | Merge pull request #946 from vivax3794/masterGravatar Leon Sandøy2020-05-17-1/+1
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|/ / / / / | |/| | | | | | | | | add "solved" as a alias for "closed"
| | * | | | | | | | | added "solved" as a alias for "closed"Gravatar vivax37942020-05-17-1/+1
| |/ / / / / / / / /
* | | | | | | | | | namespace "general" -> "global"Gravatar Leon Sandøy2020-05-17-1/+1
| | | | | | | | | |
* | | | | | | | | | Make redis host and port configurable.Gravatar Leon Sandøy2020-05-17-1/+11
| | | | | | | | | |
* | | | | | | | | | Test suite for the redis dict.Gravatar Leon Sandøy2020-05-17-0/+189
| | | | | | | | | |
* | | | | | | | | | Implement .pop, .popitem and .setdefault.Gravatar Leon Sandøy2020-05-17-2/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turns out the MutableMapping class doesn't give us servicable implementations of these, so we need to implement them ourselves. Also, let's not have keys returned as bytestrings.
* | | | | | | | | | Add fakeredis to the PipfileGravatar Leon Sandøy2020-05-17-3/+27
| | | | | | | | | |
* | | | | | | | | | Implement .get, equality, and membership checkGravatar Leon Sandøy2020-05-17-2/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is supposed to be provided by our MutableMapping mixin, but unit tests are demonstrating that these don't really work as intended.
* | | | | | | | | | Implements .clear with hash deletion.Gravatar Leon Sandøy2020-05-17-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This would've been implemented by MutableMapping, but that implementation is O(n) instead of O(1) since it just iterates the entire hash and does HDEL. Feels wasteful.
* | | | | | | | | | copy should dictify the .items(), not just keys.Gravatar Leon Sandøy2020-05-16-1/+1
| | | | | | | | | |
* | | | | | | | | | Add basic dict methods for RedisDict.Gravatar Leon Sandøy2020-05-16-35/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rest of the features should be provided by the MutableMapping abc we're interfacing. Specifically, MutableMapping provides these: .pop, .popitem, .clear, .update, .setdefault, __contains__, .keys, .items, .values, .get, __eq__, and __ne__.
* | | | | | | | | | Refactor - no more mixins!Gravatar Leon Sandøy2020-05-16-59/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was brought to my attention that we may need several caches per Cog for some of our Cogs. This means that the original approach of having this be a mixin is a little bit problematic. Instead, RedisDict will be instantiated directly inside the class you want it in. By leveraging __set_name__, we can create a namespace containing both the class name and the variable name without the user having to provide anything. For example, if you create an attribute MyClass.cache = RedisDict(), this will be using the redis namespace 'MyClass.cache.' before anything you store in it. With this approach, it is also possible to instantiate a RedisDict with a custom namespace by simply passing it into the constructor. - RedisDict("firedog") will create items with the 'firedog.your_item' prefix. - If there are multiple RedisDicts using the same namespace, an underscore will be appended to the namespace, such that the second RedisDict("firedog") will actually create items in the 'firedog_.your_item' namespace. This is also possible to use outside of classes, so long as you provide a custom namespace when you instantiate it. Custom namespaces will always take precedence over automatic 'Class.attribute_name' ones.
* | | | | | | | | | Boilerplate for the RedisCacheMixinGravatar Leon Sandøy2020-05-16-0/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're using __init_subclass__ to initialize our RedisDict with the subclass name as a namespace. This will be prefixed to all data that we store, so that there won't be collisions between different subclasses.
* | | | | | | | | | Adding redis-py to the PipfileGravatar Leon Sandøy2020-05-16-65/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the module we will be using to interface with Redis.
* | | | | | | | | | Adding redis to docker-compose file.Gravatar Leon Sandøy2020-05-16-0/+4
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is almost hilariously easy since we can just use the official image for it.
* | | | | | | | | Remove @Admins ping from the #verification messageGravatar Leon Sandøy2020-05-14-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This probably isn't necessary anymore. We get so many new users that someone is going to DM us very soon when something breaks. We've outgrown this, and it just adds noise to the #verification channel in the form of pings.
* | | | | | | | | Remove everyone-ping from mentions alertGravatar Sebastiaan Zeeff2020-05-14-1/+0
| |_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | The mentions alert that is sent out by the Verification cog currently pings `@everyone` despite being quite unactionable by most people receiving the ping. As it happens frequently, especially with the recent uptick in joins, I'm removing that ping to not bother our moderators as much.
* | | | | | | | Merge pull request #899 from ks129/python-newsGravatar Sebastiaan Zeeff2020-05-13-55/+321
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Python News implemention
| * \ \ \ \ \ \ \ Merge branch 'master' into python-newsGravatar Sebastiaan Zeeff2020-05-13-219/+522
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Expand guild whitelistGravatar S. Co12020-05-12-1/+7
| | | | | | | | |
* | | | | | | | | Merge pull request #924 from ↵Gravatar Daniel Brown2020-05-11-20/+58
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | python-discord/feature/hemlock/perma-ban-override-temp Perma Bans now Overwrite Temp Bans
| * \ \ \ \ \ \ \ \ Merge branch 'master' into feature/hemlock/perma-ban-override-tempGravatar Daniel Brown2020-05-11-58/+34
| |\ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | |
* | | | | | | | | | Merge pull request #938 from Suhail6inkling/remind_aliasGravatar Leon Sandøy2020-05-11-1/+1
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ |/| | | | | | | | | Add remindme alias for the remind command
| * | | | | | | | | Add remindme alias for the remind commandGravatar Suhail2020-05-10-1/+1
|/ / / / / / / / /
* | | | | | | | | Merge pull request #923 from python-discord/feat/util/remove-mention-cmdGravatar Daniel Brown2020-05-08-56/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Remove the mention command and configuration settings for it
| * \ \ \ \ \ \ \ \ Merge branch 'master' into feat/util/remove-mention-cmdGravatar Daniel Brown2020-05-08-1/+31
| |\ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | |
* | | | | | | | | | Merge pull request #903 from python-discord/bug/backend/894/win-selector-loopGravatar Daniel Brown2020-05-07-1/+7
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Use selector event loop on Windows
| * \ \ \ \ \ \ \ \ \ Merge branch 'master' into bug/backend/894/win-selector-loopGravatar Daniel Brown2020-05-07-136/+405
| |\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / |/| | | | | | | | | |
* | | | | | | | | | | Merge pull request #919 from ↵Gravatar Sebastiaan Zeeff2020-05-05-0/+12
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | python-discord/bug/backend/911/log-listener-exceptions Log unhandled errors from event listeners
| * \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into bug/backend/911/log-listener-exceptionsGravatar Sebastiaan Zeeff2020-05-05-3/+16
| |\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #925 from Savant-Dev/antimalwareGravatar Daniel Brown2020-05-05-0/+12
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Update to Antimalware Filter (.txt uploads)
| * \ \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into antimalwareGravatar Daniel Brown2020-05-05-2/+2
| |\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | |
| * | | | | | | | | | | | Update antimalware to filter txt files in cases where messages were longer ↵Gravatar Savant-Dev2020-05-04-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | than 2000 chars
| * | | | | | | | | | | | Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev2020-05-01-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | longer than 2000 characters
| * | | | | | | | | | | | Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev2020-05-01-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | longer than 2000 characters
| | * | | | | | | | | | | Log unhandled errors from event listenersGravatar MarkKoz2020-04-29-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, discord.py prints them to stderr. To better help detect such errors in production, they should instead be logged with an appropriate log level. Some sentry metadata has also been included. `on_error` doesn't work as a listener in a cog so it's been put in the Bot subclass. Fixes #911
| | | * | | | | | | | | | Fix awaiting non-coroutine when closing the statsd transportGravatar MarkKoz2020-04-24-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `BaseTransport.close()` is not a coroutine and therefore should not be awaited.
| | | * | | | | | | | | | Use selector event loop on WindowsGravatar MarkKoz2020-04-22-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | aiodns requires the selector event loop for asyncio. In Python 3.8, the default event loop for Windows was changed to proactor. To fix this, the event loop is explicitly set to selector.
| | | | * | | | | | | | | Remove mention command constantsGravatar MarkKoz2020-05-02-10/+0
| | | | | | | | | | | | |
| | | | * | | | | | | | | Remove the mention commandGravatar MarkKoz2020-05-01-46/+2
| |_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was made obsolete by a new Discord feature. Users can be granted a permission to mention a role despite the role being set as non-mentionable.
| | | | * | | | | | | | Restructure `apply_ban()` logic Gravatar Daniel Brown2020-05-11-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Another refactor/cleaning to make the logic clearer and easier to understand. Also cleaned up the trace logs to be shorter and more concise. Thanks, @scragly! Co-authored-by: scragly <[email protected]>
| | | | * | | | | | | | apply_ban() logic refinedGravatar Daniel Brown2020-05-07-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Refined the logic for `apply_ban()` even further to be cleaner. (Thanks, @MarkKoz!) Signed-off-by: Daniel Brown <[email protected]>
| | | | * | | | | | | | Addressing Review ChangesGravatar Daniel Brown2020-05-07-25/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Changed docstring explanation and function name of `get_active_infractions` to `get_active_infraction()` to better convey that only one infraction is returned. Also changed all relevant uses to reflect that change. - Added explanation of parameter `send_msg` to the doc strings of `pardon_infraction()` and `get_active_infraction()` - Adjusted placement of `log.trace()` in `pardon_infraction()` - Adjusted logic in `apply_ban()` to remove redundant check. - Adjusted logic in `apply_ban()` to be consistent with other checks. Signed-off-by: Daniel Brown <[email protected]>
| | | | * | | | | | | | Merge branch 'master' into feature/hemlock/perma-ban-override-tempGravatar Daniel Brown2020-05-04-2/+2
| | | | |\ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / / / |/| | | | | | | | | | |