aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Adjust attachments rule unit test to correcty build the arguments for the ↵Gravatar kwzrd2019-11-14-7/+11
| | | | tested rule
* Fix bug in attachments rule where last_message could potentially count twice ↵Gravatar kwzrd2019-11-14-2/+2
| | | | in the sum of attachments
* Use async_test helper to simplify coro testingGravatar kwzrd2019-11-13-9/+14
|
* Adjust attachments rule to use MockMessage, restructure test casesGravatar kwzrd2019-11-13-20/+23
|
* Adjust links rule to use proper MockMessageGravatar kwzrd2019-11-13-14/+10
|
* Merge branch 'master' into unittest-mentionsGravatar kwzrd2019-11-13-179/+187
|\ | | | | | | Testing methodology was adjusted in upstream repo. Merging the relevant changes.
| * Enhancements for `tests.helpers` and our test suite (#660)Gravatar scragly2019-11-14-157/+134
| |\ | | | | | | | | | | | | Enhancements for `tests.helpers` and our test suite Co-authored-by: null <[email protected]>
| | * Merge branch 'master' into unittest-helpers-improvementsGravatar scragly2019-11-14-36/+167
| | |\ | | |/ | |/|
| * | Merge pull request #656 from python-discord/checkpoint-changesGravatar Mark2019-11-10-22/+53
| |\ \ | | | | | | | | Forward pings in checkpoint to mod-alerts and reword periodic checkpoint ping
| | * \ Merge branch 'master' into checkpoint-changesGravatar Mark2019-11-10-540/+677
| | |\ \ | | |/ / | |/| |
| | * | [kaizen] Remove now duplicate channel checkGravatar Derek2019-11-09-19/+18
| | | | | | | | | | | | | | | | Unindent subsequent lines after check
| | * | Forward user/role pings in checkpoint to mod-alertsGravatar Derek2019-11-09-2/+34
| | | | | | | | | | | | | | | | [kaizen] limit on_message listener to verification channel
| | * | Reword periodic #checkpoint messageGravatar Derek2019-11-04-1/+1
| | | |
| | | * Prevent await warnings for MockBot's create_taskGravatar Sebastiaan Zeeff2019-11-13-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the coroutine object passed to `MockBot.loop.create_task` would trigger a `RuntimeWarning` for not being awaited as we do not actually create a task for it. To prevent these warnings, coroutine objects passed will now automatically be closed.
| | | * Prevent setting unknown attributes on d.py mocksGravatar Sebastiaan Zeeff2019-11-13-158/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our custom `discord.py` now follow the specifications of the object they are mocking more strictly by using the `spec_set` instead of the `spec` kwarg to initialize the specifications. This means that trying to set an attribute that does not follow the specifications will now also result in an `AttributeError`. To make sure we are not trying to set illegal attributes during the default initialization of the mock objects, I've changed the way we handle default values of parameters. This does introduce a breaking change: Instead of passing a `suffix_id`, the `id` attribute should now be passed using the exact name. `id`. This commit also makes sure existing tests follow this change.
| | | * Allow `name` attribute to be set during Mock initGravatar Sebastiaan Zeeff2019-11-13-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `name` keyword argument has a special meaning for the default mockobjects provided by `unittest.mock`. This means that by default, the common d.py `name` attribute can't be set during initalization of one of our custom Mock-objects by passing it to the constructor. Since it's unlikely for us to make use of the special `name` feature of mocks and more likely to want to set the d.py `name` attribute, I added special handling of the `name` kwarg.
| | | * Prevent unwanted logging while running testsGravatar Sebastiaan Zeeff2019-11-13-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, logging messages would output to std.out. when running individual test files (instead of running the entire suite). To prevent this, I've added a `for`-loop to `tests.helpers` that sets the level of all registered loggers to `CRITICAL`. The reason for adding this to `tests.helpers` is simple: It's the most common file to be imported in individual tests, increasing the chance of the code being run for individual test files. A small downside of this way of handling logging is that when we are trying to assert logging messages are being emitted, we need to set the logger explicitly in the `self.assertLogs` context manager. This is a small downside, though, and probably good practice anyway. There was one test in `tests.bot.test_api` that did not do this, so I have changed this to make the test compatible with the new set-up.
* | | | Adjust incorrect type hintGravatar kwzrd2019-11-09-1/+1
| | | |
* | | | Use MockMessage instead of custom FakeMessageGravatar kwzrd2019-11-09-15/+11
| | | |
* | | | Adjust type hint to correctly represent internal typeGravatar kwzrd2019-11-09-1/+1
| | | |
* | | | Use range to build mock mentions listGravatar kwzrd2019-11-09-1/+1
| | | |
* | | | Adjust docstring asterisk to backtick for consistencyGravatar kwzrd2019-11-09-1/+1
| | | |
* | | | Add missing docstringGravatar kwzrd2019-11-09-0/+1
| | | |
* | | | Add unit test for mentions antispam ruleGravatar kwzrd2019-11-09-0/+98
|/ / /
* | | Merge pull request #641 from kwzrd/unittest-linksGravatar Mark2019-11-08-0/+101
|\ \ \ | | | | | | | | Add unit test for links antispam rule
| * \ \ Merge branch 'master' into unittest-linksGravatar Mark2019-11-08-608/+1193
| |\ \ \ | |/ / / |/| | |
* | | | Merge pull request #653 from python-discord/talent-poolingGravatar Sebastiaan Zeeff2019-11-08-14/+13
|\ \ \ \ | |_|_|/ |/| | | Allow helpers to nominate people
| * | | Refactor bigbrother to use constantsGravatar kosayoda2019-11-08-5/+5
| | | |
| * | | Allow helpers to nominate peopleGravatar kosayoda2019-11-08-9/+8
|/ / /
* | | Merge pull request #618 from python-discord/schedule-superstarifyGravatar S. Co12019-11-04-526/+563
|\ \ \ | |_|/ |/| | Schedule superstarify infractions for expiration
| * | Merge branch 'master' into schedule-superstarifyGravatar S. Co12019-11-04-260/+838
| |\ \ | |/ / |/| |
* | | User command enhancements (#637)Gravatar scragly2019-11-04-62/+552
|\ \ \ | | | | | | | | | | | | | | | | User command enhancements Co-authored-by: null <[email protected]>
| * \ \ Merge branch 'master' into user-command-enhancementsGravatar scragly2019-11-04-7/+66
| |\ \ \ | |/ / / |/| | |
* | | | Change invite filter message to accurately reflect the new rulesGravatar kosayoda2019-11-04-1/+1
| | | |
* | | | Merge pull request #648 from python-discord/user-status-summaryGravatar Mark2019-11-03-1/+9
|\ \ \ \ | | | | | | | | | | Show custom statuses in !user output
| * \ \ \ Merge branch 'master' into user-status-summaryGravatar Mark2019-11-03-3/+53
| |\ \ \ \ | |/ / / / |/| | | |
* | | | | Merge pull request #640 from python-discord/bot-utils-init-testsGravatar S. Co12019-11-03-0/+52
|\ \ \ \ \ | | | | | | | | | | | | Write tests for `bot.utils`.
| * \ \ \ \ Merge branch 'master' into bot-utils-init-testsGravatar S. Co12019-11-03-5/+4
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #631 from manusaurio/masterGravatar S. Co12019-11-03-3/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove redirection on rules command
| * \ \ \ \ \ Merge branch 'master' into masterGravatar S. Co12019-11-03-194/+224
| |\ \ \ \ \ \ | |/ / / / / / |/| | | | | |
| * | | | | | Remove redirection on rules commandGravatar Manuel Ignacio Pérez Alcolea2019-10-28-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously restricted for the staff. This change was suggested due its possible usefulness for regular users.
| | * | | | | Use `casefold` in some cases.Gravatar Johannes Christ2019-11-02-1/+4
| | | | | | |
| | * | | | | Write tests for `bot.utils`.Gravatar Johannes Christ2019-11-01-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #604.
| | | * | | | Show custom statuses in !user outputGravatar Jeremiah Boby2019-11-03-1/+9
| |_|/ / / / |/| | | | | | | | | | | | | | | | | Resolves #647
* | | | | | Merge pull request #638 from loksonarius/fix-reddit-cog-sleepGravatar Mark2019-11-02-2/+3
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Use timedelta to correctly calculate next midnight
| * | | | | Use timedelta to correctly calculate next midnightGravatar Dan Herrera2019-10-31-2/+3
|/ / / / /
| | * / / Enhance the output of the user commandGravatar Sebastiaan Zeeff2019-10-31-62/+552
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/python-discord/bot/issues/628 https://github.com/python-discord/bot/issues/339 This commit introduces several changes to the output of the `!user` command for moderation staff. The output for regular users has not changed. Changes: - When issued in a moderation channel, the infraction count of the user will now be broken down by type as described in #339. This allows moderators to get a quicker overview of someone's history by providing more information. The command will display the total number of infractions per type, with the number of active infractions in parentheses behind it if there are any. This change also means that there no longer a need for the `hidden` parameter: When issued in a moderation channel, hidden infractions are included by default; when issued outside of a mod channel, the command will be equal to what a regular user would get. In addition to broken-down infraction info, the command now also shows information about the nominations of a user when it's issued inside of a moderation channel. - The code has been refactored to smaller units that take care of a single action to make unit testing easier. I have included tests that cover the command and all of the new helper methods. Tests for the other methods/commands in the cog will be added in the specific issue calling for tests for this cog (#581) This commit closes #628 and closes #339
| | * | Superstarify: return None in _pardon_action for supported typesGravatar MarkKoz2019-10-25-1/+4
| | | |
| | * | Moderation: make infraction notification embed title lowercaseGravatar MarkKoz2019-10-25-1/+1
| | | |
| | * | Moderation: remove full stops from pardon embed titlesGravatar MarkKoz2019-10-25-2/+2
| | | |