bot - A mirrored copy of the python-discord/bot repository.

	Commit message (Collapse)	Author	Age	Lines
...
\| \| \| \| \| \| * \| \|	Rename Bot._redis_ready to Bot.redis_ready	Leon Sandøy	2020-05-24	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's a public attribute, we're accessing it from RedisCache.
\| \| \| \| \| \| * \| \|	Add .increment and .decrement methods.	Leon Sandøy	2020-05-24	-0/+69
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Sometimes, we just want to store a counter in the cache. In this case, it is convenient to have a single method that will allow us to increment or decrement this counter. These methods allow you to decrement or increment floats and integers by an specified amount. By default, it'll increment or decrement by 1. Since this involves several API requests, we create an asyncio.Lock so that we don't end up with race conditions.
\| \| \| \| \| \| * \| \|	Make .items return ItemsView instead of AsyncIter	Leon Sandøy	2020-05-24	-9/+23
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	There really was no compelling reason why this method should return an AsyncIterator or than that `async for items in cache.items()` has nice readability, but there were a few concerns. One is a concern about race conditions raised by @SebastiaanZ, and @MarkKoz raised a concern that it was misleading to have an AsyncIterator that only "pretended" to be lazy. To address these concerns, I've refactored it to return a regular ItemsView instead. I also improved the docstring, and fixed the relevant tests.
\| \| \| \| \| \| * \| \|	Better RuntimeErrors.	Leon Sandøy	2020-05-24	-2/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We provide suggestions for how to solve these problems now.
\| \| \| \| \| \| * \| \|	Improves various docstrings and comments.	Leon Sandøy	2020-05-24	-10/+27
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Thanks to @MarkKoz for suggesting most of these in their code review.
\| \| \| \| \| \| * \| \|	Refactor the nice prefix/type strings to constants	Leon Sandøy	2020-05-24	-31/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's leaner to just move that code out of the class and up to the module level as constants. This commit also renames ValidRedisType to RedisType.
\| \| \| \| \| \| * \| \|	len(prefix) instead of hardcoding 2	Leon Sandøy	2020-05-24	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: Mark <[email protected]>
\| \| \| \| \| \| * \| \|	use __name__ for type list	Leon Sandøy	2020-05-24	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Instead of relying on __str__ representation, we'll use the __name__ dunder. Co-authored-by: Mark <[email protected]>
\| \| \| \| \| \| * \| \|	Merge branch 'master' into redis_persistence	Leon Sandøy	2020-05-23	-4/+6
\| \| \| \| \| \| \|\ \ \ \| \| \| \|_\|_\|_\|/ / / \| \| \|/\| \| \| \| \| \|
\| \| * \| \| \| \| \| \|	Merge pull request #934 from python-discord/bug/filters/933/dont-delete-in-dms	Dennis Pham	2020-05-23	-4/+6
\| \| \|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Filtering: don't delete messages in DMs
\| \| \| * \ \ \ \ \ \	Merge branch 'master' into bug/filters/933/dont-delete-in-dms	Dennis Pham	2020-05-23	-585/+786
\| \| \| \|\ \ \ \ \ \ \ \| \| \| \|/ / / / / / / \| \| \|/\| \| \| \| \| \| \|
\| \| \| * \| \| \| \| \| \|	Filtering: don't delete messages in DMs	MarkKoz	2020-05-09	-4/+6
\| \| \| \| \|/ / / / / \| \| \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Bots are incapable of deleting direct messages authored by others.
\| \| \| \| \| \| * \| \|	Show a warning when redis pool isn't closed	MarkKoz	2020-05-23	-0/+5
\| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| * \| \|	Remove redis session mock from MockBot	MarkKoz	2020-05-23	-16/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's not feasible to mock it because all the commands return futures rather than being coroutines, so they cannot automatically be turned into AsyncMocks. Furthermore, no code should ever use the redis session directly besides RedisCache. Since the tests for RedisCache already use fakeredis, there's no use in trying to mock redis in MockBot.
\| \| \| \| \| \| * \| \|	DRY approach to typestring prefix resolution	Leon Sandøy	2020-05-23	-15/+60
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Thanks to @kwzrd for this idea, basically we're making a constant with the typestring prefixes and iterating that in all our converters. These converter functions will also now raise TypeErrors if we try to convert something that isn't in this constants list. I've also added a new test that tests this functionality.
\| \| \| \| \| \| * \| \|	Don't rely on HDEL ignoring keys for .pop	Leon Sandøy	2020-05-23	-2/+21
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Previously we would try to .delete keys that did not exist if a default was provided when calling .pop. This is okay to do (because HDEL will just ignore any attempts to delete non-existing calls), but it does add an additional pointless API call to Redis, so I've added some validation as a small optimization. This also adds a few additional lines of documentation as requested by @SebastiaanZ in their review.
\| \| \| \| \| \| * \| \|	Fix typo in test_to_dict docstring	Leon Sandøy	2020-05-23	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| * \| \|	Update exception message	Leon Sandøy	2020-05-23	-1/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This was incorrectly suggesting the user needed to create an instance of RedisCache, when in fact it is the parent that needs to be instantiated. Co-authored-by: Sebastiaan Zeeff <[email protected]>
\| \| \| \| \| \| * \| \|	CI needs REDIS_PASSWORD to pass tests	Leon Sandøy	2020-05-23	-0/+1
\| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| * \| \|	Moving the Redis session creation to Bot._recreate	Leon Sandøy	2020-05-23	-2/+5
\| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| * \| \|	Unbreak the error_handler	Leon Sandøy	2020-05-23	-1/+1
\| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| * \| \|	Merge branch 'redis_persistence' of github.com:python-discord/bot into ↵	Leon Sandøy	2020-05-23	-44/+127
\| \| \| \| \| \| \|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	redis_persistence
\| \| \| \| \| \| \| * \ \	Merge branch 'master' into redis_persistence	Leon Sandøy	2020-05-23	-44/+127
\| \| \| \| \| \| \| \|\ \ \ \| \| \| \|_\|_\|_\|_\|/ / / \| \| \|/\| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \| \|	Merge pull request #945 from ks129/stats	Joseph Banks	2020-05-22	-1/+36
\| \| \|\ \ \ \ \ \ \ \
\| \| \| * \ \ \ \ \ \ \	Merge branch 'master' into stats	Joseph Banks	2020-05-22	-505/+362
\| \| \| \|\ \ \ \ \ \ \ \ \| \| \| \|/ / / / / / / / \| \| \|/\| \| \| \| \| \| \| \|
\| \| * \| \| \| \| \| \| \| \|	Merge pull request #942 from ks129/python-news-stats	Joseph Banks	2020-05-22	-0/+6
\| \| \|\ \ \ \ \ \ \ \ \
\| \| \| * \ \ \ \ \ \ \ \	Merge branch 'master' into python-news-stats	Mark	2020-05-20	-505/+356
\| \| \| \|\ \ \ \ \ \ \ \ \ \| \| \| \|/ / / / / / / / / \| \| \|/\| \| \| \| \| \| \| \| \|
\| \| \| * \| \| \| \| \| \| \| \|	Merge branch 'master' into python-news-stats	ks129	2020-05-14	-2/+1
\| \| \| \|\ \ \ \ \ \ \ \ \
\| \| \| * \| \| \| \| \| \| \| \| \|	Python News: Implement stats	ks129	2020-05-14	-0/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add stat increaser to PEP and maillist posting.
\| \| \| \| \| * \| \| \| \| \| \| \|	Eval Stats: Replaced `elif` with `else` on icon check	ks129	2020-05-22	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: Mark <[email protected]>
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Fix docstrings	ks129	2020-05-19	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: Joseph Banks <[email protected]>
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Fixed stat names	ks129	2020-05-19	-7/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Co-authored-by: Joseph Banks <[email protected]>
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Added stats for eval channel using (Help/Bot commands/Topical)	ks129	2020-05-16	-0/+7
\| \| \| \| \| \| \| \| \| \| \| \| \|
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Added stats for eval role uses (Helpers/Developers)	ks129	2020-05-16	-0/+5
\| \| \| \| \| \| \| \| \| \| \| \| \|
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Added stats for eval successes + fails	ks129	2020-05-16	-0/+6
\| \| \| \| \| \| \| \| \| \| \| \| \|
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Added codeblock correction stats	ks129	2020-05-16	-0/+2
\| \| \| \| \| \| \| \| \| \| \| \| \|
\| \| \| \| \| * \| \| \| \| \| \| \|	Stats: Create guild boost stat collection	ks129	2020-05-16	-1/+16
\| \| \| \| \|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Collect Guild boost amount + level and post it to StatsD every hour in task. Added starting to cog `__init__.py` and stopping to `cog_unload`.
\| \| \| \| \| \| \| \| * / / /	Better docstring for RedisCache.contains	Leon Sandøy	2020-05-23	-1/+5
\| \| \| \| \| \| \| \| \|/ / /
\| \| \| \| \| \| \| \| * \| \|	Better docstring for RedisCache	Leon Sandøy	2020-05-23	-1/+31
\| \| \| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| \| \| * \| \|	Complete asyncified test suite for RedisCache	Leon Sandøy	2020-05-23	-94/+112
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This commit just alters existing code to work with the new interface, and with async. All tests are passing successfully.
\| \| \| \| \| \| \| \| * \| \|	Finish asyncifying RedisCache methods	Leon Sandøy	2020-05-23	-16/+34
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	- All methods will now do a validation check - Complete interface spec added to class: - .update - .clear - .pop - .to_dict - .length - .contains - .delete - .get - .set
\| \| \| \| \| \| \| \| * \| \|	Finish .set and .get, and add tests.	Leon Sandøy	2020-05-23	-25/+85
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The .set and .get will accept ints, floats, and strings. These will be converted into "typestrings", which is basically just a simple format that's been invented for this object. For example, an int looks like `b"i\|2423"`. Note how it is still stored as a bytestring (like everything in Redis), but because of this prefix we are able to coerce it into the type we want on the way out of the db.
\| \| \| \| \| \| \| \| * \| \|	Use autospecced mocks in MockBot for the stats and aiohttp session	MarkKoz	2020-05-22	-0/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This will help catch anything that tries to get/set an attribute/method which doesn't exist. It'll also catch missing/too many parameters being passed to methods.
\| \| \| \| \| \| \| \| * \| \|	Properly mock the redis pool in MockBot	MarkKoz	2020-05-22	-9/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Because some of the redis pool/connection methods return futures rather than being coroutines, the redis pool had to be mocked using the CustomMockMixin so it could take advantage of `additional_spec_asyncs` to use AsyncMocks for these future-returning methods.
\| \| \| \| \| \| \| \| * \| \|	Fix unawaited coro warning when instantiating Bot for MockBot's spec	MarkKoz	2020-05-22	-10/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The fix is to mock the loop and pass it to the Bot. It will then set it as `self.loop` rather than trying to get an event loop from asyncio. The `create_task` patch has been moved to this loop mock rather than being done in MockBot to ensure that it applies to anything calling it when instantiating the Bot.
\| \| \| \| \| \| \| \| * \| \|	Improve aiohttp context manager mocking in snekbox tests	MarkKoz	2020-05-22	-3/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	I'm not sure how it even managed to work before. It was calling the `post` coroutine (without specifying a URL) and then changing `__aenter__`. Now, a separate mock is created for the context manager and the `post` simply returns that mocked context manager.
\| \| \| \| \| \| \| \| * \| \|	Fix assertion for `create_task` in duck pond tests	MarkKoz	2020-05-22	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The assertion wasn't using the assertion method. Furthermore, it was testing a non-existent function `create_loop` rather than `create_task`.
\| \| \| \| \| \| \| \| * \| \|	Set up async testbed	Leon Sandøy	2020-05-22	-198/+135
\| \| \| \| \| \| \| \| \| \| \|
\| \| \| \| \| \| \| \| * \| \|	Opens a Redis connection in the Bot class.	Leon Sandøy	2020-05-22	-3/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This global connection is the one we will be using in RedisCache to power all our commands. This also ensures that connection is closed when the bot starts its shutdown process.
\| \| \| \| \| \| \| \| * \| \|	Replace redis-py with aioredis.	Leon Sandøy	2020-05-22	-60/+104
\| \| \| \| \| \| \| \| \| \| \|