aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Use clean help channel name for used name setGravatar Sebastiaan Zeeff2020-04-06-1/+1
| | | | The set that keeps track of the used channel names should discard emojis. To do that, I'm cleaning the names before they're added to the set of channel names.
* Use configurable prefix to clean help channel namesGravatar Sebastiaan Zeeff2020-04-06-3/+4
| | | | The help channel prefix is configurable as a constant, but I accidentally used a static prefix in the utility function that cleaned the channel names. This commit makes sure the utility method uses the prefix defined in the constants.
* Change bottom sorting strategy to using a large intGravatar Sebastiaan Zeeff2020-04-06-21/+2
| | | | | | The current approach of trying to find the maximum channel position, adding one, and using that as the position integer for channels does not seem to work reliably. An approach that seems to work in the testing environment is using a very large integer for the position attribute of the channel: It wil be sorted at the bottom and Discord will automatically scale the integer down to `max + 1`. This also means the `get_position` utility function is no longer needed; it has been removed.
* Add channel status emoji to help channelsGravatar Sebastiaan Zeeff2020-04-06-0/+22
| | | | | | I've added channel status emojis as a prefix to our help channels to make it more obvious to the end user what the current status of a channel is. All channels in the Available category will be marked with a green checkmark emoji, while all channels in the In Use category will be marked with an hourglass. Channels in the Dormant category stay unadorned. Channels will be stripped of their previous prefix when moved to another category. This relies on the `help-` naming convention, as that is the most reliable way to do it that does not break if we ever opt for another emoji.
* Change help channel sorting to bottom positionGravatar Sebastiaan Zeeff2020-04-05-17/+6
| | | | The current sorting algorithm we used created unpredictable channel order (for our human end-users) and induced a flickering channel light-show in Discord clients. To combat these undesirable side-effects, I've changed the ordering to always order channels at the bottom of a category. This also means that channels looking for answers the longest will naturally float up.
* Merge pull request #786 from python-discord/feat/frontend/o200/help-channelsGravatar Joseph2020-04-05-145/+887
|\ | | | | Implement a new help channel system
| * Merge branch 'master' into feat/frontend/o200/help-channelsGravatar Joseph2020-04-05-316/+906
| |\ | |/ |/|
* | Merge pull request #813 from python-discord/feat/ci/b000/cache-pipenvGravatar Mark2020-04-02-10/+29
|\ \ | | | | | | Cache all Python dependencies in CI
| * \ Merge branch 'master' into feat/ci/b000/cache-pipenvGravatar Mark2020-04-02-446/+2002
| |\ \ | |/ / |/| |
* | | Fixed missed rename for token removal method name changeGravatar S. Co12020-04-02-1/+1
| | |
* | | Merge pull request #832 from python-discord/fix-token-strip-logGravatar Shirayuki Nekomata2020-04-02-12/+18
|\ \ \ | | | | | | | | Update token filter logging to match expanded detection
| * \ \ Merge branch 'master' into fix-token-strip-logGravatar Shirayuki Nekomata2020-04-02-346/+982
| |\ \ \ | |/ / / |/| | |
* | | | Add TCD to whitelistGravatar Leon Sandøy2020-04-01-0/+1
| | | | | | | | | | | | | | | | The Coding Den is a language agnostic community that's been around for years with over 12000 members. I think we can allow that invite in our community.
* | | | Merge pull request #852 from ks129/infraction-editGravatar S. Co12020-03-31-1/+6
|\ \ \ \ | | | | | | | | | | Don't let change expiration time when infraction already expired.
| * \ \ \ Merge branch 'master' into infraction-editGravatar S. Co12020-03-31-60/+562
| |\ \ \ \ | |/ / / / |/| | | |
* | | | | Merge pull request #854 from ks129/tags-trashcan-reactGravatar S. Co12020-03-31-5/+17
|\ \ \ \ \ | | | | | | | | | | | | Tags response + command message deletion with trashcan reaction
| * \ \ \ \ Merge branch 'master' into tags-trashcan-reactGravatar S. Co12020-03-31-55/+545
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #846 from python-discord/feat/filter/322/merge-tokens-wordsGravatar S. Co12020-03-31-41/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | Filtering: merge the word and token watch filters
| * \ \ \ \ \ Merge branch 'master' into feat/filter/322/merge-tokens-wordsGravatar S. Co12020-03-31-15/+617
| |\ \ \ \ \ \ | |/ / / / / / |/| | | | | |
* | | | | | | Merge pull request #833 from ks129/zen-match-fixGravatar Sebastiaan Zeeff2020-03-31-1/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fixed !zen command exact word matching.
| * \ \ \ \ \ \ Merge branch 'master' into zen-match-fixGravatar Karlis S2020-03-31-14/+606
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
* | | | | | | | Merge pull request #845 from python-discord/update-logging-levelsGravatar Leon Sandøy2020-03-31-10/+9
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Logging Level Adjustments
| * \ \ \ \ \ \ \ Merge branch 'master' into update-logging-levelsGravatar Leon Sandøy2020-03-31-12/+656
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Set unsilence permissions to inherit instead of trueGravatar Sebastiaan Zeeff2020-03-30-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "unsilence" action of the silence/hush command used `send_messages=True` when unsilencing a hushed channel. This had the side effect of also enabling send messages permissions for those with the Muted rule, as an explicit True permission apparently overwrites an explicit False permission, even if the latter was set for a higher top-role. The solution is to revert back to the `Inherit` permission by assigning `None`. This is what we normally use when Developers are allowed to send messages to a channel.
* | | | | | | | | Merge pull request #812 from Numerlor/hush-cogGravatar Eivind Teig2020-03-30-3/+504
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Implement silencer (hush) cog.
| * \ \ \ \ \ \ \ \ Merge branch 'master' into hush-cogGravatar Eivind Teig2020-03-30-548/+1802
| |\ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | |
| * | | | | | | | | Add tests for `HushDurationConverter`.Gravatar Numerlor2020-03-17-0/+30
| | | | | | | | | |
| * | | | | | | | | Add tests ensuring permissions get preserved.Gravatar Numerlor2020-03-17-0/+31
| | | | | | | | | |
| * | | | | | | | | Use set `discard` instead of `remove`.Gravatar Numerlor2020-03-17-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Discard ignores non present values, allowing us to skip the KeyError suppress.
| * | | | | | | | | Add docstring to test.Gravatar Numerlor2020-03-17-0/+1
| | | | | | | | | |
| * | | | | | | | | Fix test name.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `removed` was describing the opposite behaviour.
| * | | | | | | | | Remove `alert_channel` mention from docstring.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After removing the optional channel arg and changing output message channels we're only testing `ctx`'s `send`.
| * | | | | | | | | Remove one indentation level.Gravatar Numerlor2020-03-17-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| * | | | | | | | | Reword `unsilence` docstring.Gravatar Numerlor2020-03-17-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| * | | | | | | | | Remove `channel` mentions from command docstrings.Gravatar Numerlor2020-03-17-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the new behaviour of not accepting channels and muting the current one, it's no longer neccessary to keep the channel param in the docstring. Co-authored-by: MarkKoz <[email protected]>
| * | | | | | | | | Rename `cog_unload` tests.Gravatar Numerlor2020-03-17-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous names were undescriptive from testing phases.
| * | | | | | | | | Fix `test_cog_unload` passing tests with invalid values.Gravatar Numerlor2020-03-17-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first assert - `asyncio_mock.create_task.assert_called_once_with` called `alert_channel`'s send resulting in an extra call. `send` on `alert_channel` was not tested properly because of a typo and a missing assert in the method call.
| * | | | | | | | | Handle and log `CommandErrors` on `.can_run`.Gravatar Numerlor2020-03-16-1/+6
| | | | | | | | | |
| * | | | | | | | | Remove long indentation from docstrings.Gravatar Numerlor2020-03-15-6/+6
| | | | | | | | | |
| * | | | | | | | | Set `_get_instance_vars_event` in test's `setUp`.Gravatar Numerlor2020-03-15-0/+2
| | | | | | | | | |
| * | | | | | | | | Adjust tests for new calling behaviour.Gravatar Numerlor2020-03-15-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `.set_permissions` calls were changed to use kwargs directly instead of an overwrite, this reflects the changes in tests.
| * | | | | | | | | Document returns values of private methods.Gravatar Numerlor2020-03-15-0/+2
| | | | | | | | | |
| * | | | | | | | | Block commands until all instance vars are loaded.Gravatar Numerlor2020-03-15-0/+4
| | | | | | | | | |
| * | | | | | | | | Assign created task to a var.Gravatar Numerlor2020-03-15-1/+1
| | | | | | | | | |
| * | | | | | | | | Pass kwargs directly instead of a PermissionOverwrite.Gravatar Numerlor2020-03-15-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `set_permissions` method creates a `PermissionOverwrite` from kwargs internally, so we can skip creating it ourselves and unpack the dict directly into kwargs.
| * | | | | | | | | Change BadArgument error wording.Gravatar Numerlor2020-03-15-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| * | | | | | | | | Add Silence cog load to docstring.Gravatar Numerlor2020-03-15-1/+1
| | | | | | | | | |
| * | | | | | | | | Move coro execution outside of if condition.Gravatar Numerlor2020-03-15-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives us a clearer look at the general flow control and what's getting executed. Comment was also moved to its relevant line. Co-authored-by: MarkKoz <[email protected]>
| * | | | | | | | | Adjust docstring styling.Gravatar Numerlor2020-03-15-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| * | | | | | | | | Use dict instead of a set and custom class.Gravatar Numerlor2020-03-15-44/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The FirstHash class is no longer necessary with only channels and the current loop in tuples. FirstHash was removed, along with its tests and tests were adjusted for new dict behaviour.