| Commit message (Collapse) | Author | Age | Lines |
|---|
| | |
|
| | |
|
| |
|
|
|
| |
This commit just alters existing code to work with the new interface,
and with async. All tests are passing successfully.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- All methods will now do a validation check
- Complete interface spec added to class:
- .update
- .clear
- .pop
- .to_dict
- .length
- .contains
- .delete
- .get
- .set
|
| |
|
|
|
|
|
|
|
|
| |
The .set and .get will accept ints, floats, and strings. These will be
converted into "typestrings", which is basically just a simple format
that's been invented for this object.
For example, an int looks like `b"i|2423"`. Note how it is still stored
as a bytestring (like everything in Redis), but because of this prefix
we are able to coerce it into the type we want on the way out of the db.
|
| |
|
|
|
|
| |
This will help catch anything that tries to get/set an attribute/method
which doesn't exist. It'll also catch missing/too many parameters being
passed to methods.
|
| |
|
|
|
|
|
| |
Because some of the redis pool/connection methods return futures rather
than being coroutines, the redis pool had to be mocked using the
CustomMockMixin so it could take advantage of `additional_spec_asyncs`
to use AsyncMocks for these future-returning methods.
|
| |
|
|
|
|
|
|
| |
The fix is to mock the loop and pass it to the Bot. It will then set
it as `self.loop` rather than trying to get an event loop from asyncio.
The `create_task` patch has been moved to this loop mock rather than
being done in MockBot to ensure that it applies to anything calling it
when instantiating the Bot.
|
| |
|
|
|
|
|
| |
I'm not sure how it even managed to work before. It was calling the
`post` coroutine (without specifying a URL) and then changing
`__aenter__`. Now, a separate mock is created for the context manager
and the `post` simply returns that mocked context manager.
|
| |
|
|
|
| |
The assertion wasn't using the assertion method. Furthermore, it was
testing a non-existent function `create_loop` rather than `create_task`.
|
| | |
|
| |
|
|
|
|
|
|
| |
This global connection is the one we will be using in RedisCache to
power all our commands.
This also ensures that connection is closed when the bot starts its
shutdown process.
|
| | |
|
| |
|
|
| |
In production, we will need this password to make a connection to Redis.
|
| |
|
|
| |
In production, we will need this password to make a connection to Redis.
|
| |
|
|
|
| |
The `discord-py` package is no longer the official release, and so
making this change silences some warnings about deprecation.
|
| |\ |
|
| | |\
| | |
| | | |
Refactor the !help command.
|
| | | |\
| | |/
| |/| |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
- Lots of instance of `for c in ...` or `for a in ...` or `fmt` which are non-descriptive and sometimes cryptic.
- Ves suggested running the command in an asyncio task for `@redirect_output`, rather than making a workaround which only applies to the help command. This fixes a fundamental flaw where the redirection message wouldn't be deleted until a further 60sec after the command has finished, which for `!help` could be up to 5min, meaning the invocation message could be sitting there for 6min, not the intended 60sec.
|
| | | |\ |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Not sure why my precommit didn't pick that up...
|
| | | |\ \
| | | | |
| | | | |
| | | | | |
help-refactor
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Make exception handling for bin reaction more specific
- Channel constants were updated recently
- Suggest category names
- Tidy up signature formatting
- Move score cutoff to 80 to allow a few more matches
|
| | | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
help-refactor
Conflicts:
bot/cogs/help.py
|
| | | | | | | |
|
| | | | | | | |
|
| | | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
help-refactor
Conflicts:
bot/cogs/help.py
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Description was the same as prefix parameter of paginator
- Cleanup is redundant pending closure of #514
- Clean/fix couple if statements in help.py
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Change `add_field` back to `description` for error message possible matches
- Only add `Commands` and `Subcommands` if subcommands exist to cog/group/command help
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Before, running `!help` would invoke the cooldown check, and increase the cooldown counter unnecessarily as no wolfram API calls were being made.
- Once `!help` was called enough, the bot would send an error embed to let you know your wolfram cooldown has expired.
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- `redirect_output` has been adjusted to run the `delete_invocation` inside a task as the help command will wait for that to run before sending the help or doing anything else.
- `pagination` has been adjusted to support deleting the paginated message if `cleanup` is True, and an optional `description` that is present through all pages of pagination.
- The help command has been refactored to subclass `commands.HelpCommand`. This means that it now supports methods such as `ctx.send_help(ctx.command)`.
- `help_cleanup` provides the opportunity to use the :x: reaction to cleanup help even with no pagination.
- Pagination purely happens through the `LinePaginator`, forcing a pagination session with 1 line per page where we format the page style before sending it through.
- Categories are properly dealt with by finding a match and sending a seperate help where a named tuple of the Category name, description and relevant cogs is the only parameter.
- Choices for when a command was not found has been updated to include category names, cog names, aliases of group and command names, and include all subcommands and aliases. This should provide a more helpful output when an error message is sent
- Sending command, group, cog, category and bot help has been split into different functions that are called from `command_callback`. This provides an easier way to alter future changes, and cleans up code considerably.
- Important note: no outward facing formatting should have changed. Any desired changes can be discussed in review.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Turns out that bumping the flake8 version up to 3.8 introduces a long
list of new linting errors. Since this PR is the one that bumps the
version, I suppose we will also fix all the linting errors in this
branch.
|
| |\| | | | | | |
|
| | |\ \ \ \ \ \
| | |_|_|_|_|/
| |/| | | | | |
add "solved" as a alias for "closed"
|
| | |/ / / / / |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Turns out the MutableMapping class doesn't give us servicable
implementations of these, so we need to implement them ourselves.
Also, let's not have keys returned as bytestrings.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This is supposed to be provided by our MutableMapping mixin, but unit
tests are demonstrating that these don't really work as intended.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This would've been implemented by MutableMapping, but that
implementation is O(n) instead of O(1) since it just iterates the
entire hash and does HDEL. Feels wasteful.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The rest of the features should be provided by the MutableMapping abc
we're interfacing. Specifically, MutableMapping provides these:
.pop, .popitem, .clear, .update, .setdefault, __contains__, .keys,
.items, .values, .get, __eq__, and __ne__.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It was brought to my attention that we may need several caches per Cog
for some of our Cogs. This means that the original approach of having
this be a mixin is a little bit problematic.
Instead, RedisDict will be instantiated directly inside the class you
want it in. By leveraging __set_name__, we can create a namespace
containing both the class name and the variable name without the user
having to provide anything.
For example, if you create an attribute MyClass.cache = RedisDict(),
this will be using the redis namespace 'MyClass.cache.' before anything
you store in it.
With this approach, it is also possible to instantiate a RedisDict with
a custom namespace by simply passing it into the constructor.
- RedisDict("firedog") will create items with the 'firedog.your_item'
prefix.
- If there are multiple RedisDicts using the same namespace, an
underscore will be appended to the namespace, such that the second
RedisDict("firedog") will actually create items in the
'firedog_.your_item' namespace.
This is also possible to use outside of classes, so long as you provide
a custom namespace when you instantiate it.
Custom namespaces will always take precedence over automatic
'Class.attribute_name' ones.
|
Leon Sandøy
MarkKoz
Leon Sandøy
Sebastiaan Zeeff
mathsman5133
vivax3794