aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | | | * | | | | | | Merge branch 'master' of https://github.com/python-discord/bot into ↵Gravatar mathsman51332020-03-12-2207/+4239
| | | | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | help-refactor  Conflicts:  bot/cogs/help.py
| | | | * | | | | | | | Apply suggestions from Mark's code review.Gravatar mathsman51332020-03-10-60/+63
| | | | | | | | | | | |
| | | | * | | | | | | | Use the new :trashcan: emoji to delete the help message, as per #625Gravatar mathsman51332020-02-10-4/+5
| | | | | | | | | | | |
| | | | * | | | | | | | Merge branch 'master' of https://github.com/python-discord/bot into ↵Gravatar mathsman51332020-02-10-3174/+7258
| | | | |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | help-refactor  Conflicts:  bot/cogs/help.py
| | | | * | | | | | | | | Remove trailing commaGravatar mathsman51332019-11-16-1/+1
| | | | | | | | | | | | |
| | | | * | | | | | | | | Apply suggestions from reviewGravatar mathsman51332019-11-16-24/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Description was the same as prefix parameter of paginator - Cleanup is redundant pending closure of #514 - Clean/fix couple if statements in help.py
| | | | * | | | | | | | | Show a maximum of 8 commands per page rather than 5.Gravatar mathsman51332019-11-03-1/+1
| | | | | | | | | | | | |
| | | | * | | | | | | | | Few changes to keep formatting same as currentGravatar mathsman51332019-10-13-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Change `add_field` back to `description` for error message possible matches - Only add `Commands` and `Subcommands` if subcommands exist to cog/group/command help
| | | | * | | | | | | | | Add a special case for when the help command invokes wolfram checks.Gravatar mathsman51332019-10-13-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Before, running `!help` would invoke the cooldown check, and increase the cooldown counter unnecessarily as no wolfram API calls were being made. - Once `!help` was called enough, the bot would send an error embed to let you know your wolfram cooldown has expired.
| | | | * | | | | | | | | Minor formatting changes to align with current help.Gravatar mathsman51332019-10-12-2/+2
| | | | | | | | | | | | |
| | | | * | | | | | | | | Refactor the `Help` command.Gravatar mathsman51332019-10-12-475/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - `redirect_output` has been adjusted to run the `delete_invocation` inside a task as the help command will wait for that to run before sending the help or doing anything else. - `pagination` has been adjusted to support deleting the paginated message if `cleanup` is True, and an optional `description` that is present through all pages of pagination. - The help command has been refactored to subclass `commands.HelpCommand`. This means that it now supports methods such as `ctx.send_help(ctx.command)`. - `help_cleanup` provides the opportunity to use the :x: reaction to cleanup help even with no pagination. - Pagination purely happens through the `LinePaginator`, forcing a pagination session with 1 line per page where we format the page style before sending it through. - Categories are properly dealt with by finding a match and sending a seperate help where a named tuple of the Category name, description and relevant cogs is the only parameter. - Choices for when a command was not found has been updated to include category names, cog names, aliases of group and command names, and include all subcommands and aliases. This should provide a more helpful output when an error message is sent - Sending command, group, cog, category and bot help has been split into different functions that are called from `command_callback`. This provides an easier way to alter future changes, and cleans up code considerably. - Important note: no outward facing formatting should have changed. Any desired changes can be discussed in review.
| | | | | | | | * | | | | Fix incomplete variable renamingGravatar decorator-factory2020-05-17-1/+1
| | | | | | | | | | | | |
| | | | | | | | * | | | | Rename `string` to `greeting`Gravatar decorator-factory2020-05-17-10/+10
| | | | | | | | | | | | |
| | | | | | | | * | | | | Add a note on user-defined classesGravatar decorator-factory2020-05-17-1/+1
| | | | | | | | | | | | |
| | | | | | | | * | | | | Change standalone programs to interactive sessionsGravatar decorator-factory2020-05-17-8/+13
| | | | | | | | | | | | |
| | | | | | | | * | | | | Apply language improvements proposed from kwzrdGravatar decorator-factory2020-05-17-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: kwzrd <[email protected]>
| | | | | | | | * | | | | Fix hard-wrapping in mutability.mdGravatar decorator-factory2020-04-01-7/+5
| | | | | | | | | | | | |
| | | | | | | | * | | | | header->bold in mutability.mdGravatar decorator-factory2020-04-01-1/+1
| | | | | | | | | | | | |
| | | | | | | | * | | | | Add mutability.md tagGravatar decorator-factory2020-04-01-0/+34
| | | | | | | | | | | | |
| | | | | | | | | * | | | Filtering: don't attempt to send additional embeds for invalid invitesGravatar MarkKoz2020-05-10-1/+3
| |_|_|_|_|_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Invalid invites won't have data available to put in the embeds. Fixes #929 Fixes BOT-3Z
* | | | | | | | | | | | Merge pull request #923 from python-discord/feat/util/remove-mention-cmdGravatar Daniel Brown2020-05-08-56/+2
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the mention command and configuration settings for it
| * \ \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into feat/util/remove-mention-cmdGravatar Daniel Brown2020-05-08-1/+31
| |\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #903 from python-discord/bug/backend/894/win-selector-loopGravatar Daniel Brown2020-05-07-1/+7
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | Use selector event loop on Windows
| * | | | | | | | | | | | Merge branch 'master' into bug/backend/894/win-selector-loopGravatar Daniel Brown2020-05-07-136/+405
| |\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #919 from ↵Gravatar Sebastiaan Zeeff2020-05-05-0/+12
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | python-discord/bug/backend/911/log-listener-exceptions Log unhandled errors from event listeners
| * \ \ \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into bug/backend/911/log-listener-exceptionsGravatar Sebastiaan Zeeff2020-05-05-3/+16
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / |/| | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #925 from Savant-Dev/antimalwareGravatar Daniel Brown2020-05-05-0/+12
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / / / / / |/| | | | | | | | | | | | | Update to Antimalware Filter (.txt uploads)
| * | | | | | | | | | | | | Merge branch 'master' into antimalwareGravatar Daniel Brown2020-05-05-2/+2
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / / |/| | | | | | | | | | | | |
| * | | | | | | | | | | | | Update antimalware to filter txt files in cases where messages were longer ↵Gravatar Savant-Dev2020-05-04-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | than 2000 chars
| * | | | | | | | | | | | | Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev2020-05-01-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | longer than 2000 characters
| * | | | | | | | | | | | | Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev2020-05-01-0/+12
| | |_|_|/ / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | longer than 2000 characters
| | * | | | | | | | | | | Log unhandled errors from event listenersGravatar MarkKoz2020-04-29-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, discord.py prints them to stderr. To better help detect such errors in production, they should instead be logged with an appropriate log level. Some sentry metadata has also been included. `on_error` doesn't work as a listener in a cog so it's been put in the Bot subclass. Fixes #911
| | | * | | | | | | | | | Fix awaiting non-coroutine when closing the statsd transportGravatar MarkKoz2020-04-24-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `BaseTransport.close()` is not a coroutine and therefore should not be awaited.
| | | * | | | | | | | | | Use selector event loop on WindowsGravatar MarkKoz2020-04-22-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | aiodns requires the selector event loop for asyncio. In Python 3.8, the default event loop for Windows was changed to proactor. To fix this, the event loop is explicitly set to selector.
| | | | * | | | | | | | | Remove mention command constantsGravatar MarkKoz2020-05-02-10/+0
| | | | | | | | | | | | |
| | | | * | | | | | | | | Remove the mention commandGravatar MarkKoz2020-05-01-46/+2
| |_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was made obsolete by a new Discord feature. Users can be granted a permission to mention a role despite the role being set as non-mentionable.
* | | | | | | | | | | | Merge pull request #922 from python-discord/bug/info/914/user-animated-avatarGravatar kwzrd2020-05-01-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | | Display animated avatars in the user info command
| * | | | | | | | | | | Tests: change avatar_url_as assertion to use static_formatGravatar MarkKoz2020-04-30-1/+1
| | | | | | | | | | | |
| * | | | | | | | | | | Display animated avatars in the user info commandGravatar MarkKoz2020-04-30-1/+1
|/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #914
* / / / / / / / / / / Run a category check before logging that we are checking for an answered ↵Gravatar Joseph Banks2020-04-30-1/+2
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | help channel
* | | | | | | | | | Merge pull request #913 from python-discord/add-bottom-sorting-to-help-channelsGravatar Sebastiaan Zeeff2020-04-28-12/+63
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Sort help channels and add support for `how-to-get-help` channel
| * | | | | | | | | | Log ID of member who claimed a help channelGravatar Sebastiaan Zeeff2020-04-28-0/+1
| | | | | | | | | | |
| * | | | | | | | | | Add option to ingore channels in help categoriesGravatar Sebastiaan Zeeff2020-04-28-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As we want to add an "informational" channel to the `Python Help: Available` category, we need to make sure that the Help Channel System ignores that channel. To do that, I've added an `is_excluded_channel` staticmethod that returns `True` if a channel is not a TextChannel or if it's in a special EXCLUDED_CHANNELS constant. This method is then used in the method that yields help channels from a category and in the `on_message` event listener that determines if a channel should be moved from `Available` to `Occupied`.
| * | | | | | | | | | Insert help channels at the bottom of the categoryGravatar Sebastiaan Zeeff2020-04-28-9/+48
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit reintroduces bottom sorting for help channels during a category move, but in a more reliable way that also causes far fewer "channel list glitches". This is accomplished by using the "bulk channels update" endpoint of the Discord API. ----------- The Problem ----------- Discord's positioning system is not that easy to work with for developers: Instead of having separate pools of position integers for each category, all text channels are considered to be part of the same "position pool" (or "bucket" in discord.py terms). This also means that changing the position integer of one channel may cause the position integer of another to change, regardless of if the channels share a category or even of if they are close to each other in the guild. As clients receive the position update for each channel as separate CHANNEL UPDATE events, this means that moving one channel may cause other channels to (temporarily) jump around as the client receives the EVENTS from the API. As some position changes affect all the channels in the guild, this will also trigger a nice "channel wave" rolling down the channel list from time to time. For our use case, this was exacerbated by the way `discord.py` handles position changes: It will enumerate the entire, sorted channel list whenever a position change occurs and send a "bulk request" with updated position integers for the entire guild to Discord. This was the reason that all of the sorting methods we've tried resulted in a lot of those "wave" glitches as clients would get a lot of CHANNEL UPDATE events. In addition, the way `discord.py` inserted channels into the payload also meant that our "high integer" methods did not work reliably. ------------ The Solution ------------ Fortunately, there is a solution that will work well most of the time: Making a `bulk channels update` request with only channels of the category we're currently interested in. By providing the current position of the channels that are already in the category, combined with the correct position of the channel moving into the category, we effectively "lock in" the existing channels at the location they already have. The new channel is simply moved into the right position in relation to the existing channels. This means that effectively, we only communicate one channel position change to Discord, making sure that as few channels as possible actually change their formal "position int". From there on, there are two options: 1. Keep the existing channels in place, add the new channel at the bottom (new highest int) 2. Keep the existing channels in place, add the new channel at the top (new lowest int) Both methods work, but option two has a flaw: The position int will get smaller and smaller, until it reaches `0`. Since negative position integers are not allowed, the entire category now has to be shifted upwards to make room for new top channels. This comes at the cost of a "wave" glitch within the category. My initial instinct was to solve this by giving the channels in the category a "really high" straight of position ints, but as Discord recalculates the ints from time to time anyway, this does not work. That's why I opted for the `bottom sort` option, which does not suffer from that issue. I've also asked the question of `top` vs `bottom` in #admins, without the context above, and the preferred method seemed to be `bottom` in any case. ----------- Limitations ----------- While Discord doesn't care that much about duplicates or neatly ascending integers, some channel move actions will inevitably result in a recalculation of the positions ints. This means that "wave" glitches may still happen from time to time, but they should be infrequent. (They also happen if you drag channels in your client; it seems to be a fundamental part of how positioning works.) I think this is something we'll have to live with. Another thing that I suspect may happen is that during times of API lag in the middle of help channel rush hour, some CHANNEL UPDATE events belonging to previous channel moves will not be received/processed yet by the time we make the next move. As we rely on cached position integers, this could mean that from time to time a channel is inserted near the bottom but not at the bottom. As Discord sends these CHANNEL UPDATE replies as individual events in an asynchronous manner instead of as a single response to our `bulk channels update` request, there's nothing much we can do about this. However, I have yet to observe this, so maybe it will never happen.
* | | | | | | | | | Merge pull request #895 from python-discord/broadening-eval-whitelistGravatar Mark2020-04-27-52/+249
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Allowing `!eval` in help channels
| * \ \ \ \ \ \ \ \ \ Merge branch 'master' into broadening-eval-whitelistGravatar Sebastiaan Zeeff2020-04-27-69/+60
| |\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / |/| | | | | | | | | |
* | | | | | | | | | | Merge pull request #885 from python-discord/feat/frontend/839/help-channel-roleGravatar Sebastiaan Zeeff2020-04-27-69/+60
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Use a role overwrite to keep track of help channel cooldowns
| * \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into feat/frontend/839/help-channel-roleGravatar Sebastiaan Zeeff2020-04-27-7/+50
| |\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | |
| * | | | | | | | | | | HelpChannels: rename dormant command to closeGravatar MarkKoz2020-04-20-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | People are more familiar with the "close" alias than its actual name, "dormant". "close" also feels more natural.
| * | | | | | | | | | | HelpChannels: check if the help cooldown role existsGravatar MarkKoz2020-04-20-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A NotFound error can be misleading since it may apply to the member or the role. The log message was not simply updated because each of the scenarios need to have different log levels: missing members is a normal thing but an invalid role is not.