aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Silence: refactor _silenceGravatar MarkKoz2020-10-06-33/+32
| | | | | | | * Rename to `_silence_overwrites` * Reduce responsibilities to only setting permission overwrites * Log in `silence` instead * Add to notifier in `silence` instead
* Silence: move unsilence scheduling to a separate functionGravatar MarkKoz2020-10-06-8/+13
|
* Add license & copyright for autospec's _decoration_helperGravatar MarkKoz2020-09-25-0/+52
|
* Silence: use f-string for messageGravatar Mark2020-09-22-1/+1
| | | Co-authored-by: Numerlor <[email protected]>
* Silence: cancel init task when cog unloadsGravatar MarkKoz2020-08-18-4/+12
|
* Silence: rename cachesGravatar MarkKoz2020-08-18-29/+29
|
* Silence tests: remove unnecessary spec_set argsGravatar MarkKoz2020-08-18-3/+3
| | | | It's not really necessary to set to True when mocking functions.
* Silence tests: more accurately assert the silence cmd schedule a taskGravatar MarkKoz2020-08-18-3/+7
|
* Silence tests: add a test for rescheduling active silencesGravatar MarkKoz2020-08-18-0/+29
|
* Silence tests: test the rescheduler unsilences expired silencesGravatar MarkKoz2020-08-18-0/+14
|
* Silence tests: test the rescheduler adds permanent silence to notifierGravatar MarkKoz2020-08-18-0/+14
|
* Silence tests: test the scheduler skips missing channelsGravatar MarkKoz2020-08-18-0/+25
|
* Silence tests: add a test for _init_cog rescheduling unsilencesGravatar MarkKoz2020-08-18-0/+7
|
* Silence tests: remove _reschedule patch for cog testsGravatar MarkKoz2020-08-18-4/+0
| | | | | | | | | | They don't do anything because they patch the class rather than the instance. It's too late for patching the instance to work since the `setUp` fixture, which instantiates the cog, executes before the patches do. Patching `setUp` would work (and its done in the other test cases), but some tests in this case will need the unpatched function too. Patching it doesn't serve much benefit to most tests anyway, so it's not worth the effort trying to make them work where they aren't needed.
* Silence tests: access everything via the silence moduleGravatar MarkKoz2020-08-18-24/+23
| | | | | | The module is imported anyway to keep imports short and clean. Using it in patch targets is shorter and allows for the two imports from the module to be removed.
* Silence tests: add a subtest for the manual unsilence messageGravatar MarkKoz2020-08-17-4/+7
|
* Silence tests: assert against message constantsGravatar MarkKoz2020-08-17-15/+24
| | | | | Duplicating strings in assertions is redundant, closely coupled, and less maintainable.
* Silence tests: also test that cache misses preserve other overwritesGravatar MarkKoz2020-08-17-12/+16
|
* Silence tests: add a test for a mod alert on cache missGravatar MarkKoz2020-08-17-0/+7
|
* Silence tests: add a test for default overwrites on cache missGravatar MarkKoz2020-08-17-4/+19
| | | | | | | Use a False for `add_reactions` in the mock overwrite rather than None to be sure the default (also None) is actually set for it. Fix channels set by `_init_cog` not being mocked properly.
* Silence tests: add a test for task cancellationGravatar MarkKoz2020-08-17-0/+5
|
* Silence tests: add a test for deletion from the time cacheGravatar MarkKoz2020-08-17-0/+5
|
* Silence tests: add tests for scheduling tasksGravatar MarkKoz2020-08-17-0/+12
|
* Silence tests: add a test for caching permanent timesGravatar MarkKoz2020-08-17-0/+6
|
* Silence tests: add a test for the time cacheGravatar MarkKoz2020-08-17-0/+15
|
* Silence tests: fix mock for _init_taskGravatar MarkKoz2020-08-17-2/+4
| | | | | | | An `AsyncMock` fails because it returns a coroutine which may only be awaited once. However, an `asyncio.Future` is perfect because it is easy to create and can be awaited repeatedly, just like the actual `asyncio.Task` that is being mocked.
* Silence tests: create channel and overwrite in setUp for silence testsGravatar MarkKoz2020-08-17-29/+17
| | | | Reduce code redundancy by only defining them once.
* Silence tests: merge unsilence fixture into setUpGravatar MarkKoz2020-08-17-32/+20
| | | | | Now that there are separate test cases, there's no need to keep the fixtures separate.
* Silence tests: autospec _reschedule and SilenceNotifier for cog testsGravatar MarkKoz2020-08-17-4/+10
|
* Silence tests: separate test cases; refactor names & docstringsGravatar MarkKoz2020-08-17-71/+95
|
* Silence tests: fix tests for _unsilenceGravatar MarkKoz2020-08-17-30/+45
| | | | | Add a fixture to set up mocks for a successful `unsilence` call. This reduces code redundancy.
* Silence tests: fix test_unsilence_private_removed_notifierGravatar MarkKoz2020-08-17-2/+5
|
* Silence tests: fix overwrite preservation test for silencesGravatar MarkKoz2020-08-17-11/+15
|
* Silence tests: fix command message testsGravatar MarkKoz2020-08-17-15/+10
|
* Silence tests: fix test_silence_private_for_falseGravatar MarkKoz2020-08-17-4/+13
|
* Silence tests: fix test_silence_private_silenced_channelGravatar MarkKoz2020-08-17-3/+10
|
* Silence tests: fix test_silence_private_notifierGravatar MarkKoz2020-08-17-0/+3
|
* Silence tests: fix test_unsilence_private_for_falseGravatar MarkKoz2020-08-17-1/+4
|
* Silence tests: fix silence cache test for overwritesGravatar MarkKoz2020-08-17-5/+8
|
* Silence tests: replace obsolete cog_unload testsGravatar MarkKoz2020-08-17-13/+4
| | | | | Moderation notifications are no longer sent so that doesn't need to be tested.
* Silence tests: rename test_instance_vars to test_init_cogGravatar MarkKoz2020-08-17-5/+5
|
* Silence tests: mock RedisCachesGravatar MarkKoz2020-08-17-3/+2
|
* Tests: optionally prevent autospec helper from passing mocksGravatar MarkKoz2020-08-17-19/+66
| | | | | | | | | Not everything that's decorated needs the mocks that are patched. Being required to add the args to the test function anyway is annoying. It's especially bad if trying to decorate an entire test suite, as every test would need the args. Move the definition to a separate module to keep things cleaner.
* Silence: rename _get_instance_vars to _init_cogGravatar MarkKoz2020-08-16-9/+9
| | | | It's a more accurate name since it also reschedules unsilences now.
* Silence: remove event and await _get_instance_vars_task directlyGravatar MarkKoz2020-08-16-6/+2
| | | | | | The event is redundant because the task can be awaited directly to block until it's complete. If the task is already done, the await will instantly finish.
* Silence: use aware datetimesGravatar MarkKoz2020-08-16-5/+6
| | | | | | | | `datetime.timestamp()` assumes naïve `datetime`s are in local time, so getting POSIX timestamps in UTC isn't easy for naïve ones. Technically, the timestamp's timezone doesn't matter if all code is on the same page and parsing it with the same timezone. Keeping it in the local timezone would be okay then, but I feel safer locking it to UTC explicitly.
* Silence: reschedule silences on startupGravatar MarkKoz2020-08-16-10/+32
| | | | | | | | | | | | Remove the moderator notification when unloading the cog because. Its purpose was to remind to manually unsilence channels. However, this purpose is now obsolete due to automatic rescheduling. The notification was buggy anyway due to a race condition with the bot shutting down, and that'd be further complicated by having to asynchronously retrieve channels from the redis cache too. Fixes #1053
* Silence: persist silenced channelsGravatar MarkKoz2020-08-16-0/+11
| | | | Can be used to support rescheduling.
* Silence: add separate unsilence error for manually-silenced channelsGravatar MarkKoz2020-08-15-1/+9
| | | | | | | It was confusing to reject a silence and an unsilence when overwrites were manually set to False. That's because it's contradictory to show an error stating it's already silence but then reject an unsilence with an error stating the channel isn't silenced.
* Silence: notify admins if previous overwrites were not cachedGravatar MarkKoz2020-08-15-12/+25
| | | | | Admins will have to manually check the default values used and adjust them if they aren't the desired values for that particular channel.
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-25 15:45:37 +0000