aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | * | | | | | | | | | | | | | Incidents: reduce timeout log to info levelGravatar kwzrd2020-09-27-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This shouldn't be a warning, as we cannot do anything about it. Fixes BOT-8X
| | * | | | | | | | | | | | | | Verification: apply 'safe_dm' to all DM dispatchesGravatar kwzrd2020-09-27-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now, when we send a DM and it fails: * Ignore if due to disabled DMs * Log exception otherwise
| | * | | | | | | | | | | | | | Verification: move disabled DM handling into helperGravatar kwzrd2020-09-27-5/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note that we were previously only catching 403. As the docstring explains, we will now catch any Discord exception and only look at the the code, rather than the status.
| * | | | | | | | | | | | | | | Merge remote-tracking branch 'origin/master' into masterGravatar Matteo Bertucci2020-09-27-585/+101
| |\| | | | | | | | | | | | | |
| | * | | | | | | | | | | | | | Relock Pipfile to update async-redis.Gravatar Leon Sandøy2020-09-27-62/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also bumps minor versions of several other packages. I've spun up the bot and played around with it, and run all unit tests. Everything still seems to be in order.
| | * | | | | | | | | | | | | | Add the video to the welcome DM.Gravatar Leon Sandøy2020-09-27-4/+7
| | | |_|_|_|_|/ / / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This rewords the welcome DM, and adds the new Welcome To Python Discord video to it.
| | * | | | | | | | | | | | | PR #1151 Sync: remove confirmationGravatar kwzrd2020-09-26-519/+24
| | |\ \ \ \ \ \ \ \ \ \ \ \ \
| | | * | | | | | | | | | | | | Sync: update sync() docstringGravatar MarkKoz2020-09-26-3/+1
| | | | | | | | | | | | | | | |
| | | * | | | | | | | | | | | | Sync: remove _asdict commentGravatar MarkKoz2020-09-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The comment doesn't contribute anything.
| | | * | | | | | | | | | | | | Merge branch 'master' into feat/backend/1075/remove-syncer-confirmGravatar MarkKoz2020-09-22-2227/+2207
| | | |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | |_|_|_|_|_|_|_|_|_|_|/ | | | | |/| | | | | | | | | | |
| | | * | | | | | | | | | | | | Sync: refactor conditional for sending message Gravatar Mark2020-09-22-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ternary is a bit confusing. Co-authored-by: Numerlor <[email protected]>
| | | * | | | | | | | | | | | | Fix test for sync message being editedGravatar MarkKoz2020-09-07-1/+3
| | | | | | | | | | | | | | | |
| | | * | | | | | | | | | | | | Sync: remove confirmationGravatar MarkKoz2020-09-07-518/+20
| | | | |_|_|_|_|_|_|_|_|_|/ / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The confirmation was intended to be a safe guard against cache issues that would cause a huge number of roles/users to deleted after syncing. With `wait_until_guild_available`, such cache issue shouldn't arise. Therefore, this feature is obsolete. Resolve #1075
| * | | | | | | | | | | | | | Allow !role for any staff roleGravatar Matteo Bertucci2020-09-27-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #1173
| * | | | | | | | | | | | | | Allow !eval in #code-help-voiceGravatar Matteo Bertucci2020-09-27-1/+3
| |/ / / / / / / / / / / / /
| | | | | * | | | | | | | | Lock: make LockGuard.locked a propertyGravatar MarkKoz2020-10-03-1/+2
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Lock: rename variable to avoid shadowingGravatar MarkKoz2020-10-03-3/+3
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Reminders: fix conflict with the _can_modify checkGravatar MarkKoz2020-09-09-1319/+1347
| | | | | |\ \ \ \ \ \ \ \ \ | | | |_|_|/ / / / / / / / / | | |/| | | | | | | | | | |
| | | | | * | | | | | | | | Fix attribute docstring for LockedResourceErrorGravatar MarkKoz2020-09-09-1/+1
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Move lock decorators to utils/lock.pyGravatar MarkKoz2020-09-09-86/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `LockGuard` was lonely and the decorators were cluttering up decorators.py.
| | | | | * | | | | | | | | Decorators: rename mutually_exclusive decoratorsGravatar MarkKoz2020-09-09-14/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A mutex is the same thing as a lock. The former is a relatively esoteric contraction, so the latter is preferred.
| | | | | * | | | | | | | | Decorators: remove locked() decoratorGravatar MarkKoz2020-09-09-35/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was not being used anywhere.
| | | | | * | | | | | | | | Decorators: replace asyncio.Lock with a custom objectGravatar MarkKoz2020-08-22-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Concerns were raised over possible race conditions due `asyncio.Lock` internally awaiting coroutines. Does a mere `await` suspend the current coroutine, or does it have to actually await something asynchronous, like a future? Avoid answering that question by doing away with the awaits, which aren't necessary but are there as a consequence of using `asyncio.Lock`. Instead, add a custom `LockGuard` object to replace the previous locks.
| | | | | * | | | | | | | | Explicitly use kwarg with respect_role_hierarchyGravatar MarkKoz2020-08-01-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify the significance of the argument being passed.
| | | | | * | | | | | | | | Decorators: fix type annotations for checksGravatar MarkKoz2020-08-01-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The annotation was previously changed on the basis of an incorrect return annotation PyCharm inferred for `check()`.
| | | | | * | | | | | | | | Reminders: use singular form for mutually exclusive namespaceGravatar MarkKoz2020-07-31-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The exception it raises reads better if the singular form of the word is used.
| | | | | * | | | | | | | | Reminders: show error to users if reminder is in useGravatar MarkKoz2020-07-31-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Silent failure is confusing to users. Showing an error message clears up why nothing happened with their command.
| | | | | * | | | | | | | | Send users an error message if command raises LockedResourceErrorGravatar MarkKoz2020-07-31-0/+3
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: optionally raise an exception if resource is lockedGravatar MarkKoz2020-07-31-4/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The exception will facilitate user feedback for commands which use the decorator.
| | | | | * | | | | | | | | Decorators: add some trace loggingGravatar MarkKoz2020-07-31-0/+3
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: wrap mutually_exclusive to use get_arg_valueGravatar MarkKoz2020-07-31-7/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of taking a callable, this wrapper just takes a name or position to get the resource ID.
| | | | | * | | | | | | | | Decorators: remove redundant word in docstringGravatar MarkKoz2020-07-31-1/+1
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: use type aliases from function moduleGravatar MarkKoz2020-07-31-4/+2
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: remove default value for respect_role_hierarchyGravatar MarkKoz2020-07-31-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explicit is better than implicit, and this default value wasn't much of a convenience.
| | | | | * | | | | | | | | Decorators: use new func utils in respect_role_hierarchyGravatar MarkKoz2020-07-31-30/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the `_get_arg_value` call with `function.get_arg_value` cause the latter makes use of bound arguments, which are more accurate.
| | | | | * | | | | | | | | Add a function to get bound argsGravatar MarkKoz2020-07-31-4/+17
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Add a function to wrap a decorator to use get_arg_valueGravatar MarkKoz2020-07-31-1/+28
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Reminders: make operations mutually exclusiveGravatar MarkKoz2020-07-31-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes race conditions between editing, deleting, and sending a reminder. If one operation is already happening, the others will be aborted.
| | | | | * | | | | | | | | Add util function to get value from argGravatar MarkKoz2020-07-31-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a more advanced version meant to eventually replace the `_get_arg_values` in decorators.py.
| | | | | * | | | | | | | | Decorators: pass bound arguments to callableGravatar MarkKoz2020-07-31-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bound arguments are more convenient to work with than the raw args and kwargs.
| | | | | * | | | | | | | | Decorators: clarify use of mutually_exclusive with commandsGravatar MarkKoz2020-07-31-0/+2
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: add logging for mutually_exclusiveGravatar MarkKoz2020-07-31-4/+12
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: fix lock creationGravatar MarkKoz2020-07-31-1/+1
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: support awaitables for resource IDGravatar MarkKoz2020-07-31-4/+11
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: drop arg pos/name support for mutually_exclusiveGravatar MarkKoz2020-07-31-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Supporting ID retrieval by arg name or position made for a confusing interface. I also doubt it would have been used much. A callable can achieve the same thing, albeit with a little more code. Now the decorator instead supports passing an ID directly or a callable.
| | | | | * | | | | | | | | Decorators: add mutually exclusive decoratorGravatar MarkKoz2020-07-31-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used to prevent race conditions on a resource by stopping all other access to the resource once its been acquired.
| | | | | * | | | | | | | | Decorators: create helper function to get arg valueGravatar MarkKoz2020-07-31-10/+24
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: clean up importsGravatar MarkKoz2020-07-31-28/+26
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Decorators: more accurate return type for checksGravatar MarkKoz2020-07-31-3/+3
| | | | | | | | | | | | | |
| | | | | * | | | | | | | | Reminders: fix reminder_id type annotationGravatar MarkKoz2020-07-31-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's fine to accept an int since it'll get converted to a string anyway.