| Commit message (Collapse) | Author | Age | Lines |
|---|
| |\ |
|
| | |\
| | |
| | | |
Expand Antimalware User Feedback & Logging
|
| | | |\
| | |/
| |/| |
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
python-discord/extensions-cog-docstring-deprecation-warning
Use raw strings for docstrings with forward slashes
|
| | | |\ \
| | |/ /
| |/| | |
|
| | |\ \ \
| | | | |
| | | | | |
Add more pre-commit hooks and run them in CI
|
| | | |\ \ \
| | |/ / /
| |/| | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | | |
This was added by the now-removed Snake cog & is not used elsewhere on bot.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The mock gets used by the flake8 pre-commit hook, which invokes flake8
via `pipenv run flake8`. It's normally useful to use pipenv here cause
it ensures flake8 is invoked within the context of the venv. However, in
CI, there is no venv - dependencies are installed directly to the
system site-packages. `pipenv run` does not work in such case because it
tries to create a new venv if one doesn't exist (it doesn't consider the
system interpreter to be a venv).
This workaround (okay, it's a hack) creates an executable shell script
which replaces the original pipenv binary. The shell script simply
ignores the first argument (i.e. ignores `run` in `pipenv run`) and
executes the rest of the arguments as a command. It essentially makes
`pipenv run flake8` equivalent to just having ran `flake8`. When
pre-commit executes pipenv, the aforementioned script is what will run.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
A cache for an outdated pre-commit environment may still be useful. It
may be the case that only some hooks need to be updated rather than
all.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Remove trailing whitespaces
* Specify error code for a noqa in the free command
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
A few docstrings in `bot.cogs.extensions` have forward slashed in them to escape Markdown rendering when our help feature uses these docstring in a Discord message. However, the use of forward slashes with an invalid escape sequence in docstrings now raises a DeprecationWarning in Python:
/home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \*
PEP 257 (Docstring Conventions, https://www.python.org/dev/peps/pep-0257/) states that raw strings should be used for docstrings that use forward slashes, so I've added the `r`-prefix to the docstrings that use forward slashes.
|
| | |\ \ \
| | | | |
| | | | | |
Prevent exception if a watched user sends a DM to the bot
|
| | |/ / /
| | | |
| | | | |
The previous embed assumed that the messages would be sent on the server, where the channel would have a name and the message would have a jump URL. For a DM, neither of these are present and an exception will be raised when attempting to construct the embed for the webhook to send.
|
| | | | |\
| | |_|/
| |/| | |
|
| | |\ \ \
| | |/ /
| |/| | |
Create AsyncResolver inside a coroutine to avoid DeprecationWarning
|
| | | |\ \
| | |/ /
| |/| | |
|
| | | | |
| | | |
| | | | |
Resolves an issue mentioned in https://github.com/python-discord/bot/issues/767, giving Helpers access to post invites and other things caught by the Filtering cog.
|
| | |\ \ \
| | | | |
| | | | | |
Migrate bot to Python 3.8
|
| | | |\ \ \
| | |/ / /
| |/| | | |
|
| | |\ \ \ \
| | | | | |
| | | | | | |
Add grabify (IP logger) domains to banned domains
|
| | |/ / / / |
|
| | |\ \ \ \
| | | | | |
| | | | | | |
Optimize Dockerfile for faster rebuilds
|
| | | |\ \ \ \
| | |/ / / /
| |/| | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | | |
Previous regex utilized a `/`, which doesn't work for comparing against Windows paths, which use `\`
|
| | | | | | |
| | | | | |
| | | | | | |
Returning directly out of a `finally` clause can cause any exceptions raised in the clause to be discarded, so we can remove the finally clause entirely and shift the control statements into the body of the function
|
| | | | | | |
| | | | | |
| | | | | | |
* Remove explicit urllib3 pinning, CVE that caused its pinning has been resolved by 1.25+. This is a child dependency of requests.
|
| | | | |\ \ \
| | |_|/ / /
| |/| | | |
| | | | | | |
I have resolved a merge conflict in Pipfile.lock by relocking with the newly added dependencies of `coloredlogs` and `colorama`.
|
| | |\| | | |
| | | | | |
| | | | | | |
Coloured log output
|
| | | | | | | |
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
This makes it easy to add colour to the logs. Colorama is also installed
if on a Windows system.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I've migrated the `tests/test_snekbox.py` file to use the new Python 3.8-style unittests instead of our old style using our custom Async mocks.
In particular, I had to make a few changes:
- Mocking the async post() context manager correctly
Since `ClientSession.post` returns an async context manager when called, we need to make sure to assign the return value to the __aenter__ method of whatever `post()` returns, not of `post` itself (i.e.. when it's not called).
- Use the new AsyncMock assert methods `assert_awaited_once` and `assert_awaited_once_with`
Objects of the new `unittest.mock.AsyncMock` class have special methods to assert what they were called with that also assert that specific coroutine object was awaited. This means we test two things in one: Whether or not it was called with the right arguments and whether or not the returned coroutine object was then awaited.
- Patch `functools.partial` as `partial` objects are compared by identity
When you create two partial functions of the same function, you'll end up with two different `partial` objects. Since `partial` objects are compared by identity, you can't compare a `partial` created in a test method to that created in the callable you're trying to test. They will always compare as `False`. Since we're not interested in actually creating `partial` objects, I've just patched `functools.partial` in the namespace of the module we're testing to make sure we can compare them.
|
| | | |\ \ \
| | |/ / /
| |/| | |
| | | | | |
I've resolved the merge conflict by confirming the deleted part of tests/helpers.py
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
python-discord/bug/backend/b754/scheduler-suppresses-errors
Don't suppress all errors in scheduler
|
| | | |\ \ \ \
| | |/ / / /
| |/| | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Logging it ourselves has a cleaner traceback and gives more control
over the output, such as including the task ID.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If a task is cancelled it is assumed it was done via cancel_task. That
method deletes the task after cancelling so the warning isn't relevant.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Task.exception() only returns the exception. It still needs to be
explicitly raised.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
To prevent a deletion of task rescheduled with the same ID, the callback
checks that the stored task is the same as the done task being handled.
* Only delete the task; it doesn't need to be cancelled because the it
is already done
* Revise the callback's docstring to explain the new behaviour
* Rename `task` parameter to `done_task`
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Use imperative mood for docstring
* Explain the purpose of the parameter in the docstring
* Make log message after cog name lowercase
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The shield exists to be used for exactly this purpose so its a better
fit than create_task.
|
| | | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
bug/backend/b754/scheduler-suppresses-errors
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Main concern is someone trying to cancel a task directly. The workaround
for the race condition relies on the task only being cancelled via
Scheduler.cancel_task(), particularly because it removes the task from
the dictionary. The done callback will not remove from the dictionary
if it sees the task has already been cancelled. So it's a bad idea to
cancel tasks directly...
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Because deactivate_infraction() explicitly cancels the scheduled task,
it now runs in a separate task to avoid prematurely cancelling itself.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This design makes more sense and is more convenient than requiring tasks
to be responsible for cancelling themselves.
* Rename _handle_task_exception to _task_done_callback
* Add trace logging
|
S. Co1
Mark
Shirayuki Nekomata
scragly
Sebastiaan Zeeff
Leon Sandøy
S. Co1
kwzrd
Joseph
Spencer Young
Eivind Teig