aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
* | | | | Merge pull request #895 from python-discord/broadening-eval-whitelistGravatar Mark2020-04-27-52/+249
|\ \ \ \ \ | | | | | | | | | | | | Allowing `!eval` in help channels
| * \ \ \ \ Merge branch 'master' into broadening-eval-whitelistGravatar Sebastiaan Zeeff2020-04-27-69/+60
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #885 from python-discord/feat/frontend/839/help-channel-roleGravatar Sebastiaan Zeeff2020-04-27-69/+60
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use a role overwrite to keep track of help channel cooldowns
| * \ \ \ \ \ Merge branch 'master' into feat/frontend/839/help-channel-roleGravatar Sebastiaan Zeeff2020-04-27-7/+50
| |\ \ \ \ \ \ | |/ / / / / / |/| | | | | |
| * | | | | | HelpChannels: rename dormant command to closeGravatar MarkKoz2020-04-20-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | People are more familiar with the "close" alias than its actual name, "dormant". "close" also feels more natural.
| * | | | | | HelpChannels: check if the help cooldown role existsGravatar MarkKoz2020-04-20-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A NotFound error can be misleading since it may apply to the member or the role. The log message was not simply updated because each of the scenarios need to have different log levels: missing members is a normal thing but an invalid role is not.
| * | | | | | HelpChannels: pass coroutine func instead to `_change_cooldown_role`Gravatar MarkKoz2020-04-20-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will allow `_change_cooldown_role` to handle the role argument rather than putting that burden on the callers.
| * | | | | | HelpChannels: tidy up log messagesGravatar MarkKoz2020-04-20-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove obsolete log message * Shorten a log message which was the only line in the entire module over 100 characters
| * | | | | | HelpChannels: handle errors when changing cooldown roleGravatar MarkKoz2020-04-17-12/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A user may leave the guild before their role can be changed. Sometimes, there could also be role hierarchy issues or other network issues. It's not productive to halt everything and just dump these as exceptions to the loggers. The error handler provides a more graceful approach to these exceptions. * Add a wrapper function around `add_roles` & `remove_roles` which catches exceptions
| * | | | | | HelpChannels: fix role not resetting after dormant commandGravatar MarkKoz2020-04-17-13/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resetting permissions relied on getting the member from the cache, but the member was already removed from the cache prior to resetting the role. Now the member is passed directly rather than relying on the cache.
| * | | | | | HelpChannels: mention dormant cmd in available message embedGravatar MarkKoz2020-04-17-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Users should know they can close their own channels.
| * | | | | | HelpChannels: add info about cooldown role & dormant cmd to docstringGravatar MarkKoz2020-04-17-0/+3
| | | | | | |
| * | | | | | HelpChannels: add/remove a cooldown role rather than using overwritesGravatar MarkKoz2020-04-17-13/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Overwrites had issues syncing with channels in the category. * Remove update_category_permissions; obsolete * Add constant for the cooldown role wrapped in a discord.Object
| * | | | | | HelpChannels: clear roles when resetting permissionsGravatar MarkKoz2020-04-17-9/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Claimants will have a special role that needs to be removed rather than using member overwrites for the category.
| * | | | | | HelpChannels: add helper function to check for claimant roleGravatar MarkKoz2020-04-17-0/+5
| | | | | | |
| * | | | | | HelpChannels: remove ensure_permissions_synchronizationGravatar MarkKoz2020-04-17-29/+1
| | | | | | |
| * | | | | | Constants: add help channel cooldown roleGravatar MarkKoz2020-04-17-0/+2
| | | | | | |
| | * | | | | Add DMChannel tests for in_whitelist decoratorGravatar Sebastiaan Zeeff2020-04-27-31/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `in_whitelist` decorator should not fail when a decorated command was called in a DMChannel; it should simply conclude that the user is not allowed to use the command. I've added a test case that uses a DMChannel context with User, not Member, objects. In addition, I've opted to display a test case description in the `subTest`: Simply printing the actual arguments and context is messy and does not actually show you the information you'd like. This description is enough to figure out which test is failing and what the gist of the test is.
| | * | | | | Add mock for discord.DMChannelsGravatar Sebastiaan Zeeff2020-04-27-0/+21
| | | | | | |
| | * | | | | Exclude never-run lines from coverageGravatar Sebastiaan Zeeff2020-04-27-2/+2
| | | | | | |
| | * | | | | Simplify `in_whitelisted_context` decorator APIGravatar Sebastiaan Zeeff2020-04-23-92/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The API of the `in_whitelisted_context` decorator was a bit clunky: - The long parameter names frequently required multiline decorators - Despite `#bot-commands` being the defacto default, it needed to be passed - The name of the function, `in_whitelisted_context` is fairly long in itself To shorten the call length of the decorator, the parameter names were shortened by dropping the `whitelisted_` prefix. This means that the parameter names are now just `channels`, `categories`, and `roles`. This already means that all current usages of the decorator are reduced to one line. In addition, `#bot-commands` has now been made the default redirect channel for the decorator. This means that if no `redirect` was passed, users will be redirected to `bot-commands` to use the command. If needed, `None` (or any falsey value) can be passed to disable redirection. Passing another channel id will trigger that channel to be used as the redirection target instead of bot-commands. Finally, the name of the decorator was shortened to `in_whitelist`, which already communicates what it is supposed to do.
| | * | | | | Allow `!eval` in help channel categoriesGravatar Sebastiaan Zeeff2020-04-23-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As help conversations now take place in their own, dedicated channels, there's no longer a pressing need to restrict the `!eval` command in help channels for regular members. As the command can be a valuable tool in explaining and teaching Python, we've therefore chosen to allow it in channels in `Help: Available` and `Help: Occupied` catagories.
| | * | | | | Add tests for `in_whitelisted_context` decoratorGravatar Sebastiaan Zeeff2020-04-23-0/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I have added tests for the new `in_whitelisted_context` decorator. They work by calling the decorator with different kwargs to generate a specific predicate callable. That callable is then called to assess if it comes to the right conclusion.
| | * | | | | Remove vestigial kwargs from MockTextChannel.__init__Gravatar Sebastiaan Zeeff2020-04-23-1/+1
| | | | | | |
| | * | | | | Replace `in_channel` decorator by `in_whitelisted_context`Gravatar Sebastiaan Zeeff2020-04-23-47/+94
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `in_channel` decorator that served as a factory for `in_channel` checks was replaced by the broaded `in_whitelisted_context` decorator. This means that we can now whitelist commands using channel IDs, category IDs, and/or role IDs. The whitelists will be applied in an "OR" fashion, meaning that as soon as some part of the context happens to be whitelisted, the `predicate` check the decorator produces will return `True`. To reflect that this is now a broader decorator that checks for a whitelisted *context* (as opposed to just whitelisted channels), the exception the predicate raises has been changed to `InWhitelistedContextCheckFailure` to reflect the broader scope of the decorator. I've updated all the commands that used the previous version, `in_channel`, to use the replacement.
* | | | | | Merge pull request #904 from Akarys42/free-tagGravatar Shirayuki Nekomata2020-04-23-0/+5
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Free tag
| * | | | | Merge branch 'master' into free-tagGravatar Shirayuki Nekomata2020-04-23-12/+57
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #900 from python-discord/fix-category-cache-issueGravatar Sebastiaan Zeeff2020-04-21-3/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix category cache issue
| * | | | | | Fix category cache issueGravatar Joseph Banks2020-04-21-3/+2
|/ / / / / /
* | | | | | Merge pull request #896 from python-discord/answered-session-statsGravatar Mark2020-04-20-3/+42
|\ \ \ \ \ \ | | | | | | | | | | | | | | Answered help session statistics
| * | | | | | HelpChannels: add logging to answered checkGravatar MarkKoz2020-04-20-3/+4
| | | | | | |
| * | | | | | Extra documentation + split out to separate functionGravatar Joseph Banks2020-04-20-8/+26
| | | | | | |
| * | | | | | Add different emoji for different channel statuses (in use answered/unanswered)Gravatar Joseph Banks2020-04-20-2/+7
| | | | | | |
| * | | | | | Incorrect comparison, we need to check if we are in help_in_use, not out of itGravatar Joseph Banks2020-04-20-1/+1
| | | | | | |
| * | | | | | Add statistics on whether a help session was closed with no input from ↵Gravatar Joseph Banks2020-04-20-0/+15
|/ / / / / / | | | | | | | | | | | | | | | | | | anyone but the claimant
| * | | | | Free tag: fix typo in headerGravatar kwzrd2020-04-23-1/+1
| | | | | |
| * | | | | Simplify free tagGravatar Matteo Bertucci2020-04-23-3/+2
| | | | | |
| * | | | | Use IDs instead of hard-coding category names in the free tagGravatar Matteo Bertucci2020-04-16-2/+1
| | | | | | | | | | | | | | | | | | Co-Authored-By: Shirayuki Nekomata <[email protected]>
| * | | | | Add a title at the top of the free tagGravatar Matteo Bertucci2020-04-16-0/+2
| | | | | | | | | | | | | | | | | | Co-Authored-By: Shirayuki Nekomata <[email protected]>
| * | | | | Create temporary free tagGravatar Matteo Bertucci2020-04-16-0/+5
| | | | | |
| | | * | | Update Python News extension name in __main__.pyGravatar ks1292020-05-07-1/+1
| | | | | | | | | | | | | | | | | | Co-authored-by: Joseph Banks <[email protected]>
| | | * | | Merge remote-tracking branch 'origin/python-news' into python-newsGravatar ks1292020-05-06-14/+18
| | | |\ \ \
| | | | * | | Fix config Webhook IDs formattingGravatar ks1292020-05-06-6/+6
| | | | | | | | | | | | | | | | | | | | | Co-authored-by: Sebastiaan Zeeff <[email protected]>
| | | | * | | Fix `News` cog maillist news posting no threads check commentGravatar ks1292020-05-03-1/+3
| | | | | | | | | | | | | | | | | | | | | Co-authored-by: Joseph Banks <[email protected]>
| | | | * | | Define encoding in `News` cog `await resp.text()` using Gravatar ks1292020-05-02-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In `News` cog PEP news posting, define `utf-8` as encoding on response parsing to avoid the error. Co-authored-by: Joseph Banks <[email protected]>
| | | | * | | Merge the two asynchronous tasks into one to prevent race conditionsGravatar Joseph Banks2020-05-01-6/+8
| | | | | | |
| | | * | | | Remove `PythonNews.channel` because this is unnecessaryGravatar ks1292020-05-06-2/+0
| | | | | | |
| | | * | | | Renamed `news.py` to `python_news.py` and `News` to `PythonNews` to avoid ↵Gravatar ks1292020-05-06-2/+2
| | | |/ / / | | | | | | | | | | | | | | | | | | confusion
| | | * | | Added ignoring maillist when no recent threads (this month) in `News` cogGravatar ks1292020-05-01-0/+4
| | | | | |
| | | * | | Added on cog unload news posting tasks canceling on `News` cogGravatar ks1292020-05-01-0/+5
| | | | | |
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-24 21:17:47 +0000