aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | * | | | | Properly handle cache being clearedGravatar Numerlor2021-01-23-13/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the code deleted the entry of all of the DocItems of the page after its contents were requested once, but this caused problems when the cache was cleared when it expired. Instead of deleting the entry to check if it should be queued on the next item request, we keep it and create an entry in the _item_futures dict for all items again and check for containment there. To avoid populating the queue multiple times with the same item in some cases the futures cleanup task will now only run when the queue is empty
| | * | | | | Merge remote-tracking branch 'upstream/master' into doc-impGravatar Numerlor2021-01-22-323/+1314
| | |\ \ \ \ \
| | * | | | | | Fix issues with multiple gets being suspended when a refresh startsGravatar Numerlor2021-01-22-6/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With a normal event, if multiple gets were suspended and a refresh started, we'd continue the refresh after the first get finished and set the event which would be the same behaviour as the one it tried to fix. This is avoided by using a counter that's incremented every time a context manager is entered around an event and only setting the event when that counter reaches a zero after everything exited the context mgr
| | * | | | | | Use inspect.unwrap instead of manually unwrappingGravatar Numerlor2021-01-21-3/+1
| | | | | | | |
| | * | | | | | Use a defaultdict for item futuresGravatar Numerlor2021-01-15-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To be able to set the attribute at the start of the coro we need to be able to access the item's future before we know about all the other items. This also saves us from having to add them all as the queue parser or get_markdown will create the futures for us dynamically
| | * | | | | | Prevent an inventory refresh while waiting for item cacheGravatar Numerlor2021-01-14-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an inventory refresh was started while the symbol embed coroutine was suspended, it could cause the parser to try to fetch a non existent future if the markdown was requested after it was cleared but before new inventories were loaded in.
| | * | | | | | Raise an error or log a warning if there's a global name conflictGravatar Numerlor2021-01-14-5/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When wrapper uses a global name, which conflicts with a global name from wrapped's module that wrapped uses for its annotations, we run into a situation that can't be solved without changing one of the names, so an error is raised to give this clearer meaning. The check may be erroneous in some edge cases or the objects the conflicting names refer to can be functionally identical, so the error can be turned into a logged warning.
| | * | | | | | Ensure footer is actually max 100 charsGravatar Numerlor2021-01-14-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Shortening the renamed symbols string to 100 chars is not accurate as the footer also contains a string before that, subtracting its length fixes this.
| | * | | | | | Set the user_requested attribute at the start of the coroutineGravatar Numerlor2021-01-14-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A context switch may occur when we're waiting for the web page response, during which a clear could be triggered. If the event is not set before that we could end up with the dictionary changing sizes, or if a copy was made, a future that'd never finish as it'd be cleared from the queue and the futures dict
| | * | | | | | Reuse the redis key instead of creating a new string for the expires setGravatar Numerlor2021-01-14-2/+2
| | | | | | | |
| | * | | | | | Change typehint name casing to PascalCaseGravatar Numerlor2021-01-14-8/+9
| | | | | | | |
| | * | | | | | Keep trakck of the init task and cancel it when the cog is unloadedGravatar Numerlor2021-01-14-1/+2
| | | | | | | |
| | * | | | | | Simplify control flowGravatar Numerlor2021-01-14-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| | * | | | | | Use different task ids for every inventory reschedule attemptsGravatar Numerlor2021-01-14-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The scheduler can't keep track of multiple tasks with the same id, and rescheduling the update task using the same id within an already scheduled update task caused the new task to get ignored as the old task only got deleted from the scheduler after it was finished
| | * | | | | | Correct return type annotationGravatar Numerlor2021-01-14-1/+1
| | | | | | | |
| | * | | | | | Turn update_single into a normal functionGravatar Numerlor2021-01-14-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The method no longer runs anything asynchronous
| | * | | | | | Fix docstringGravatar Numerlor2021-01-11-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decorator works in revers to what the docstring explained
| | * | | | | | Return whitespace to its previous stateGravatar Numerlor2021-01-11-1/+1
| | | | | | | |
| | * | | | | | Make REFRESH_EVENT an instance variableGravatar Numerlor2021-01-11-6/+6
| | | | | | | |
| | * | | | | | Merge remote-tracking branch 'upstream/master' into doc-impGravatar Numerlor2021-01-11-1234/+646
| | |\ \ \ \ \ \
| | * | | | | | | Remove old reference to CachedParser and unused constGravatar Numerlor2021-01-11-4/+1
| | | | | | | | |
| | * | | | | | | Check for containment instead of always getting the value from the dictGravatar Numerlor2021-01-11-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Getting the value from a defaultdict will always create the key for it, creating unnecessary entries every time a symbol is fetched from the bot
| | * | | | | | | Notify the user that inventories were refreshed on cache clearsGravatar Numerlor2021-01-11-1/+1
| | | | | | | | |
| | * | | | | | | Don't convert package names into lowercaseGravatar Numerlor2021-01-11-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The converter used to set them already ensures this for us, making the call redundant
| | * | | | | | | Ensure footer fits into messageGravatar Numerlor2021-01-11-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The footer also now says Moved: at the start to clarify the meaning of the symbols to the user
| | * | | | | | | Use a dictionary of lists instead of set for renamed symbolsGravatar Numerlor2021-01-11-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A dictionary allows us to grab the original symbol name and then get all the renamed symbols from it, with the improvements to `ensure_unique_symbol_name` we can also use lists instead of sets as each symbol we add should be unique
| | * | | | | | | Handle renaming conflicting symbols in ensure_unique_symbol_nameGravatar Numerlor2021-01-11-15/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously update_single looped this function until there were no duplicates and when creating new symbols the function had to check if the symbol to create a new name from started with a group/package to avoid redundancy. The new approach ensures a new symbol is always unique when returning by handling the containment check inside and outputting a symbol name in the format of package.group.symbol which should always be unique
| | * | | | | | | Update outdated docstringGravatar Numerlor2021-01-11-1/+1
| | | | | | | | |
| | * | | | | | | Send a message to devlog instead of logging a warningGravatar Numerlor2021-01-11-1/+30
| | | | | | | | |
| | * | | | | | | Resolve wrapped command callbacks in the source commandGravatar Numerlor2021-01-10-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this the command will fetch the source of the wrapper
| | * | | | | | | Create decorator for update_wrapper_globals mimicking functools.wrapsGravatar Numerlor2021-01-10-9/+30
| | | | | | | | |
| | * | | | | | | Change the func name to wrapped for clarityGravatar Numerlor2021-01-10-6/+6
| | | | | | | | |
| | * | | | | | | Rename CachedParser to BatchParser and move it to its own moduleGravatar Numerlor2021-01-10-166/+180
| | | | | | | | |
| | * | | | | | | Defer import to avoid circular importsGravatar Numerlor2021-01-10-1/+1
| | | | | | | | |
| | * | | | | | | Move functions strictly related to parsing html to the _html moduleGravatar Numerlor2021-01-10-120/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some constants need to be shared between html and parsing, because they may also be wanted to be edited by the cog user to change the behaviour, they were moved into the package's init.
| | * | | | | | | Expand docstringGravatar Numerlor2021-01-10-1/+6
| | | | | | | | |
| | * | | | | | | Bump markdownify to 0.6.1-0.6.*Gravatar Numerlor2021-01-10-10/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 0.6 release brought a new parameter that has to be included in all tag handling methods
| | * | | | | | | Set exception on futureGravatar Numerlor2021-01-10-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without the exception set, to the user the bot would fail silently if an exception was handled here
| | * | | | | | | Refresh inventories when the redis cache is clearedGravatar Numerlor2021-01-10-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because the futures are cleaned up and Markdown only exists in the cache after a short time, items that were requested previously and had the cache cleared would be missing from the CachedParser
| | * | | | | | | Handle equal DocItems in the queueGravatar Numerlor2021-01-10-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This could be handled by using sets to hold the items in _page_symbols, but ultimately the check has a much smaller cost than having thousands of sets for the urls. Because we create futures for every item that ends up in the queue we can also skip the .get is None check and instead fetch the future directly from the dict
| | * | | | | | | Stop scheduled and long running tasks on cog unloadGravatar Numerlor2021-01-10-0/+6
| | | | | | | | |
| | * | | | | | | Periodically clear unnecessary futures from the _item_futures dictGravatar Numerlor2021-01-10-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code has no way of reaching futures through new requests after their result has been set as that also includes setting its value in redis.
| | * | | | | | | Do not add package name to the front of the symbol if it's already thereGravatar Numerlor2021-01-09-2/+11
| | | | | | | | |
| | * | | | | | | Do not ignore symbols with slashes.Gravatar Numerlor2021-01-09-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some cases these are actual symbols that we can look up
| | * | | | | | | Ensure no symbols get overwritten while generating symbol mappingsGravatar Numerlor2021-01-09-19/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code handling this was moved to a function to achieve this cleanly. Includes fixes for bugs where incorrect package was added to the symbol name in the second branch and an incorrect symbol being added in the third branch Co-authored-by: MarkKoz <[email protected]>
| | * | | | | | | Do not attempt to set cache values for symbols that were not foundGravatar Numerlor2021-01-09-1/+2
| | | | | | | | |
| | * | | | | | | Remove redundant variableGravatar Numerlor2021-01-09-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| | * | | | | | | Add comments to truncation handling codeGravatar Numerlor2021-01-09-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| | * | | | | | | Use update_wrapper instead of wrapsGravatar Numerlor2021-01-09-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're not using it as a decorator so using wraps only complicates the call syntax
| | * | | | | | | Return the fetched inventory in the Inventory converterGravatar Numerlor2021-01-09-46/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of fetching it again in the cog, the converter now returns the inventory for later use. The set command now no longer attempts to reschedule the inventory, and a bug that caused the inventory rescheduling to do nothing in `update_single` was fixed after moving it to its own method
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-26 11:50:20 +0000