aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | * | | | | Set future result to None on exceptionsGravatar Numerlor2021-03-05-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can still provide th user with at least the link to the docs, for which we already have handling in the cog with a generic "unable to parse message", using exceptions for that would mean setting it here, immediately catching it and then providing the same or very similar message.
| | * | | | | Correct typehintGravatar Numerlor2021-03-05-2/+2
| | | | | | |
| | * | | | | Move future assignment and check outside of the tryGravatar Numerlor2021-03-05-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No exceptions can be raised from the two lines of code because of the data structures used, moving it out makes for flatter code.
| | * | | | | Rename params to clearer and more concise alternativesGravatar Numerlor2021-03-05-6/+6
| | | | | | |
| | * | | | | Explain use of various containers in the cogGravatar Numerlor2021-03-05-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| | * | | | | Use placeholder consistent with others in the cogGravatar Numerlor2021-03-05-1/+1
| | | | | | |
| | * | | | | Add comments to the parsing moduleGravatar Numerlor2021-03-05-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| | * | | | | Account for ellipses when determining the truncation description indexGravatar Numerlor2021-03-05-3/+3
| | | | | | |
| | * | | | | Remove placeholder in shorten callGravatar Numerlor2021-03-05-1/+1
| | | | | | |
| | * | | | | Use clearer branchingGravatar Numerlor2021-03-05-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| | * | | | | Add comments for purpose of DocItem attributesGravatar Numerlor2021-03-05-5/+5
| | | | | | |
| | * | | | | Do _item_futures cleanup in _parse_queue instead of a concurrent taskGravatar Numerlor2021-03-05-33/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The doc_cache coro was changed to be awaited directly instead of creating a task to ensure the cache is populated before the item is deleted
| | * | | | | Set the result of the future instead of an exception when avaialbleGravatar Numerlor2021-03-05-1/+5
| | | | | | |
| | * | | | | Do not set redis results in get_symbol_embedGravatar Numerlor2021-03-05-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The redis results are already being set in the BatchParser for all symbols
| | * | | | | Typo and docstring style changesGravatar Numerlor2021-03-05-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]> fixup! Docstring typos and style changes
| | * | | | | Move the seconds of a week timedelta into a constantGravatar Numerlor2021-03-05-1/+3
| | | | | | |
| | * | | | | Use deque instead of a listGravatar Numerlor2021-03-05-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As we extend the left side of a list now, using a deque that provides a direct method for it is more fitting. fixup! Use deque instead of a list
| | * | | | | Use common check for early exitGravatar Numerlor2021-03-05-11/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces a possibly redundant check for the doc_item being None but results in flatter code with less duplication
| | * | | | | Add new symbols to front of queue instead of extending the endGravatar Numerlor2021-02-28-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using extend caused old items, including the ones that were requested by users and pushed to the front, to be pushed back by all of the items on the new page, possibly significantly delaying their parsing
| | * | | | | Add digits to package covnerterGravatar Numerlor2021-02-27-2/+2
| | | | | | |
| | * | | | | Get the last index instead of using maxGravatar Numerlor2021-02-27-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The last index will always be the largest one so there's no need for max to search for it
| | * | | | | Use 4 spaces for hanging indentGravatar Numerlor2021-02-24-19/+19
| | | | | | |
| | * | | | | Allow wildcard match for clear cache commandGravatar Numerlor2021-02-24-3/+7
| | | | | | |
| | * | | | | Update docstringsGravatar Numerlor2021-02-23-2/+2
| | | | | | |
| | * | | | | Remove redundant group checkGravatar Numerlor2021-02-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As we check for non dt symbol names to be sure in case something pops up , we can skip the initial group check as all the symbols from those groups should point to non dt tags.
| | * | | | | Correct length adjustmentGravatar Numerlor2021-02-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the placeholder contains a space and is actually 4 chars because of that with a comma that adds up to 5 characters in the signature instead of 4
| | * | | | | Add unittests for _split_signatureGravatar Numerlor2021-02-23-0/+59
| | | | | | |
| | * | | | | Add lt and gt angle brackets to bracket pairsGravatar Numerlor2021-02-23-0/+1
| | | | | | |
| | * | | | | Add deletedoccache alias to the clear cache commandGravatar Numerlor2021-02-23-1/+1
| | | | | | |
| | * | | | | cleanup->clean_upGravatar Numerlor2021-02-23-2/+2
| | | | | | |
| | * | | | | Remove unnecessary commentsGravatar Numerlor2021-02-23-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The comments explain things that should be clear, or basic concepts
| | * | | | | Use "inventories" when referring to the cog's collection of sphinx invsGravatar Numerlor2021-02-23-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously in some context inventory referred both to a single "inventory" that we got from a remote objects.inv and to the internal cog inventories. Always referring to the cog's inventories as plural The update_single docstring was also changed from rebuild to build, as the method doesn't handle anything with a preexisting inventory with the same symbols being in the cog's inventories
| | * | | | | Simplify conditionGravatar Numerlor2021-02-23-1/+1
| | | | | | |
| | * | | | | Simplify the _split_parameters implementationGravatar Numerlor2021-02-23-30/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The main simplification was getting rid of keeping track of string depth which was unnecessary, as we can just always skip them as was being done for strings inside of brackets. The branching was also simplified to make sure less unnecessary checks were being done with a bit less confusing elifs.
| | * | | | | Fix docstring typosGravatar Numerlor2021-02-23-10/+10
| | | | | | |
| | * | | | | Remove unnecessary use of partialGravatar Numerlor2021-02-05-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | run_in_executor can provide args to the func it's passed in, making the use of partial unnecessary. This will also make it more convenient to move to asyncio.to_thread when the codebase is switched to python 3.9
| | * | | | | Avoid from import on _batch_parserGravatar Numerlor2021-02-03-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tests import the modules the other way around causing a circular import
| | * | | | | Use create_task utilGravatar Numerlor2021-02-03-2/+3
| | | | | | |
| | * | | | | Create a task for setting the redis result instead of awaitingGravatar Numerlor2021-02-03-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The queue parsing doesn't depend on anything with redis, so the await only delays the result being set on the future.
| | * | | | | Move BeautifulSoup parsing into an executorGravatar Numerlor2021-02-03-1/+4
| | | | | | |
| | * | | | | Remove url lockGravatar Numerlor2021-02-03-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The items are added to the futures dict before a context switch can occur, making the subsequent requests to the url skip the queue extend and suspend at the future await
| | * | | | | Use more consistent naming for doc items and symbolsGravatar Numerlor2021-02-03-71/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Trailing commas were also added where missing
| | * | | | | Import module directly to avoid circular dependency and use of typeGravatar Numerlor2021-02-03-13/+11
| | | | | | |
| | * | | | | Attempt to resolve first part of the argument in case of a failed lookupGravatar Numerlor2021-02-02-2/+12
| | | | | | |
| | * | | | | Require a set of names to ignore instead of a blanket ignoringGravatar Numerlor2021-01-30-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As work is done on the modules the wrapper and wrapped functions are in more conflicts can occur, previously this could be missed as the info log that was done in case the error was suppressed was done when modules were being initialized during which there is a logging spam.
| | * | | | | Cancel current task inside coro to not keep track of attempts manuallyGravatar Numerlor2021-01-23-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The scheduler shields the coroutine from cancellation so we can cancel the scheduler's tasks inside of it to avoid the error from multiple tasks with the same id trying to be scheduled which the manual tracking of attempts solved Co-authored-by: MarkKoz <[email protected]>
| | * | | | | Wrap whole string in shortenGravatar Numerlor2021-01-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helps avoid subtracting the length of "Moved: " from the shorten index Co-authored-by: MarkKoz <[email protected]>
| | * | | | | Avoid errors when the first element is longer than the truncation indexGravatar Numerlor2021-01-23-3/+10
| | | | | | |
| | * | | | | lock markdownify version to 0.6.1Gravatar Numerlor2021-01-23-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the 0.6.3 update brought a change that fails to ignore newlines in the html, introducing unnecessary lines into the output
| | * | | | | Create a namespace varGravatar Numerlor2021-01-23-8/+9
| | | | | | |