aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | * | | | | | Fix valid token regex testGravatar MarkKoz2020-05-25-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was broken due to the addition of groups. Rather than returning the full match, `findall` returns groups if any exist. The test was comparing a tuple of groups to the token string, which was of course failing. Now `fullmatch` is used cause it's simpler - just check for `None` and don't worry about iterating matches to search.
| | * | | | | | Add more valid tokens to test the regex withGravatar MarkKoz2020-05-25-3/+5
| | | | | | | |
| | * | | | | | Test token regex won't match non-base64 charactersGravatar MarkKoz2020-05-25-4/+3
| | | | | | | |
| | * | | | | | Token remover: specify Discord epoch in secondsGravatar MarkKoz2020-05-25-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The timestamp in the token is in seconds and is being compared against the epoch. To make life easier, they should use the same unit. Previously, the epoch was in milliseconds.
| | * | | | | | Token remover: use finditer instead of findallGravatar MarkKoz2020-05-25-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It makes more sense to use the lazy function when the loop is already short-circuiting on the first valid token it finds.
| | * | | | | | Token remover: use regex groups and pass the token as a NamedTupleGravatar MarkKoz2020-05-25-27/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It felt redundant to be splitting the token in two different functions when regex could take care of this from the outset. ' A NamedTuple was created to house the token. This is nicer than passing an re.Match object, because it's clearer which attributes are available. Even if the regex used named groups, it wouldn't be as obvious which group names exist. Without the split, `is_maybe_token` is dwindled down to a redundant function. Therefore, it's been removed.
| | * | | | | | Token remover: escape dashes in regexGravatar MarkKoz2020-05-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They need to be escaped when they're in a character set. By default, they are interpreted as part of the character range syntax.
| | * | | | | | Token remover: match only base64 in regexGravatar MarkKoz2020-05-21-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Making the regex more accurate reduces false positives at an earlier stage. There's no benefit to matching non-base64 as that would just be weeded out as invalid at a later stage anyway when it tries to decode it.
| | * | | | | | Token remover: decode ID using URL-safe base64Gravatar MarkKoz2020-05-21-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Though I've not seen an ID with neither + and \ nor - and _, given that the timestamp uses URL-safe encoding, the ID probably does too.
| | * | | | | | Add a utility function to pad base64 dataGravatar MarkKoz2020-05-16-2/+8
| | | | | | | |
| | * | | | | | Token remover: use strict check for digits in token IDGravatar MarkKoz2020-05-15-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `isnumeric` would be true for a wide range of characters in Unicode, but the ID must only consist of the characters 0-9 (ASCII digits). In fact, `isdigit` on its own would also match other Unicode characters too.
| | * | | | | | Token remover: fix timestamp checkGravatar MarkKoz2020-05-14-10/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The timestamp calculation was incorrect. The bytes need to be interpreted as big-endian and the result is just a timestamp rather than a snowflake.
| | * | | | | | Token remover: add logs to clarify why token is invalidGravatar MarkKoz2020-05-13-2/+4
| | | | | | | |
| | * | | | | | Add missing comma to token remover log messageGravatar MarkKoz2020-05-13-1/+1
| | | | | | | |
| | * | | | | | Fix a test needlessly being a coroutineGravatar MarkKoz2020-05-13-1/+1
| | | | | | | |
| | * | | | | | Use subtests for valid ID/timestamp tests and test non-ASCII inputsGravatar MarkKoz2020-05-11-18/+25
| | | | | | | |
| | * | | | | | Clean up token remover test importsGravatar MarkKoz2020-05-11-16/+12
| | | | | | | |
| | * | | | | | Replace deprecated assertion methodsGravatar MarkKoz2020-05-11-2/+2
| | | | | | | |
| | * | | | | | Refactor `TokenRemoverSetupTests` and add a more thorough testGravatar MarkKoz2020-05-11-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test now ensures the cog is instantiated and that the instance is passed as an argument to `add_cog`.
| | * | | | | | Test TokenRemover.take_actionGravatar MarkKoz2020-05-11-43/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove `bot.get_cog` mocks in `setUp` * Mock the logger cause it's easier to assert logs * Remove subtests * Assert helper functions were called * Create an autospec for ModLog
| | * | | | | | Test TokenRemover.format_log_messageGravatar MarkKoz2020-05-11-0/+16
| | | | | | | |
| | * | | | | | Test token remover's message deletionGravatar MarkKoz2020-05-11-0/+9
| | | | | | | |
| | * | | | | | Simplify token remover's message mockGravatar MarkKoz2020-05-11-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rely on default values for the author * Set the content to a non-empty string
| | * | | | | | Avoid instantiating the cog when testing static/class methodsGravatar MarkKoz2020-05-11-10/+5
| | | | | | | |
| | * | | | | | Token remover: use a string template for the log messageGravatar MarkKoz2020-05-11-4/+11
| | | | | | | |
| | * | | | | | Token remover: split some of `take_action` into separate functionsGravatar MarkKoz2020-05-11-11/+21
| | | | | | | |
| | * | | | | | Correct the return type annotation for the autospec decoratorGravatar MarkKoz2020-05-11-2/+2
| | | | | | | |
| | * | | | | | Test token regex matches valid tokensGravatar MarkKoz2020-05-11-0/+21
| | | | | | | |
| | * | | | | | Test is_maybe_tokenGravatar MarkKoz2020-05-11-7/+24
| | | | | | | |
| | * | | | | | Token remover: fix `is_maybe_token` returning None instead of FalseGravatar MarkKoz2020-05-11-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's annotated as returning a bool and when the split fails it already returns False. To be consistent, it should always return a bool.
| | * | | | | | Test `is_maybe_token` returns False for missing partsGravatar MarkKoz2020-05-11-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In practice, this won't ever happen since the regex wouldn't match strings with missing parts. However, the function does check it so may as well test it. It's not necessarily bound to always use inputs from the regex either I suppose.
| | * | | | | | Fix autospec decorator when used with multiple attributesGravatar MarkKoz2020-05-11-16/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original approach of messing with the `attribute_name` didn't work for reasons I won't discuss here (would require knowledge of patcher internals). The new approach doesn't use patch.multiple but mimics it by applying multiple patch decorators to the function. As a consequence, this can no longer be used as a context manager.
| | * | | | | | Test token regex doesn't match invalid tokensGravatar MarkKoz2020-05-11-7/+25
| | | | | | | |
| | * | | | | | Test `find_token_in_message` returns the found tokenGravatar MarkKoz2020-05-11-0/+24
| | | | | | | |
| | * | | | | | Test `find_token_in_message` returns None if no matches foundGravatar MarkKoz2020-05-11-0/+14
| | | | | | | |
| | * | | | | | Fix test for token remover ignoring bot messagesGravatar MarkKoz2020-05-11-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's not possible to test this via asserting the return value of `on_message` since it never returns anything. Instead, the actual relevant unit, `find_token_in_message,` should be tested.
| | * | | | | | Allow using arbitrary parameter names with the autospec decoratorGravatar MarkKoz2020-05-11-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives the caller more flexibility. Sometimes attribute names are too long or they don't follow a naming scheme accepted by the linter.
| | * | | | | | Test token remover skips messages without tokensGravatar MarkKoz2020-05-11-0/+11
| | | | | | | |
| | * | | | | | Test token remover takes action if a token is foundGravatar MarkKoz2020-05-11-1/+13
| | | | | | | |
| | * | | | | | Add a test helper function to patch multiple attributes with autospecsGravatar MarkKoz2020-05-11-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helper reduces redundancy/boilerplate by setting default values. It also has the consequence of shortening the length of the invocation, which makes it faster to use and easier to read.
| | * | | | | | Test on_message_edit of token remover uses on_messageGravatar MarkKoz2020-05-11-2/+10
| | | | | | | |
| | * | | | | | Token remover: reduce duplicated code in `on_message_edit`Gravatar MarkKoz2020-05-11-3/+1
| | | | | | | |
| | * | | | | | Token remover: catch ValueError when non-ASCII chars are presentGravatar MarkKoz2020-05-11-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The token uses base64 and base64 only allows ASCII characters. Thus, if a match has non-ASCII characters, it's not a valid token. Catching the ValueError is simpler than trying to adjust the regex to only match valid base64. Fixes #928 Fixes BOT-3X
| * | | | | | | Merge pull request #978 from ItsDrike/unsilence-schedulerGravatar Mark2020-06-12-10/+45
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Use Scheduler instead of asyncio.sleep on silence cog
| | * | | | | | | Use class instead of NamedTupleGravatar ItsDrike2020-06-06-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Using a class is more readable than using a NamedTuple
| | * | | | | | | Test for channel not silenced messageGravatar ItsDrike2020-06-06-4/+14
| | | | | | | | |
| | * | | | | | | Change `is` to `was` for unsilenced channel messageGravatar ItsDrike2020-06-06-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - As suggested, `was` is more fitting in the message than `is`
| | * | | | | | | Move cancel_task before notifier.remove_channelGravatar ItsDrike2020-06-06-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - as sugested notifier.remove_channel and muted_channels.discard should be together
| | * | | | | | | Do not await self.schedule_taskGravatar ItsDrike2020-06-06-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - self.schedule_task shouldn't be awaited as it isn't a coroutine
| | * | | | | | | Remove unnecessary schedule_unsilenceGravatar ItsDrike2020-06-06-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - As suggested, this function is not necessary - Also fixed no longer valid`stop`in SilencedChannel NamedTuple
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-29 12:35:36 +0000