aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| * | | | | | | Address review comments from MarkGravatar Joseph Banks2020-04-11-14/+3837
| | | | | | | |
| * | | | | | | StatsD integrationGravatar Joseph Banks2020-04-11-34/+145
| |/ / / / / /
| | * | | | | (Syncer Tests): Replaced wrong side effectGravatar ks1292020-04-09-1/+2
| | | | | | | | | | | | | | | | | | | | | Replaced `TimeoutError` with `asyncio.TimeoutError`.
| | * | | | | (Syncers): Fixed wrong except statementGravatar ks1292020-04-09-1/+2
| | | | | | | | | | | | | | | | | | | | | Replaced `TimeoutError` with `asyncio.TimeoutError`.
| | | * | | | HelpChannels: ensure `is_in_category` returns a boolGravatar Mark2020-04-17-1/+1
| | | | | | | | | | | | | | | | | | | | | Co-Authored-By: kwzrd <[email protected]>
| | | * | | | HelpChannels: create helper method for checking channel's categoryGravatar MarkKoz2020-04-11-4/+8
| | | | | | |
| | | * | | | HelpChannels: create a helper method for checking a channGravatar MarkKoz2020-04-11-2/+4
| |_|/ / / / |/| | | | |
| | | * | | Tags: explicitly use UTF-8 to read filesGravatar MarkKoz2020-04-10-1/+1
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | Not all operating systems use UTF-8 as the default encoding. For systems that don't, reading tag files with Unicode would cause an unhandled exception.
* | | | | Stop setting positions when moving help channelsGravatar Sebastiaan Zeeff2020-04-08-2/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | Unfortunately, trying to set positions for the help channels during their move from one category to another does not work to well. It introduces a number of glitches and we haven't been able to reliably get a channel to go to a specific position either. This commit simply removes any attempt to set a position and lets Discord handle it.
* | | | Merge pull request #873 from ↵Gravatar Sebastiaan Zeeff2020-04-07-6/+51
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | python-discord/mitigate-permission-unsynchronization-available-help-channels Mitigate available help channels failing to synchronize their permissions
| * | | | Ensure available help channels sync their permissionsGravatar Sebastiaan Zeeff2020-04-07-3/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The help channels in the `Help: Available` category should automatically synchronize their permissions with the category permissions to ensure that the overwrites we use to prevent people from claiming multiple help channels are properly enforced. Unfortunately, for unknown reasons, they sometimes get in an "out of sync" state that requires intervention to get them back in sync. This PR mitigates that issue by checking the available channel for their synchronisation status during certain critical times in our help channel system: 1. Whenever the overwrites for the category change 2. Whenever a channel is moved into the new category 3. After the categories have been reset during the initialization process The check is straightforward: The `ensure_permissions_synchronization` method iterates over all the channels in the category and checks if the channels are currently synchronizing their permissions. If not, we remedy that by making a channel edit request to the Discord API. If all channels were already "in sync", no API calls are made. The latter should make this an inexpensive mitigation procedure: As we typically have very few channels in the available category and channels mostly stay in sync, we typically do very little. To make this process a bit easier, I've factored out `set_permissions` calls to a helper function that also calls the `ensure_permissions_synchronization` method. The only exception is during the reset process: As we may edit multiple permissions in this loop, it's better to only ensure the synchronization after we're done with all permission changes.
| * | | | Change help available embed to use occupied termGravatar Sebastiaan Zeeff2020-04-07-3/+3
|/ / / / | | | | | | | | | | | | The embed displayed in available help channels still used the term "in use" instead of "occupied". I've updated the embed to reflect the new name of the "occupied" category.
* | | | Merge pull request #871 from ↵Gravatar Sebastiaan Zeeff2020-04-07-20/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | python-discord/help-channel-system-minor-improvements Add status emojis to help channels and improve bottom sorting
| * | | | Set the ID of the new Help: In Use categoryGravatar Sebastiaan Zeeff2020-04-07-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As Discord is having a rather persistent issue with one of the channels in the current `Help: In Use` category, we're going to start using a new category that excludes the old channel. The old channel, help-argon, appears to be completely broken on Discord's end, resulting in "Not found" errors for any kind of interaction, including channel move and/or channel delete admin actions. As it's still visible, it's currently triggering a lot questions from our members. We hope that using a new category will fix that.
| * | | | Use clean help channel name for used name setGravatar Sebastiaan Zeeff2020-04-06-1/+1
| | | | | | | | | | | | | | | | | | | | The set that keeps track of the used channel names should discard emojis. To do that, I'm cleaning the names before they're added to the set of channel names.
| * | | | Use configurable prefix to clean help channel namesGravatar Sebastiaan Zeeff2020-04-06-3/+4
| | | | | | | | | | | | | | | | | | | | The help channel prefix is configurable as a constant, but I accidentally used a static prefix in the utility function that cleaned the channel names. This commit makes sure the utility method uses the prefix defined in the constants.
| * | | | Change bottom sorting strategy to using a large intGravatar Sebastiaan Zeeff2020-04-06-21/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current approach of trying to find the maximum channel position, adding one, and using that as the position integer for channels does not seem to work reliably. An approach that seems to work in the testing environment is using a very large integer for the position attribute of the channel: It wil be sorted at the bottom and Discord will automatically scale the integer down to `max + 1`. This also means the `get_position` utility function is no longer needed; it has been removed.
| * | | | Add channel status emoji to help channelsGravatar Sebastiaan Zeeff2020-04-06-0/+22
|/ / / / | | | | | | | | | | | | | | | | | | | | I've added channel status emojis as a prefix to our help channels to make it more obvious to the end user what the current status of a channel is. All channels in the Available category will be marked with a green checkmark emoji, while all channels in the In Use category will be marked with an hourglass. Channels in the Dormant category stay unadorned. Channels will be stripped of their previous prefix when moved to another category. This relies on the `help-` naming convention, as that is the most reliable way to do it that does not break if we ever opt for another emoji.
* | | | Change help channel sorting to bottom positionGravatar Sebastiaan Zeeff2020-04-05-17/+6
| | | | | | | | | | | | | | | | The current sorting algorithm we used created unpredictable channel order (for our human end-users) and induced a flickering channel light-show in Discord clients. To combat these undesirable side-effects, I've changed the ordering to always order channels at the bottom of a category. This also means that channels looking for answers the longest will naturally float up.
* | | | Merge pull request #786 from python-discord/feat/frontend/o200/help-channelsGravatar Joseph2020-04-05-145/+887
|\ \ \ \ | |/ / / |/| | | Implement a new help channel system
| * | | Merge branch 'master' into feat/frontend/o200/help-channelsGravatar Joseph2020-04-05-316/+906
| |\ \ \ | |/ / / |/| | |
* | | | Merge pull request #813 from python-discord/feat/ci/b000/cache-pipenvGravatar Mark2020-04-02-10/+29
|\ \ \ \ | | | | | | | | | | Cache all Python dependencies in CI
| * \ \ \ Merge branch 'master' into feat/ci/b000/cache-pipenvGravatar Mark2020-04-02-446/+2002
| |\ \ \ \ | |/ / / / |/| | | |
* | | | | Fixed missed rename for token removal method name changeGravatar S. Co12020-04-02-1/+1
| | | | |
* | | | | Merge pull request #832 from python-discord/fix-token-strip-logGravatar Shirayuki Nekomata2020-04-02-12/+18
|\ \ \ \ \ | | | | | | | | | | | | Update token filter logging to match expanded detection
| * \ \ \ \ Merge branch 'master' into fix-token-strip-logGravatar Shirayuki Nekomata2020-04-02-346/+982
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Add TCD to whitelistGravatar Leon Sandøy2020-04-01-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | The Coding Den is a language agnostic community that's been around for years with over 12000 members. I think we can allow that invite in our community.
| * | | | | Clarify docstring for token check functionGravatar S. Co12020-03-23-1/+1
| | | | | | | | | | | | | | | | | | Co-Authored-By: Mark <[email protected]>
| * | | | | Update token filter logging to match expanded detectionGravatar S. Co12020-03-20-12/+18
| | | | | | | | | | | | | | | | | | | | | | | | Log message still used the first regex result (re.search) rather than the expanded approach (re.findall) recently added.
| | * | | | CI: remove support for partial cache hitsGravatar MarkKoz2020-03-25-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Partial hits may cause issues when packages get removed. The cache will get bloated with packages which are no longer needed. They will keep accumulating as more packages get removed unless the cache is unused for 7 days and gets automatically deleted by Azure Pipelines. Lingering packages are also a potential cause for conflicts (e.g. unused package x depends on package y==4.0 and useful package z depends on y==5.0). Removing support for partial hits means all dependencies will be installed whenever a single dependency changes.
| | * | | | CI: rename UsePythonVersion taskGravatar MarkKoz2020-03-11-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | "python" is a shorter and clearer name.
| | * | | | CI: don't do a user install for pre-commit venvGravatar MarkKoz2020-03-09-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents the following error: Can not perform a '--user' install. User site-packages are not visible in this virtualenv.
| | * | | | CI: install pipenv to user siteGravatar MarkKoz2020-03-09-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some of pipenv's dependencies overlap with dependencies in the Pipfile. When installing from the Pipfile, any dependencies already present in the global site will not be installed again to the user site, and thus will not be cached. Therefore, pipenv is installed to the user site to ensure all dependencies get cached. * Move PATH prepend step before pipenv invocation
| | * | | | CI: invalidate cachesGravatar MarkKoz2020-03-09-6/+6
| | | | | |
| | * | | | CI: prepend py user base to PATHGravatar MarkKoz2020-03-09-0/+3
| | | | | |
| | * | | | CI: cache the Python user base dirGravatar MarkKoz2020-03-09-3/+5
| | | | | |
| | * | | | CI: cache Python dependenciesGravatar MarkKoz2020-03-09-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reduces frequency of using pipenv to install dependencies in CI. Works by caching the entire Python directory. Only a full cache hit will skip the pipenv steps; a partial cache hit will still be followed by using pipenv to install from the pipfiles. * Disable pip cache
| | * | | | CI: make env vars used for coverage into pipeline variablesGravatar MarkKoz2020-03-09-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | Makes the script for the coverage step cleaner.
| | | * | | Add close alias for dormant commandGravatar Joseph Banks2020-04-05-1/+1
| | | | | |
| | | * | | Reduce span of hyperlink in AVAILABLE_MSG and DORMANT_MSGGravatar Joseph Banks2020-04-05-2/+2
| | | | | |
| | | * | | HelpChannels: set to enabled by defaultGravatar MarkKoz2020-03-30-1/+1
| | | | | |
| | | * | | ModLog: ignore update channel events for help channelsGravatar MarkKoz2020-03-30-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The edit causes two channel update events to dispatch simultaneously: one for the channel topic changing and one for the category changing. The ModLog cog currently doesn't support ignoring multiple events of the same type for the same channel. Therefore, the ignore was hard coded rather than using the typical ignore mechanism. This is intended to be a temporary solution; it should be removed once the ModLog is changed to support this situation.
| | | * | | HelpChannels: use constant names instead of default values in docstringGravatar MarkKoz2020-03-30-6/+5
| | | | | |
| | | * | | HelpChannels: fix typos in docstringsGravatar Mark2020-03-30-2/+2
| | | | | | | | | | | | | | | | | | Co-Authored-By: Leon Sandøy <[email protected]>
| | | * | | HelpChannels: fix typo in docstringGravatar MarkKoz2020-03-29-1/+1
| | | | | |
| | | * | | BotCog: fix AttributeError getting a category for a DMChannelGravatar MarkKoz2020-03-29-1/+1
| | | | | |
| | | * | | HelpChannels: remove positions from element namesGravatar MarkKoz2020-03-29-127/+125
| | | | | | | | | | | | | | | | | | | | | | | | There is no longer a reliance on static alphabetical position numbers.
| | | * | | HelpChannels: fix alphabetical sorting of dormant channelsGravatar MarkKoz2020-03-29-13/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a channel is moved, all channels below have their positions incremented by 1. This threw off the previous implementation which relied on position numbers being static. Co-authored-by: Sebastiaan Zeeff <[email protected]>
| | | * | | Constants: add a config value to toggle help channels extensionGravatar MarkKoz2020-03-22-6/+10
| | | | | |
| | | * | | HelpChannels: mention the helper notifications in cog docstringGravatar MarkKoz2020-03-22-0/+1
| | | | | |
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-28 19:22:10 +0000