aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Reminders: Simplify helper function to get button embedGravatar hedy2024-03-27-25/+11
| | | | | | | | This removes the need of any form of error handling from `embeds` list indexing, and makes the code more concise and readable. The drawback is that a whole new embed object have to be allocated each time, rather than editing the description like before.
* Reminders: Refactor all opt-in button related logic into View classGravatar hedy2024-03-26-41/+37
| | | | | - More resilient handling of API errors. - Don't rely on string manipulation to disable the button.
* Reminders: More robust implementation of mention opt-in buttonGravatar hedy2024-03-25-89/+131
| | | | | | | | | | | | | | | | | | | | | | | | | This solves most, if not all issues from the previous commit. - A timeout of 5 minutes is enforced - this means the button can no longer be used either when the reminder arrives or 5 minutes passes since creation, whichever comes first. - Reminder edits in between creation and button clicks will be handled responsibly - This includes both edits of duration, mentions, and deleting reminders altogether. - UX is improved. This list of to-be-mentioned users is sent up-front with the author included. Instructions to click the button comes right after the list. - No updates to the API or site schema required, as the button message will disable itself when it encounters any sort of errors. - Implementation is also somewhat simplified. There are probably more improvements, maybe one caveat, but it's like almost midnight and I want to sleep :/ I sure hope the list above covers most of it. Further testing will be done. Now `.remind 10s test` is ingrained in my muscle memory...
* Reminders: Add a button for others to opt-in to a pingGravatar hedy2024-03-24-7/+130
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the initial implementation - it's currently _far_ from perfect and is very susceptible to errors. Notable features beyond the basic requirements: - Fails safely when max mentions reached (we're limited by the 2000-character limit when sending the reminder with the pings), and disables the button. - Adds an additional embed to the initial confirmation message to show who clicked on the notify button. - Edits the additional embed and disables the button when the reminder is sent. In many ways, this implementation is quite bad: - Uses an async callback to delegate the task of PATCH-ing the API to edit mentions to the `new_reminders` method. - Edits to the opt-in list embed relies on the fact that the reminder is not edited (using !remind edit) before someone clicks on the button. A trivial way to fix this would be to add another field to the site schema to store the `notification_view` in some way. - The button is neither disabled nor any edits to the embed made when the reminder is deleted before someone clicks on the button. - String splitting is used which relies on the exact format of the embed message when editing the embed to disable the button. We have to reminder to update this piece of code when adjusting its format in the future. The UX can also be improved. Currently, I can't think of a way to concisely phrase the button embed message so that it is clear that the button is for people _other than_ the reminder author. Notes: - Max reminder mentions: - Mentions are pinged directly in a discord message when the reminder is sent. This means we're limited by the 2000-char limit. If we take each User ID snowflake to be 18-characters, and considering each mention to be formated as "<@ID> " (with extra space), it results in about 90 mentions max. I've set the constant to 80 just in case. - This is not an issue when the mentions are added in through other means than the button we're adding in this commit, because the user has to use @-mentions when sending the `!remind edit` command, which is already under the discord's character limit. - Log messages are added when something unexpected occurs within the code. Hopefully this is unlikely to happen after the implementation issues listed above are solved. - The opt-in list in the second embed is separate from mentions added in the original reminder creation, or any further edits, because mentions are added by the to-be-mentioned-user, rather than by the reminder author in this way. (Even though they are stored the same way.)
* Merge pull request #2966 from python-discord/dependabot/pip/ruff-0.3.4Gravatar Amrou Bellalouna2024-03-22-20/+20
|\ | | | | Bump ruff from 0.3.3 to 0.3.4
| * Bump ruff from 0.3.3 to 0.3.4Gravatar dependabot[bot]2024-03-22-20/+20
|/ | | | | | | | | | | | | | | Bumps [ruff](https://github.com/astral-sh/ruff) from 0.3.3 to 0.3.4. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](https://github.com/astral-sh/ruff/compare/v0.3.3...v0.3.4) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Bump rapidfuzz from 3.6.1 to 3.6.2 (#2945)Gravatar dependabot[bot]2024-03-21-93/+93
| | | | | | | | | | | | | | | | Bumps [rapidfuzz](https://github.com/rapidfuzz/RapidFuzz) from 3.6.1 to 3.6.2. - [Release notes](https://github.com/rapidfuzz/RapidFuzz/releases) - [Changelog](https://github.com/rapidfuzz/RapidFuzz/blob/main/CHANGELOG.rst) - [Commits](https://github.com/rapidfuzz/RapidFuzz/compare/v3.6.1...v3.6.2) --- updated-dependencies: - dependency-name: rapidfuzz dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update configuration tests (#2951)Gravatar Amrou Bellalouna2024-03-21-38/+28
| | | The old test relied on the old system where we loaded config from a yaml file, which ended up doing nothing.
* Bump tldextract from 5.1.1 to 5.1.2 (#2962)Gravatar dependabot[bot]2024-03-21-6/+7
| | | | | | | | | | | | | | | | Bumps [tldextract](https://github.com/john-kurkowski/tldextract) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/john-kurkowski/tldextract/releases) - [Changelog](https://github.com/john-kurkowski/tldextract/blob/master/CHANGELOG.md) - [Commits](https://github.com/john-kurkowski/tldextract/compare/5.1.1...5.1.2) --- updated-dependencies: - dependency-name: tldextract dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* New Tag: "Avoid System Python for Development" (#2797)Gravatar Bruno Rodrigues dos Santos2024-03-21-0/+18
|
* Bump azure/k8s-deploy from 4 to 5 (#2965)Gravatar dependabot[bot]2024-03-21-1/+1
| | | | | | | | | | | | | | | | Bumps [azure/k8s-deploy](https://github.com/azure/k8s-deploy) from 4 to 5. - [Release notes](https://github.com/azure/k8s-deploy/releases) - [Changelog](https://github.com/Azure/k8s-deploy/blob/main/CHANGELOG.md) - [Commits](https://github.com/azure/k8s-deploy/compare/v4...v5) --- updated-dependencies: - dependency-name: azure/k8s-deploy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Merge pull request #2958 from python-discord/dependabot/pip/coverage-7.4.4Gravatar Amrou Bellalouna2024-03-21-55/+55
|\ | | | | Bump coverage from 7.4.3 to 7.4.4
| * Bump coverage from 7.4.3 to 7.4.4Gravatar dependabot[bot]2024-03-20-55/+55
|/ | | | | | | | | | | | | | | Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.4.3 to 7.4.4. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](https://github.com/nedbat/coveragepy/compare/7.4.3...7.4.4) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Bump sentry-sdk from 1.42.0 to 1.43.0 (#2964)Gravatar dependabot[bot]2024-03-20-5/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ruff from 0.3.2 to 0.3.3 (#2961)Gravatar dependabot[bot]2024-03-19-20/+20
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Merge pull request #2953 from python-discord/dependabot/pip/pytest-8.1.1Gravatar Amrou Bellalouna2024-03-14-5/+5
|\ | | | | Bump pytest from 8.1.0 to 8.1.1
| * Bump pytest from 8.1.0 to 8.1.1Gravatar dependabot[bot]2024-03-14-5/+5
|/ | | | | | | | | | | | | | | Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.1.0 to 8.1.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pytest-dev/pytest/compare/8.1.0...8.1.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Bump sentry-sdk from 1.41.0 to 1.42.0 (#2957)Gravatar dependabot[bot]2024-03-14-5/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump azure/setup-kubectl from 3 to 4 (#2956)Gravatar dependabot[bot]2024-03-13-1/+1
| | | | | | | | | | | | | | | | Bumps [azure/setup-kubectl](https://github.com/azure/setup-kubectl) from 3 to 4. - [Release notes](https://github.com/azure/setup-kubectl/releases) - [Changelog](https://github.com/Azure/setup-kubectl/blob/main/CHANGELOG.md) - [Commits](https://github.com/azure/setup-kubectl/compare/v3...v4) --- updated-dependencies: - dependency-name: azure/setup-kubectl dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ruff from 0.3.1 to 0.3.2 (#2954)Gravatar dependabot[bot]2024-03-11-20/+20
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump azure/k8s-set-context from 3 to 4 (#2952)Gravatar dependabot[bot]2024-03-11-1/+1
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Support reply as a message reference for raw commandGravatar Richard Si2024-03-10-2/+21
| | | Co-authored-by: Daniel Brown <[email protected]>
* Bump pytest-subtests from 0.11.0 to 0.12.1 (#2948)Gravatar dependabot[bot]2024-03-08-5/+5
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump sentry-sdk from 1.40.6 to 1.41.0 (#2949)Gravatar dependabot[bot]2024-03-08-6/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ruff from 0.3.0 to 0.3.1 (#2947)Gravatar dependabot[bot]2024-03-08-20/+20
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump pytest from 8.0.2 to 8.1.0 (#2943)Gravatar dependabot[bot]2024-03-05-7/+7
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add upload date to !pypi (#2924)Gravatar korty.codes2024-03-02-0/+17
| | | | Co-authored-by: Xithrius <[email protected]>
* Bump python-dateutil from 2.8.2 to 2.9.0.post0 (#2942)Gravatar dependabot[bot]2024-03-02-5/+5
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ruff from 0.2.2 to 0.3.0 (#2940)Gravatar dependabot[bot]2024-03-02-20/+20
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump sentry-sdk from 1.40.5 to 1.40.6 (#2939)Gravatar dependabot[bot]2024-02-29-6/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump coverage from 7.4.2 to 7.4.3 (#2936)Gravatar dependabot[bot]2024-02-27-55/+55
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump pytest from 8.0.1 to 8.0.2 (#2935)Gravatar dependabot[bot]2024-02-27-5/+5
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Merge pull request #2934 from ↵Gravatar Amrou Bellalouna2024-02-25-5/+9
|\ | | | | | | | | python-discord/dependabot/pip/pydantic-settings-2.2.1 Bump pydantic-settings from 2.1.0 to 2.2.1
| * Bump pydantic-settings from 2.1.0 to 2.2.1Gravatar dependabot[bot]2024-02-24-5/+9
|/ | | | | | | | | | | | | | Bumps [pydantic-settings](https://github.com/pydantic/pydantic-settings) from 2.1.0 to 2.2.1. - [Release notes](https://github.com/pydantic/pydantic-settings/releases) - [Commits](https://github.com/pydantic/pydantic-settings/compare/v2.1.0...v2.2.1) --- updated-dependencies: - dependency-name: pydantic-settings dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
* Bump sentry-sdk from 1.40.4 to 1.40.5 (#2931)Gravatar dependabot[bot]2024-02-22-6/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump httpx from 0.26.0 to 0.27.0 (#2933)Gravatar dependabot[bot]2024-02-22-5/+5
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Merge pull request #2932 from python-discord/dependabot/pip/coverage-7.4.2Gravatar Amrou Bellalouna2024-02-21-55/+55
|\ | | | | Bump coverage from 7.4.1 to 7.4.2
| * Bump coverage from 7.4.1 to 7.4.2Gravatar dependabot[bot]2024-02-21-55/+55
|/ | | | | | | | | | | | | | | Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.4.1 to 7.4.2. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](https://github.com/nedbat/coveragepy/compare/7.4.1...7.4.2) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Merge pull request #2928 from python-discord/dependabot/pip/ruff-0.2.2Gravatar Amrou Bellalouna2024-02-19-20/+20
|\ | | | | Bump ruff from 0.2.1 to 0.2.2
| * Bump ruff from 0.2.1 to 0.2.2Gravatar dependabot[bot]2024-02-19-20/+20
|/ | | | | | | | | | | | | | | Bumps [ruff](https://github.com/astral-sh/ruff) from 0.2.1 to 0.2.2. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](https://github.com/astral-sh/ruff/compare/v0.2.1...v0.2.2) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Merge pull request #2929 from python-discord/dependabot/pip/pre-commit-3.6.2Gravatar Amrou Bellalouna2024-02-19-5/+5
|\ | | | | Bump pre-commit from 3.6.1 to 3.6.2
| * Bump pre-commit from 3.6.1 to 3.6.2Gravatar dependabot[bot]2024-02-19-5/+5
|/ | | | | | | | | | | | | | | Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 3.6.1 to 3.6.2. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](https://github.com/pre-commit/pre-commit/compare/v3.6.1...v3.6.2) --- updated-dependencies: - dependency-name: pre-commit dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Merge pull request #2930 from python-discord/dependabot/pip/pytest-8.0.1Gravatar Amrou Bellalouna2024-02-19-5/+5
|\ | | | | Bump pytest from 8.0.0 to 8.0.1
| * Bump pytest from 8.0.0 to 8.0.1Gravatar dependabot[bot]2024-02-19-5/+5
|/ | | | | | | | | | | | | | | Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pytest-dev/pytest/compare/8.0.0...8.0.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
* Bump pre-commit from 3.6.0 to 3.6.1 (#2921)Gravatar dependabot[bot]2024-02-14-5/+5
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump sentry-sdk from 1.40.3 to 1.40.4 (#2923)Gravatar dependabot[bot]2024-02-14-6/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Ensure filter list is present in previously triggered cache before accessingGravatar Chris Lovering2024-02-11-1/+1
|
* Merge pull request #2920 from ↵Gravatar mina2024-02-10-3/+6
|\ | | | | | | python-discord/feat/2172/show-new-reminder-timestamp
| * Reminders: show updated timestampGravatar Mark2024-02-09-3/+6
|/ | | | | | | When a reminder's duration is updated, show the new timestamp in the confirmation message that is sent. Resolve #2172
* Bump sentry-sdk from 1.40.2 to 1.40.3 (#2919)Gravatar dependabot[bot]2024-02-10-6/+6
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>