aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* HelpChannels: unschedule the dormant task in unclaim_channelGravatar MarkKoz2021-01-04-2/+5
| | | | Ensure the cancellation will be under the lock once the lock is added.
* HelpChannels: clarify close command docstringGravatar MarkKoz2021-01-04-2/+1
| | | | | Referencing internal functions in public-facing documentation is not helpful to users.
* HelpChannels: refactor the close command checkGravatar MarkKoz2021-01-04-10/+10
|
* HelpChannels: make a channel available within the lockGravatar MarkKoz2021-01-04-5/+6
| | | | | | | | If the lock causes the function to abort, a new channel shouldn't be made available. However, the only way to know it's aborted from the outside would be through a return value or global variable. Neither seem as nice as just just using `create_task` within the lock to avoid having `move_to_available` hold the lock.
* Add asyncio.create_task wrapper which logs exceptionsGravatar MarkKoz2021-01-04-0/+17
| | | | | | Normally exceptions are only logged when tasks are garbage collected. This wrapper will allow them to be logged immediately through a done callback. This is similar to how the Scheduler logs errors.
* HelpChannels: fix race condition between claiming and unclaimingGravatar MarkKoz2021-01-04-1/+15
| | | | | | | | | | The race condition is when a user claims a channel while their other channel is being unclaimed. Specifically, it's while their cooldown is being removed. The lock ensures that either the cooldown will be re-applied after it's removed or that it won't be removed since `unclaim_channel` will see the user has another claimed channel.
* Lock: support waiting until a lock is availableGravatar MarkKoz2021-01-04-37/+25
| | | | | It's been determined that asyncio.Lock is safe to use in such manner. Therefore, replace LockGuard entirely with asyncio.Lock.
* HelpChannels: refactor channel unclaimingGravatar MarkKoz2021-01-04-20/+19
| | | | | | Narrow the scope of `move_to_dormant` to just moving the channel. Following the design of `claim_channel`, make `unclaim_channel` handle cooldowns and unpinning.
* HelpChannels: remove obsolete channel position trace logGravatar MarkKoz2021-01-04-1/+0
|
* HelpChannels: refactor stat trackingGravatar MarkKoz2021-01-04-27/+47
| | | | Move significant code related to stats to a separate module.
* HelpChannels: move function to the channel moduleGravatar MarkKoz2021-01-04-42/+45
|
* HelpChannels: prevent user from claiming multiple channels quicklyGravatar MarkKoz2021-01-04-0/+1
| | | | | | | | | It's conceivable for a user to be able to quickly send a message in all available channels before the code has a chance to add the cooldown role. Place a lock on the author to prevent the claim code from running multiple times for the same user.
* HelpChannels: await init task at the start of event listenersGravatar MarkKoz2021-01-04-4/+4
| | | | | | It feels safer to do this since the init task moves channels to different categories and the listeners check if channels are in certain categories.
* HelpChannels: use a more accurate lock for messagesGravatar MarkKoz2021-01-04-47/+35
| | | | | | | Use the `lock_arg` decorator to keep a separate lock for each channel rather than a single lock used by all messages. Separate the core logic in `on_message` into a separate function to facilitate the use of `lock_arg` - not everything in `on_message` needs to be under the lock.
* Merge pull request #1340 from python-discord/ks123/raw-fixGravatar Matteo Bertucci2021-01-04-2/+6
|\ | | | | Add check does user have permission to get raw message and re-enable raw command
| * Merge branch 'master' into ks123/raw-fixGravatar Matteo Bertucci2021-01-04-71/+131
| |\ | |/ |/|
* | Merge pull request #1152 from python-discord/Make_nomination_reason_optionalGravatar Dennis Pham2021-01-03-8/+8
|\ \ | | | | | | Make nomination reason optional.
| * \ Merge branch 'master' into Make_nomination_reason_optionalGravatar Dennis Pham2021-01-03-45/+60
| |\ \ | |/ / |/| |
* | | Merge PR #1345 - Update d.py to fix webhook message publishingGravatar Mark2021-01-03-45/+60
|\ \ \
| * | | Update discord.py to fix webhook message publishing.Gravatar Den42002021-01-01-45/+60
|/ / / | | | | | | | | | Related to #1342.
| * | Removed 'Optional' import.Gravatar xithrius2021-01-02-1/+1
| | |
| * | Removed unnecessary debugging logs.Gravatar Xithrius2021-01-02-2/+0
| | | | | | | | | Co-authored-by: Dennis Pham <[email protected]>
| * | Set reason to default as an empty string.Gravatar Xithrius2021-01-02-5/+2
| | | | | | | | | Co-authored-by: Dennis Pham <[email protected]>
| * | No nominaton reason blank replaced by italic NoneGravatar xithrius2021-01-02-2/+4
| | |
| * | Rebased master into this branch.Gravatar xithrius2021-01-02-6460/+7705
| |\ \ | |/ / |/| | | | | The cogs folder no longer exists, but the merge command was able to automagically find the correct files to merge into. Nomination reason is now optional.
* | | Merge pull request #1334 from python-discord/bug/precommit-pycharmGravatar ks1292020-12-31-1/+1
|\ \ \ | | | | | | | | Fix flake8 pre-commit hook running through PyCharm
| * \ \ Merge branch 'master' into bug/precommit-pycharmGravatar ks1292020-12-31-297/+322
| |\ \ \ | |/ / / |/| | |
* | | | Merge pull request #1339 from python-discord/swfarnsworth/infoGravatar Dennis Pham2020-12-31-3/+3
|\ \ \ \ | | | | | | | | | | `!user` command says if a user is "Verified", rather than "Pending"
| * | | | "Pending: False" to "Verified: True" to agree with new semantics.Gravatar Steele2020-12-30-1/+1
| | | | |
| * | | | Merge branch 'master' of https://github.com/python-discord/bot into ↵Gravatar Steele2020-12-30-14/+59
| |\ \ \ \ | |/ / / / |/| | | | | | | | | swfarnsworth/info
* | | | | Merge pull request #1016 from ks129/bug-fixesGravatar ks1292020-12-29-14/+59
|\ \ \ \ \ | | | | | | | | | | | | Some bug fixes
| * \ \ \ \ Merge branch 'master' into bug-fixesGravatar ks1292020-12-29-554/+567
| |\ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Log info instead error for watchchannel consume task cancelGravatar ks1292020-12-17-1/+1
| | | | | |
| * | | | | Merge branch 'master' into bug-fixesGravatar ks1292020-12-17-55/+274
| |\ \ \ \ \
| * \ \ \ \ \ Merge branch 'master' into bug-fixesGravatar ks1292020-12-02-1079/+1215
| |\ \ \ \ \ \
| * | | | | | | Remove unnecessary f-stringGravatar ks1292020-12-02-1/+1
| | | | | | | |
| * | | | | | | Fix removing extensions and cogs for bot shutdownGravatar ks1292020-12-02-3/+7
| | | | | | | |
| * | | | | | | Add failure message when applying infraction fails because user leftGravatar ks1292020-12-02-0/+2
| | | | | | | |
| * | | | | | | Remove second unnecessary parenthesisGravatar ks1292020-12-02-4/+2
| | | | | | | |
| * | | | | | | Log exception instead warning for unexpected HttpExceptionGravatar ks1292020-12-02-1/+1
| | | | | | | |
| * | | | | | | Fix user leaving from guild log grammarGravatar ks1292020-12-02-2/+4
| | | | | | | |
| * | | | | | | Merge NotFound caching with HttpException caching with status codeGravatar ks1292020-12-02-10/+4
| | | | | | | |
| * | | | | | | Merge branch 'master' into bug-fixesGravatar ks1292020-11-21-604/+931
| |\ \ \ \ \ \ \
| * | | | | | | | Catch not found exception in schedulerGravatar ks1292020-11-07-15/+30
| | | | | | | | |
| * | | | | | | | Use result instead exception for watchchannel closing taskGravatar ks1292020-11-07-1/+1
| | | | | | | | |
| * | | | | | | | Remove both cogs and extensions on closingGravatar ks1292020-11-07-11/+4
| | | | | | | | |
| * | | | | | | | Merge branch 'master' into bug-fixesGravatar ks1292020-11-07-811/+2173
| |\ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ Merge remote-tracking branch 'origin/bug-fixes' into bug-fixesGravatar ks1292020-10-10-0/+0
| |\ \ \ \ \ \ \ \ \
| | * | | | | | | | | Fix calling extensions removing function with wrong nameGravatar ks1292020-10-09-1/+1
| | | | | | | | | | |
| * | | | | | | | | | Catch HTTPException when muting userGravatar ks1292020-10-10-2/+7
| | | | | | | | | | |