aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Avoid instantiating the cog when testing static/class methodsGravatar MarkKoz2020-05-11-10/+5
|
* Token remover: use a string template for the log messageGravatar MarkKoz2020-05-11-4/+11
|
* Token remover: split some of `take_action` into separate functionsGravatar MarkKoz2020-05-11-11/+21
|
* Correct the return type annotation for the autospec decoratorGravatar MarkKoz2020-05-11-2/+2
|
* Test token regex matches valid tokensGravatar MarkKoz2020-05-11-0/+21
|
* Test is_maybe_tokenGravatar MarkKoz2020-05-11-7/+24
|
* Token remover: fix `is_maybe_token` returning None instead of FalseGravatar MarkKoz2020-05-11-0/+2
| | | | | It's annotated as returning a bool and when the split fails it already returns False. To be consistent, it should always return a bool.
* Test `is_maybe_token` returns False for missing partsGravatar MarkKoz2020-05-11-0/+10
| | | | | | | In practice, this won't ever happen since the regex wouldn't match strings with missing parts. However, the function does check it so may as well test it. It's not necessarily bound to always use inputs from the regex either I suppose.
* Fix autospec decorator when used with multiple attributesGravatar MarkKoz2020-05-11-16/+12
| | | | | | | | The original approach of messing with the `attribute_name` didn't work for reasons I won't discuss here (would require knowledge of patcher internals). The new approach doesn't use patch.multiple but mimics it by applying multiple patch decorators to the function. As a consequence, this can no longer be used as a context manager.
* Test token regex doesn't match invalid tokensGravatar MarkKoz2020-05-11-7/+25
|
* Test `find_token_in_message` returns the found tokenGravatar MarkKoz2020-05-11-0/+24
|
* Test `find_token_in_message` returns None if no matches foundGravatar MarkKoz2020-05-11-0/+14
|
* Fix test for token remover ignoring bot messagesGravatar MarkKoz2020-05-11-4/+9
| | | | | | It's not possible to test this via asserting the return value of `on_message` since it never returns anything. Instead, the actual relevant unit, `find_token_in_message,` should be tested.
* Allow using arbitrary parameter names with the autospec decoratorGravatar MarkKoz2020-05-11-2/+15
| | | | | This gives the caller more flexibility. Sometimes attribute names are too long or they don't follow a naming scheme accepted by the linter.
* Test token remover skips messages without tokensGravatar MarkKoz2020-05-11-0/+11
|
* Test token remover takes action if a token is foundGravatar MarkKoz2020-05-11-1/+13
|
* Add a test helper function to patch multiple attributes with autospecsGravatar MarkKoz2020-05-11-0/+9
| | | | | | This helper reduces redundancy/boilerplate by setting default values. It also has the consequence of shortening the length of the invocation, which makes it faster to use and easier to read.
* Test on_message_edit of token remover uses on_messageGravatar MarkKoz2020-05-11-2/+10
|
* Token remover: reduce duplicated code in `on_message_edit`Gravatar MarkKoz2020-05-11-3/+1
|
* Token remover: catch ValueError when non-ASCII chars are presentGravatar MarkKoz2020-05-11-2/+2
| | | | | | | | | | The token uses base64 and base64 only allows ASCII characters. Thus, if a match has non-ASCII characters, it's not a valid token. Catching the ValueError is simpler than trying to adjust the regex to only match valid base64. Fixes #928 Fixes BOT-3X
* Merge pull request #924 from ↵Gravatar Daniel Brown2020-05-11-20/+58
|\ | | | | | | | | python-discord/feature/hemlock/perma-ban-override-temp Perma Bans now Overwrite Temp Bans
| * Merge branch 'master' into feature/hemlock/perma-ban-override-tempGravatar Daniel Brown2020-05-11-58/+34
| |\ | |/ |/|
* | Merge pull request #938 from Suhail6inkling/remind_aliasGravatar Leon Sandøy2020-05-11-1/+1
|\ \ | | | | | | Add remindme alias for the remind command
| * | Add remindme alias for the remind commandGravatar Suhail2020-05-10-1/+1
|/ /
* | Merge pull request #923 from python-discord/feat/util/remove-mention-cmdGravatar Daniel Brown2020-05-08-56/+2
|\ \ | | | | | | Remove the mention command and configuration settings for it
| * \ Merge branch 'master' into feat/util/remove-mention-cmdGravatar Daniel Brown2020-05-08-1/+31
| |\ \ | |/ / |/| |
* | | Merge pull request #903 from python-discord/bug/backend/894/win-selector-loopGravatar Daniel Brown2020-05-07-1/+7
|\ \ \ | | | | | | | | Use selector event loop on Windows
| * \ \ Merge branch 'master' into bug/backend/894/win-selector-loopGravatar Daniel Brown2020-05-07-136/+405
| |\ \ \ | |/ / / |/| | |
* | | | Merge pull request #919 from ↵Gravatar Sebastiaan Zeeff2020-05-05-0/+12
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | python-discord/bug/backend/911/log-listener-exceptions Log unhandled errors from event listeners
| * \ \ \ Merge branch 'master' into bug/backend/911/log-listener-exceptionsGravatar Sebastiaan Zeeff2020-05-05-3/+16
| |\ \ \ \ | |/ / / / |/| | | |
* | | | | Merge pull request #925 from Savant-Dev/antimalwareGravatar Daniel Brown2020-05-05-0/+12
|\ \ \ \ \ | | | | | | | | | | | | Update to Antimalware Filter (.txt uploads)
| * \ \ \ \ Merge branch 'master' into antimalwareGravatar Daniel Brown2020-05-05-2/+2
| |\ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Update antimalware to filter txt files in cases where messages were longer ↵Gravatar Savant-Dev2020-05-04-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | than 2000 chars
| * | | | | Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev2020-05-01-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | longer than 2000 characters
| * | | | | Update extension filter to distinguish .txt in cases where messages are ↵Gravatar Savant-Dev2020-05-01-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | longer than 2000 characters
| | * | | | Log unhandled errors from event listenersGravatar MarkKoz2020-04-29-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, discord.py prints them to stderr. To better help detect such errors in production, they should instead be logged with an appropriate log level. Some sentry metadata has also been included. `on_error` doesn't work as a listener in a cog so it's been put in the Bot subclass. Fixes #911
| | | * | | Fix awaiting non-coroutine when closing the statsd transportGravatar MarkKoz2020-04-24-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `BaseTransport.close()` is not a coroutine and therefore should not be awaited.
| | | * | | Use selector event loop on WindowsGravatar MarkKoz2020-04-22-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | aiodns requires the selector event loop for asyncio. In Python 3.8, the default event loop for Windows was changed to proactor. To fix this, the event loop is explicitly set to selector.
| | | | * | Remove mention command constantsGravatar MarkKoz2020-05-02-10/+0
| | | | | |
| | | | * | Remove the mention commandGravatar MarkKoz2020-05-01-46/+2
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | It was made obsolete by a new Discord feature. Users can be granted a permission to mention a role despite the role being set as non-mentionable.
| | | | * Restructure `apply_ban()` logic Gravatar Daniel Brown2020-05-11-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | Another refactor/cleaning to make the logic clearer and easier to understand. Also cleaned up the trace logs to be shorter and more concise. Thanks, @scragly! Co-authored-by: scragly <[email protected]>
| | | | * apply_ban() logic refinedGravatar Daniel Brown2020-05-07-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Refined the logic for `apply_ban()` even further to be cleaner. (Thanks, @MarkKoz!) Signed-off-by: Daniel Brown <[email protected]>
| | | | * Addressing Review ChangesGravatar Daniel Brown2020-05-07-25/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Changed docstring explanation and function name of `get_active_infractions` to `get_active_infraction()` to better convey that only one infraction is returned. Also changed all relevant uses to reflect that change. - Added explanation of parameter `send_msg` to the doc strings of `pardon_infraction()` and `get_active_infraction()` - Adjusted placement of `log.trace()` in `pardon_infraction()` - Adjusted logic in `apply_ban()` to remove redundant check. - Adjusted logic in `apply_ban()` to be consistent with other checks. Signed-off-by: Daniel Brown <[email protected]>
| | | | * Merge branch 'master' into feature/hemlock/perma-ban-override-tempGravatar Daniel Brown2020-05-04-2/+2
| | | | |\ | |_|_|_|/ |/| | | |
* | | | | Merge pull request #922 from python-discord/bug/info/914/user-animated-avatarGravatar kwzrd2020-05-01-2/+2
|\ \ \ \ \ | |/ / / / |/| | | | Display animated avatars in the user info command
| * | | | Tests: change avatar_url_as assertion to use static_formatGravatar MarkKoz2020-04-30-1/+1
| | | | |
| * | | | Display animated avatars in the user info commandGravatar MarkKoz2020-04-30-1/+1
|/ / / / | | | | | | | | | | | | Fixes #914
| | | * Perma Bans now Overwrite Temp BansGravatar Daniel Brown2020-05-04-18/+55
| |_|/ |/| | | | | | | | | | | | | | | | | | | | - Changed `has_active_infraction` to `get_active_infractions` in order to add additional logic in `apply_ban`. - Added `send_msg` parameters to `pardon_infraction` and `get_active_infractions` so that multi-step checks and actions don't need to send additional messages unless told to do so. Signed-off-by: Daniel Brown <[email protected]>
* | | Run a category check before logging that we are checking for an answered ↵Gravatar Joseph Banks2020-04-30-1/+2
|/ / | | | | | | help channel
* | Merge pull request #913 from python-discord/add-bottom-sorting-to-help-channelsGravatar Sebastiaan Zeeff2020-04-28-12/+63
|\ \ | | | | | | Sort help channels and add support for `how-to-get-help` channel
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-28 12:04:05 +0000