aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | | | | | * | | | | | | | | Merge branch 'master' into #364-offensive-msg-autodeletionGravatar Matteo Bertucci2019-11-16-975/+1910
| | | | | | |\ \ \ \ \ \ \ \ \
| | | | | | * | | | | | | | | | Switch to datetime.datetimeGravatar Akarys422019-10-26-6/+6
| | | | | | | | | | | | | | | |
| | | | | | * | | | | | | | | | Merge branch 'master' into #364-offensive-msg-autodeletionGravatar Akarys422019-10-25-191/+182
| | | | | | |\ \ \ \ \ \ \ \ \ \
| | | | | | * | | | | | | | | | | Use Scheduler instead of a custom async loopGravatar Akarys422019-10-25-41/+43
| | | | | | | | | | | | | | | | |
| | | | | | * | | | | | | | | | | Rename offensive_msg flag to schedule_deletion.Gravatar Akarys422019-10-25-7/+7
| | | | | | | | | | | | | | | | |
| | | | | | * | | | | | | | | | | Remove the possibility that we send a message to the API that the filter has ↵Gravatar Akarys422019-10-25-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | already deleted.
| | | | | | * | | | | | | | | | | Move offensive message delete time to config file.Gravatar Akarys422019-10-25-2/+4
| | | | | | | | | | | | | | | | |
| | | | | | * | | | | | | | | | | Revert whitespace changesGravatar Matteo Bertucci2019-10-25-6/+6
| | | | | | | | | | | | | | | | |
| | | | | | * | | | | | | | | | | Autodelete offensive messages after one week.Gravatar Akarys422019-10-25-10/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the filter cog filter a message that's considered as offensive (filter["offensive_msg"] is True), the cog create a new offensive message object in the bot db with a delete_date of one week after it was sent. A background task run every day, pull up a list of message to delete, find them back, and delete them.
| | | | | | | | | | | | * | | | | Webhook remover: exit early if message already deletedGravatar MarkKoz2020-06-15-2/+8
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | * | | | | Webhook remover: ignore DMs and bot messagesGravatar MarkKoz2020-06-15-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Can't remove messages in DMs, so don't bother trying.
| | | | | | | | | | | | * | | | | Token remover: exit early if message already deletedGravatar MarkKoz2020-06-15-3/+22
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | * | | | | Token remover: move bot check to on_messageGravatar MarkKoz2020-06-15-21/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It just makes more sense to me to filter out messages at an earlier stage.
| | | | | | | | | | | | * | | | | Token remover: ignore DMsGravatar MarkKoz2020-06-15-0/+13
| | | | | |_|_|_|_|_|_|/ / / / / | | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's a private channel so there's no risk of a token "leaking". Furthermore, messages cannot be deleted in DMs.
| | | | | | | | | | | | * | | | Write unit test for `sub_clyde`Gravatar kwzrd2020-06-20-0/+27
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | * | | | Preserve empty string when substituting clydeGravatar MarkKoz2020-06-19-0/+2
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | * | | | Make sub_clyde case-sensitive and use Cyrillic e'sGravatar MarkKoz2020-06-17-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Cyrillic characters are more likely to be rendered similarly to their Latin counterparts than the math sans-serif characters.
| | | | | | | | | | | | * | | | Fix 400 when "clyde" is in webhook usernameGravatar MarkKoz2020-06-15-8/+24
| |_|_|_|_|_|_|_|_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Discord just disallows this name.
* | | | | | | | | | | | | | | Log exception info for failed attachment uploadsGravatar MarkKoz2020-06-15-1/+1
| |_|_|/ / / / / / / / / / / |/| | | | | | | | | | | | |
| | | | | | | | | | | * | | Logging Tests: Simplify `DEBUG_MODE` `False` testGravatar ks1292020-05-22-11/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove embed attributes checks - Replace `self.dev_log.assert_awaited_once_with` with `self.dev_log.assert_awaited_once`.
| | | | | | | | | | | * | | Merge branch 'master' into logging-testsGravatar ks1292020-05-17-786/+1195
| | | | | | | | | | | |\ \ \
| | | | | | | | | | | * | | | Created tests for `bot.cogs.logging` connected message.Gravatar ks1292020-04-14-0/+42
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | * | Sync: fix guild ID checkGravatar MarkKoz2020-06-17-22/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Need to compare the IDs against each other rather than the Guild object against the ID.
| | | | | | | | | | | | | * | Sync: ignore 404s in on_user_updateGravatar MarkKoz2020-06-14-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 404s probably mean the user is from another guild.
| | | | | | | | | | | | | * | Sync tests: test listeners ignore events from other guildsGravatar MarkKoz2020-06-14-10/+54
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | * | Sync: ignore events from other guildsGravatar MarkKoz2020-06-14-0/+18
| |_|_|_|_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | |
* | | | | | | | | | | | | | Add the C# guild to the whitelistGravatar Dennis Pham2020-06-15-0/+1
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge pull request #937 from python-discord/bug/filters/928/non-ascii-tokenGravatar Mark2020-06-12-154/+357
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make token detection more robust and completely rewrite its tests
| * \ \ \ \ \ \ \ \ \ \ \ \ \ Merge remote-tracking branch 'origin/master' into ↵Gravatar MarkKoz2020-06-02-1044/+2456
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bug/filters/928/non-ascii-token
| * | | | | | | | | | | | | | | Token remover: remove the `delete_message` functionGravatar MarkKoz2020-06-02-19/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's redundant; there's no benefit here in abstracting two lines of code into a function.
| * | | | | | | | | | | | | | | Test find_token_in_message returns None for invalid matchesGravatar MarkKoz2020-05-28-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This covers the case when a token is matched, but its user ID and timestamp turn out to be invalid.
| * | | | | | | | | | | | | | | Adjust find_token_in_message tests for the recent cog changesGravatar MarkKoz2020-05-28-19/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It now supports the changes that switched to finditer, added match groups, and added the Token NamedTuple. It also accounts for the is_maybe_token function being removed. For the sake of simplicity, call assertions on is_valid_user_id and is_valid_timestamp were not made.
| * | | | | | | | | | | | | | | Remove is_maybe_token testsGravatar MarkKoz2020-05-28-33/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The function was removed due to redundancy. Therefore, its tests are obsolete.
| * | | | | | | | | | | | | | | Add more thorough and realistic inputs for token ID and timestamp testsGravatar MarkKoz2020-05-27-18/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tests for valid inputs and invalid inputs were split to make them more readable.
| * | | | | | | | | | | | | | | Adjust token remover tests to use the Token NamedTupleGravatar MarkKoz2020-05-27-6/+8
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Switch findall to finditer in assertionsGravatar MarkKoz2020-05-27-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `find_token_in_message` now uses the latter so the tests should adjust accordingly.
| * | | | | | | | | | | | | | | Use real token values for testing multiple matches in regexGravatar MarkKoz2020-05-25-3/+4
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Fix multiple match text for token regexGravatar MarkKoz2020-05-25-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It has to account for the addition of groups. It's easiest to compare the entire string so `finditer` is used to return re.Match objects; the tuples of `findall` would be cumbersome. Also threw in a change to use `assertCountEqual` cause the order doesn't really matter.
| * | | | | | | | | | | | | | | Fix valid token regex testGravatar MarkKoz2020-05-25-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was broken due to the addition of groups. Rather than returning the full match, `findall` returns groups if any exist. The test was comparing a tuple of groups to the token string, which was of course failing. Now `fullmatch` is used cause it's simpler - just check for `None` and don't worry about iterating matches to search.
| * | | | | | | | | | | | | | | Add more valid tokens to test the regex withGravatar MarkKoz2020-05-25-3/+5
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Test token regex won't match non-base64 charactersGravatar MarkKoz2020-05-25-4/+3
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Token remover: specify Discord epoch in secondsGravatar MarkKoz2020-05-25-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The timestamp in the token is in seconds and is being compared against the epoch. To make life easier, they should use the same unit. Previously, the epoch was in milliseconds.
| * | | | | | | | | | | | | | | Token remover: use finditer instead of findallGravatar MarkKoz2020-05-25-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It makes more sense to use the lazy function when the loop is already short-circuiting on the first valid token it finds.
| * | | | | | | | | | | | | | | Token remover: use regex groups and pass the token as a NamedTupleGravatar MarkKoz2020-05-25-27/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It felt redundant to be splitting the token in two different functions when regex could take care of this from the outset. ' A NamedTuple was created to house the token. This is nicer than passing an re.Match object, because it's clearer which attributes are available. Even if the regex used named groups, it wouldn't be as obvious which group names exist. Without the split, `is_maybe_token` is dwindled down to a redundant function. Therefore, it's been removed.
| * | | | | | | | | | | | | | | Token remover: escape dashes in regexGravatar MarkKoz2020-05-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They need to be escaped when they're in a character set. By default, they are interpreted as part of the character range syntax.
| * | | | | | | | | | | | | | | Token remover: match only base64 in regexGravatar MarkKoz2020-05-21-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Making the regex more accurate reduces false positives at an earlier stage. There's no benefit to matching non-base64 as that would just be weeded out as invalid at a later stage anyway when it tries to decode it.
| * | | | | | | | | | | | | | | Token remover: decode ID using URL-safe base64Gravatar MarkKoz2020-05-21-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Though I've not seen an ID with neither + and \ nor - and _, given that the timestamp uses URL-safe encoding, the ID probably does too.
| * | | | | | | | | | | | | | | Add a utility function to pad base64 dataGravatar MarkKoz2020-05-16-2/+8
| | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | Token remover: use strict check for digits in token IDGravatar MarkKoz2020-05-15-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `isnumeric` would be true for a wide range of characters in Unicode, but the ID must only consist of the characters 0-9 (ASCII digits). In fact, `isdigit` on its own would also match other Unicode characters too.
| * | | | | | | | | | | | | | | Token remover: fix timestamp checkGravatar MarkKoz2020-05-14-10/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The timestamp calculation was incorrect. The bytes need to be interpreted as big-endian and the result is just a timestamp rather than a snowflake.