aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* HelpChannels: tidy up log messagesGravatar MarkKoz2020-04-20-5/+1
| | | | | | * Remove obsolete log message * Shorten a log message which was the only line in the entire module over 100 characters
* HelpChannels: handle errors when changing cooldown roleGravatar MarkKoz2020-04-17-12/+35
| | | | | | | | | | | A user may leave the guild before their role can be changed. Sometimes, there could also be role hierarchy issues or other network issues. It's not productive to halt everything and just dump these as exceptions to the loggers. The error handler provides a more graceful approach to these exceptions. * Add a wrapper function around `add_roles` & `remove_roles` which catches exceptions
* HelpChannels: fix role not resetting after dormant commandGravatar MarkKoz2020-04-17-13/+3
| | | | | | | Resetting permissions relied on getting the member from the cache, but the member was already removed from the cache prior to resetting the role. Now the member is passed directly rather than relying on the cache.
* HelpChannels: mention dormant cmd in available message embedGravatar MarkKoz2020-04-17-2/+3
| | | | Users should know they can close their own channels.
* HelpChannels: add info about cooldown role & dormant cmd to docstringGravatar MarkKoz2020-04-17-0/+3
|
* HelpChannels: add/remove a cooldown role rather than using overwritesGravatar MarkKoz2020-04-17-13/+10
| | | | | | | Overwrites had issues syncing with channels in the category. * Remove update_category_permissions; obsolete * Add constant for the cooldown role wrapped in a discord.Object
* HelpChannels: clear roles when resetting permissionsGravatar MarkKoz2020-04-17-9/+7
| | | | | Claimants will have a special role that needs to be removed rather than using member overwrites for the category.
* HelpChannels: add helper function to check for claimant roleGravatar MarkKoz2020-04-17-0/+5
|
* HelpChannels: remove ensure_permissions_synchronizationGravatar MarkKoz2020-04-17-29/+1
|
* Constants: add help channel cooldown roleGravatar MarkKoz2020-04-17-0/+2
|
* Merge pull request #877 from ↵Gravatar Shirayuki Nekomata2020-04-18-2/+8
|\ | | | | | | | | python-discord/bug/frontend/870/help-channel-dm-category HelpChannels: fix AttributeError getting a category for a DMChannel
| * Merge branch 'master' into bug/frontend/870/help-channel-dm-categoryGravatar Shirayuki Nekomata2020-04-18-50/+346
| |\ | |/ |/|
* | Merge pull request #874 from ks129/syncer-timeout-fixGravatar kwzrd2020-04-17-2/+4
|\ \ | | | | | | Fix wrong exception type in syncing
| * \ Merge branch 'master' into syncer-timeout-fixGravatar kwzrd2020-04-17-181/+1253
| |\ \ | |/ / |/| |
* | | Remove `.md` from anti-malware whitelistGravatar Sebastiaan Zeeff2020-04-16-1/+0
| | | | | | | | | We want our members to use the paste site to share text-based files instead of them sharing the files as attachments on Discord. As `.md`, a file extensions used for plain-text files with markdown formatting, is such a text file, I've removed it from the anti-malware whitelist.
* | | Merge pull request #881 from ↵Gravatar Shirayuki Nekomata2020-04-14-4/+0
|\ \ \ | | | | | | | | | | | | | | | | python-discord/help-channels-keep-dormant-invocation Reverse deletion of `!dormant` invocation messages
| * | | Revert deletion of !dormant invocation messagesGravatar Sebastiaan Zeeff2020-04-14-4/+0
|/ / / | | | | | | | | | | | | | | | | | | | | | PR #868 introduced the automatic deletion of the message that issued the `!dormant` command. The idea behind this was that moving the channel to the dormant category makes it obvious that a channel has gone dormant and the message would only serve as visual clutter. However, removing the command invocation also means that it's less obvious why a channel was moved to the dormant category. As the message gets deleted almost immediately, you have to be actively watching the channel to know that the command was issued and who issued it. This has already caused some confusion where helping members where left wondering why a channel suddenly went dormant while they felt that the conversation was still ongoing. To improve the user experience, this commit removes the deletions of the command invocation messages.
* | | [stat] Tag statistic was using the user input as the series name, not the ↵Gravatar Joseph Banks2020-04-13-1/+1
| | | | | | | | | | | | resolved tag name
* | | [stat] Create a statistic for whether dormant was called by the claimant or ↵Gravatar Joseph Banks2020-04-12-1/+7
| | | | | | | | | | | | staff
* | | Merge branch 'Numerlor-help-dormant-feedback' into `master`Gravatar Sebastiaan Zeeff2020-04-12-10/+53
|\ \ \ | | | | | | | | | | | | After resolving the merge conflicts created by the recent stats addition, I'm merging this into master. No functional changes were made during conflict resolution (hopefully) and the merge has been tested.
| * | | Merge branch 'help-dormant-feedback' of https://github.com/Numerlor/bot into ↵Gravatar Sebastiaan Zeeff2020-04-12-10/+53
|/| | | | | | | | | | | | | | | Numerlor-help-dormant-feedback
| * | | Fix `help_channel_claimants` typehint.Gravatar Numerlor2020-04-10-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | `ctx.author` that is used to populate the dict returns a `Member` object in most cases while only `User` was documented as a possible value.
| * | | Use synchronized permission reset.Gravatar Numerlor2020-04-10-1/+1
| | | |
| * | | Specify encoding to logging file handler.Gravatar Numerlor2020-04-09-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | With the new addition of non latin-11 chars in channel names - which get logged, the logging to files fails on those entries on OSs where the default encoding is not utf8 or an other encoding capable of handling them.
| * | | Delete channel from claimant cache.Gravatar Numerlor2020-04-09-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Deleting the channel from the claimant cache on invokation of the dormant command prevents users running the command multiple times before the bot moves it.
| * | | Reverse order of moving to dormant and task cancellation.Gravatar Numerlor2020-04-09-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Reversing the order ensures the task is not cancelled when moving to dormant fails which gives a fallback to move it after the initial period of time.
| * | | HelpChannels: check author of dormant messageGravatar MarkKoz2020-04-09-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | In a testing environment, the bot may try to edit the message of a different bot. Therefore, the author of the message should be checked to ensure the current bot sent it.
| * | | Suppress errors when resetting permissions.Gravatar Numerlor2020-04-09-1/+2
| | | |
| * | | Move permissions reset up.Gravatar Numerlor2020-04-09-1/+2
| | | |
| * | | Move message deletion up.Gravatar Numerlor2020-04-09-3/+4
| | | |
| * | | Reword comment.Gravatar Numerlor2020-04-09-1/+1
| | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| * | | Add spacing.Gravatar Numerlor2020-04-09-0/+1
| | | | | | | | | | | | | | | | Co-authored-by: MarkKoz <[email protected]>
| * | | Reword strings to reflect name changes.Gravatar Numerlor2020-04-09-6/+6
| | | |
| * | | Change names to more descriptive ones.Gravatar Numerlor2020-04-09-6/+6
| | | |
| * | | Delete overwrite instead of send_messages permission.Gravatar Numerlor2020-04-09-1/+1
| | | | | | | | | | | | | | | | | | | | Only resetting the permission caused the overwrites for the users to remain on the category, potentially piling up and causing further issues.
| * | | Reverse help_channel_user pairs.Gravatar Numerlor2020-04-09-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pairing users to channels was a design flaw, because the keys didn't get overwritten. This allowed multiple users to access the dormant command for the running session of the bot. Replacing this with a reversed paring fixes both issues because the cache is overwritten on channel activation.
| * | | Cancel permission restoration task.Gravatar Numerlor2020-04-09-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | After the dormant command is used and the permissions are restored for the user that started the session, the task for restoring them after the claim time has passed is no longer necessary.
| * | | Handle dormant invokation not being found.Gravatar Numerlor2020-04-09-1/+4
| | | |
| * | | Extend docstrings to include new behaviour.Gravatar Numerlor2020-04-09-1/+7
| | | |
| * | | Reset cooldown after channel is made dormant.Gravatar Numerlor2020-04-09-0/+14
| | | |
| * | | Allow help session starters to invoke dormant.Gravatar Numerlor2020-04-09-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Removing the `with_role` check from the command and replcaing it with a new `dormant_check` that's used in the body, which also checks against a cache of users that started the sessions, allows them to close their own channels along with the role check.
| * | | Remove dormant invokation message after move.Gravatar Numerlor2020-04-09-0/+1
| | | |
* | | | timer -> timing for statsdGravatar Joseph Banks2020-04-12-2/+2
| | | |
* | | | Use underscore for metric names instead of dashGravatar Joseph Banks2020-04-12-1/+1
| | | |
* | | | Add a timeout to prevent the bot from being overloaded with presence updatesGravatar Joseph Banks2020-04-12-5/+21
| | | |
* | | | Merge pull request #876 from python-discord/statsGravatar Joseph2020-04-12-38/+272
|\ \ \ \ | | | | | | | | | | StatsD integration
| * | | | Address aeros' review comment regarding help channel stat reportingGravatar Joseph Banks2020-04-12-3/+3
| | | | |
| * | | | Add a metric for tracking how long defcon was activeGravatar Joseph Banks2020-04-11-1/+15
| | | | |
| * | | | Merge masterGravatar Joseph Banks2020-04-11-1/+1
| |\ \ \ \
| | * | | | Update bot/cogs/stats.pyGravatar Joseph2020-04-11-1/+1
| | | | | | | | | | | | | | | | | | Co-Authored-By: Mark <[email protected]>