aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| * | | | | | | Sync tests: fix creation of MockRolesGravatar MarkKoz2020-02-12-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Role was being accessed like a class when it is actually a dict.
| * | | | | | | Sync tests: add fixture to create a guild with rolesGravatar MarkKoz2020-02-12-1/+21
| | | | | | | |
| * | | | | | | Sync tests: rename the role syncer test caseGravatar MarkKoz2020-02-12-1/+1
| | | | | | | |
| * | | | | | | Tests: add a MockAPIClientGravatar MarkKoz2020-02-12-0/+18
| | | | | | | |
| * | | | | | | Sync: handle API errors gracefullyGravatar MarkKoz2020-02-12-10/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The whole sync is aborted when an error is caught for simplicity's sake. The sync message is edited to display the error and the traceback is logged. To distinguish an error from an abort/timeout, the latter now uses a warning emoji while the former uses the red cross.
| * | | | | | | Sync: mention core devs when results are shown & fix missing spaceGravatar MarkKoz2020-02-12-6/+8
| | | | | | | |
| * | | | | | | Sync: split _confirm() into two functionsGravatar MarkKoz2020-02-12-10/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One is responsible for sending the confirmation prompt while the other waits for the reaction. The split allows for the confirmation prompt to be edited with the results of automatic syncs too.
| * | | | | | | Sync: keep the mention for all edits of the confirmation promptGravatar MarkKoz2020-02-12-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it clearer to users where the notification came from.
| * | | | | | | Sync: add trace and debug loggingGravatar MarkKoz2020-02-12-1/+16
| | | | | | | |
| * | | | | | | Sync: fix confirmation reaction checkGravatar MarkKoz2020-02-12-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Ignore bot reactions * Check for core dev role if sync is automatic * Require author as an argument to _confirm() so it can be compared against the reaction author
| * | | | | | | Sync: remove author mention from confirm promptGravatar MarkKoz2020-02-12-2/+2
| | | | | | | |
| * | | | | | | Sync: fix overwriting message with None after editing itGravatar MarkKoz2020-02-12-1/+1
| | | | | | | |
| * | | | | | | Sync: fix passing context instead of message to _confirm()Gravatar MarkKoz2020-02-12-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Mention possibility of timing out as a reason for aborting a sync
| * | | | | | | Sync: fix missing await for fetch_channelGravatar MarkKoz2020-02-12-1/+1
| | | | | | | |
| * | | | | | | Sync: allow for None values in DiffsGravatar MarkKoz2020-02-12-4/+4
| | | | | | | |
| * | | | | | | Sync: make Role, User, and Diff privateGravatar MarkKoz2020-02-12-15/+15
| | | | | | | |
| * | | | | | | Sync: remove generic type from DiffGravatar MarkKoz2020-02-12-19/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It doesn't play along well with NamedTuple due to metaclass conflicts. The workaround involved created a NamedTuple-only base class, which does work but at the cost of confusing some static type checkers. Since Diff is now an internal data structure, it no longer really needs to have precise type annotations. Therefore, a normal namedtuple is adequate.
| * | | | | | | Sync: move sync logic into Syncer base classGravatar MarkKoz2020-02-12-93/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The interface was becoming cumbersome to work with so it was all moved to a single location. Now just calling Syncer.sync() will take care of everything. * Remove Optional type annotation from Diff attributes * _confirm() can edit the original message and use it as the prompt * Calculate the total diff and compare it against the max before sending a confirmation prompt * Remove abort message from sync(); _confirm() will handle that
| * | | | | | | Sync: prompt to confirm when diff is greater than 10Gravatar MarkKoz2020-02-12-37/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The confirmation prompt will be sent to the dev-core channel or the specified context. Confirmation is done via reactions and waits 5 minutes before timing out. * Add name property to Syncers * Make _get_diff private; only sync() needs to be called now * Change spelling of synchronize to synchronise * Update docstrings
| * | | | | | | Sync: create classes for syncersGravatar MarkKoz2020-02-12-242/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces the functions with a class for each syncer. The classes inherit from a Syncer base class. A NamedTuple was also created to replace the tuple of the object differences that was previously being returned. * Use namedtuple._asdict to simplify converting namedtuples to JSON
| * | | | | | | Sync: support sending messages to a context in sync()Gravatar MarkKoz2020-02-12-17/+11
| | | | | | | |
| * | | | | | | Sync: support multiple None totals returns from a syncerGravatar MarkKoz2020-02-12-10/+7
| | | | | | | |
| * | | | | | | Sync: create function for running a single syncerGravatar MarkKoz2020-02-12-22/+24
| | | | | | | |
| * | | | | | | Sync: refactor cogGravatar MarkKoz2020-02-12-25/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use ID from constants directly instead of SYNC_SERVER_ID * Use f-strings instead of %s for logging * Fit into margin of 100 * Invert condition to reduce nesting * Use Any instead of incorrect function annotation for JSON values
| * | | | | | | API: create request function which has a param for the HTTP methodGravatar MarkKoz2020-02-12-18/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reduces code redundancy.
| * | | | | | | API: define functions with keyword-only argumentsGravatar MarkKoz2020-02-12-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This seems to have been the intent of the original implementation.
| * | | | | | | Constants: add dev-core channel and check mark emojiGravatar MarkKoz2020-02-12-0/+4
| | | | | | | |
| * | | | | | | Use wait_until_guild_available instead of wait_until_readyGravatar MarkKoz2020-02-12-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It has a much better guarantee that the cache will be available.
| * | | | | | | Bot: make the connector attribute privateGravatar MarkKoz2020-02-12-4/+4
| | | | | | | |
| * | | | | | | Bot: add wait_until_guild_availableGravatar MarkKoz2020-02-12-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This coroutine waits until the configured guild is available and ensures the cache is present. The on_ready event is inadequate because it only waits 2 seconds for a GUILD_CREATE gateway event before giving up and thus not populating the cache for unavailable guilds.
| | | | | | | * Update Dockerfile to use python:3.8-slimGravatar Sebastiaan Zeeff2020-02-24-1/+1
| | | | | | | |
| | | | | | | * Make Azure CI use Python 3.8 and Ubuntu 18.04Gravatar Sebastiaan Zeeff2020-02-24-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the bot is now using Python 3.8 and some of our dependencies have Python-version specfic dependencies, it's important that the CI, which installs from our Pipfile, uses the same version of Python.
| | | | | | | * Fix test_time test and ensure coverageGravatar Sebastiaan Zeeff2020-02-23-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the test_time methods did not actually assert the exception message it was trying to detect as the assertion statement was contained within the context manager handling the exception. I've moved it out of the context so it actually runs. I've also added a few `praga: no cover` comments for parts that were artifically lowering coverage of the test suite.
| | | | | | | * Use unittest's AsyncMock instead of our AsyncMockGravatar Sebastiaan Zeeff2020-02-23-213/+103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Python 3.8 introduced an `unittest.mock.AsyncMock` class that can be used to mock coroutines and other types of asynchronous operations like async iterators and async context managers. As we were using our custom, but limited, AsyncMock, I have replaced our mock with unittest's AsyncMock. Since Python 3.8 also introduces a different way of automatically detecting which attributes should be mocked with an AsyncMock, I've changed our CustomMockMixin to use this new method as well. Together with a couple other small changes, this means that our Custom Mocks now use a lazy method of detecting coroutine attributes, which significantly speeds up the test suite.
| | | | | | | * Remove lingering pytest test_time.py fileGravatar Sebastiaan Zeeff2020-02-23-62/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I forgot to remove one pytest test file during the migration from pytest to unittest. Since we have sinced added a unittest version of the same file, I've now removed the lingering pytest file.
| | | | | | | * Use IsolatedAsyncioTestCase instead of async_testGravatar Sebastiaan Zeeff2020-02-23-70/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we upgraded to Python 3.8, we can now use the new IsolatedAsyncioTestCase test class to use coroutine-based test methods instead of our own, custom async_test decorator. I have changed the base class for all of our test classes that use coroutine-based test methods and removed the now obsolete decorator from our helpers.
| | | | | | | * Use mixin-composition not inheritance for LoggingTestCaseGravatar Sebastiaan Zeeff2020-02-23-16/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We used inheritence to add additional logging assertion methods to unittest's TestCase class. However, with the introduction of the new IsolatedAsyncioTestCase this extension strategy means we'd have to create multiple child classes to be able to use the extended functionality in all of the TestCase variants. Since that leads to undesirable code reuse and an inheritance relationship is not at all needed, I've switched to a mixin-composition based approach that allows the user to extend the functionality of any TestCase variant with a mixin where needed.
| | | | | | | * Update to Python 3.8 and discord.py 1.3.2Gravatar Sebastiaan Zeeff2020-02-23-79/+37
| |_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've changed the Python version in our Pipfile to Python 3.8. The main advantage of Python 3.8 is that it comes with significant upgrades to the unittest module which allow us to test asyncio-based code more easily. While our current test suite runs in P3.8 "out of the box", it currently still relies on many of the workarounds we had to use to test asynchronous code in Python 3.7. A future commit will replace these workarounds with the new tools available in Python 3.8. This commit also updates our discord.py version to 1.3.2. Versions of discord.py <= 1.3.1 contain a bug that causes errors in the new unittest tools that come with Python 3.8. For more specific details, see https://github.com/Rapptz/discord.py/pull/2570.
* | | | | | | Merge pull request #749 from python-discord/reminder-enhancementsGravatar Leon Sandøy2020-02-23-15/+47
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Reminder Embed Enhancements & Whitelist Expansion
| * | | | | | Merge branch 'master' into reminder-enhancementsGravatar S. Co12020-02-23-607/+951
| |\ \ \ \ \ \ | |/ / / / / / |/| | | | | |
* | | | | | | Add Sentdex server to whitelistGravatar Leon Sandøy2020-02-23-0/+1
| | | | | | |
* | | | | | | Merge pull request #773 from python-discord/reminder_missing_usersGravatar Joseph2020-02-23-17/+37
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Check reminder user and channel before send and schedule.
| * \ \ \ \ \ \ Merge branch 'master' into reminder_missing_usersGravatar Joseph2020-02-23-120/+101
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
* | | | | | | | Merge pull request #776 from python-discord/checkout-msg-logGravatar S. Co12020-02-23-14/+13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Change verification post log level to info, tidy code.
| * \ \ \ \ \ \ \ Merge branch 'master' into checkout-msg-logGravatar S. Co12020-02-23-2/+6
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #756 from python-discord/bug/backend/s329/docker-compose-ttyGravatar scragly2020-02-24-0/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix missing Django logs when using Docker Compose
| * \ \ \ \ \ \ \ \ Merge branch 'master' into bug/backend/s329/docker-compose-ttyGravatar scragly2020-02-24-571/+888
| |\ \ \ \ \ \ \ \ \
| * | | | | | | | | | Fix missing Django logs when using Docker ComposeGravatar MarkKoz2020-02-16-0/+2
| | |_|_|_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed by allocating a pseudo-tty to the web and bot services in Docker Compose.
* | | | | | | | | | Merge pull request #774 from python-discord/cooldown-log-levelGravatar S. Co12020-02-23-2/+4
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | Reduce log level of tag cooldown notice.
| * | | | | | | | | Reduce log level of tag cooldown notice.Gravatar scragly2020-02-24-2/+4
|/ / / / / / / / /
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-29 13:02:46 +0000