aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| * | | | | | | | Use Mock Side Effect Instead Of Extra FunctionGravatar Hassan Abouelela2021-03-10-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes the mock used for creating an erroneous function in the silence tests cog to use the side effect property instead of an extra function. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | Simplifies Redundant Unsilence Target TestGravatar Hassan Abouelela2021-03-10-33/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes redundant functionality from the `test_unsilence_helper_fail` test as it is covered by another test. Keeps the functionality that isn't being tested elsewhere. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | Combine Silence Target TestsGravatar Hassan Abouelela2021-03-10-39/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Combine two tests that are responsible for checking the silence helper uses the correct channel and message. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | Merge branch 'master' into voicechannel-muteGravatar Hassan Abouelela2021-03-10-477/+934
| |\ \ \ \ \ \ \ \
| * | | | | | | | | Modifies Silence TestsGravatar Hassan Abouelela2021-02-05-15/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a missing test assertion, and seperates the voice and text components of a test. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | Modifies Silence TestsGravatar Hassan Abouelela2021-02-05-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a missing test assertion, and seperates the voice and text components of a test. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | Separates Voice Overwrite TestsGravatar Hassan Abouelela2021-02-04-9/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | Adds Move To Failure TestsGravatar Hassan Abouelela2021-02-04-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | Merge remote-tracking branch 'origin/voicechannel-mute' into voicechannel-muteGravatar Hassan Abouelela2021-02-04-1/+1
| |\ \ \ \ \ \ \ \ \
| | * | | | | | | | | Modifies Channel Creation ReasonGravatar Hassan Abouelela2021-02-04-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Matteo Bertucci <[email protected]>
| * | | | | | | | | | Updates Voice Kick Restriction TestsGravatar Hassan Abouelela2021-02-04-11/+19
| |/ / / / / / / / /
| * | | | | | | | | Restricts Voice Silence Skip To Mod RolesGravatar Hassan Abouelela2021-02-04-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Raises the permission required to not be muted during a voice silence to moderation roles.
| * | | | | | | | | Updates Voice Channel ConfigGravatar Hassan Abouelela2021-02-04-12/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the new voice and text channels to the default config, and renames all affected channels in the config and constants to match the new names.
| * | | | | | | | | Merge branch 'master' into voicechannel-muteGravatar Hassan Abouelela2021-02-04-1414/+1799
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # Conflicts: # bot/constants.py
| * | | | | | | | | | Cleans Up Voice Sync TestsGravatar Hassan Abouelela2021-01-10-18/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleans up the tests related to the voice sync/kick functions by adding a helper method to simplify mocking.
| * | | | | | | | | | Cleans Up & Simplifies TestsGravatar Hassan Abouelela2021-01-10-80/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleans up the silence tests by removing unneeded or repeated mocks. Simplifies tests where possible by joining similar tests.
| * | | | | | | | | | Improves Unsilence Wrapper DocstringGravatar Hassan Abouelela2021-01-10-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modifies the unsilence wrapper docstring to make the arguments and behavior more clear.
| * | | | | | | | | | Breaks Out Send Message TestsGravatar Hassan Abouelela2020-12-29-75/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moves the tests for the helper method `send_message` to simplify tests, and avoid repeated code.
| * | | | | | | | | | Makes Kick Keyword Only ParameterGravatar Hassan Abouelela2020-12-29-3/+3
| | | | | | | | | | |
| * | | | | | | | | | Adds Error Handling For Voice Channel MutingGravatar Hassan Abouelela2020-12-29-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds error handlers to allow voice channel muting to handle as many members as possible.
| * | | | | | | | | | Refractors Helper Method SignaturesGravatar Hassan Abouelela2020-12-29-27/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes the signatures of a few helper methods to make them more concise and understandable.
| * | | | | | | | | | Merge branch 'master' into voicechannel-muteGravatar Hassan Abouelela2020-12-29-160/+238
| |\ \ \ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ \ \ Merge branch 'master' into voicechannel-muteGravatar Hassan Abouelela2020-12-22-445/+644
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela<[email protected]> # Conflicts # bot/exts/moderation/silence.py # bot/exts/moderation/test_silence.py
| * | | | | | | | | | | | Fixes Voice Silence TestsGravatar Hassan Abouelela2020-12-01-34/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | Improves Voice Chat MatchingGravatar Hassan Abouelela2020-12-01-15/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes the way voice channels are matched with chat channels, to make it less hardcoded. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | Merge branch 'master' into voicechannel-muteGravatar Hassan Abouelela2020-12-01-1030/+1165
| |\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | Refractors According To Style GuideGravatar Hassan Abouelela2020-11-28-78/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates changes made in the PR to be more inline with style guide. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Refractors Voice Sync HelperGravatar Hassan Abouelela2020-11-28-91/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refractors the voice sync helper function into two different functions, one for each purpose. Moves the afk_channel get/creation code to its own function. Updates tests. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Clarifies Constants Use in SilenceGravatar Hassan Abouelela2020-11-28-23/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes all usages of bot.constant to use dotted path to remove confusion and namespace collision. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Updates Silence LockGravatar Hassan Abouelela2020-11-26-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modifies the lock on the silence command, in order to choose between ctx and channel arg based on input. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Reduces Redundant Code in Silence CogGravatar Hassan Abouelela2020-11-25-32/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restructures some code to make it more understandable and reduce duplication. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Refactors Send Message Function Gravatar Hassan Abouelela2020-11-25-11/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactors the send message utility function to make it more legible and reduce unnecessary calls. Co-authored-by: Mark <[email protected]>
| * | | | | | | | | | | | | Reduces IsInstance Calls Where PossibleGravatar Hassan Abouelela2020-11-24-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reduces redundant calls to isinstance by saving the result where applicable. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Reduces Redundancy in UnmuteGravatar Hassan Abouelela2020-11-24-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces a repeated hardcoded message with a dynamically built one. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Adds Connect to Reset PermissionsGravatar Hassan Abouelela2020-11-24-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During unsilencing, if the previous channel overwrites are None, the channel should default to None for all relevant permissions. Adds the connect permission as it was missing. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Fixes Typo in Silence TestsGravatar Hassan Abouelela2020-11-24-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Move VoiceChat Sync To _unsilenceGravatar Hassan Abouelela2020-11-24-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moves the call to voice chat sync from _unsilence_wrapper to _unsilence. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Moves VoiceChat Sync Out of Overwrites FunctionGravatar Hassan Abouelela2020-11-24-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | VoiceChat sync only needs to be called when the command is invoked, instead of while updating permissions. Moved call to command function to reflect that, and fixed failing tests. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Refractors SendMessage FunctionGravatar Hassan Abouelela2020-11-24-39/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refractors the send message function in silence to make it more understandable and flexible. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Fixes Typo in DocGravatar Hassan Abouelela2020-11-24-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Mark <[email protected]>
| * | | | | | | | | | | | | Removes AnyChannel ConverterGravatar Hassan Abouelela2020-11-24-91/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes the AnyChannel converter in favor of a combination of Text and Voice converters. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Fixes Voice Channel AccessGravatar Hassan Abouelela2020-11-24-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A typo caused the function to return the text channel for `code/help 1`, when it is meant to access `code/help 2`. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Refractors For Style GuidelinesGravatar Hassan Abouelela2020-11-24-13/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refractors method signatures and calls to follow python-discord style guide. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Finalizes Silence & Unsilence UnitTestsGravatar Hassan Abouelela2020-11-23-17/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Adds Silence & Unsilence UnitTestsGravatar Hassan Abouelela2020-11-23-1/+211
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Removes Redundant Exception HandlingGravatar Hassan Abouelela2020-11-23-38/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | General Silence Class TestsGravatar Hassan Abouelela2020-11-23-17/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds tests for helper functions in the silence cog. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Fixes Voice Silence ReportingGravatar Hassan Abouelela2020-11-23-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes the channel reported as muted to voice channel chat channels when silencing voice channels. Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Fix Failing FunctionsGravatar Hassan Abouelela2020-11-23-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hassan Abouelela <[email protected]>
| * | | | | | | | | | | | | Make Voice Channel Kick OptionalGravatar Hassan Abouelela2020-11-23-16/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds an optional parameter to the silence command to enable moderators to choose if they only update permissions, or kick members too. As an accompanying feature, the unsilence command now syncs voice channel permissions too. Signed-off-by: Hassan Abouelela <[email protected]>