aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
* | | | | | | Merge pull request #934 from python-discord/bug/filters/933/dont-delete-in-dmsGravatar Dennis Pham2020-05-23-4/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Filtering: don't delete messages in DMs
| * \ \ \ \ \ \ Merge branch 'master' into bug/filters/933/dont-delete-in-dmsGravatar Dennis Pham2020-05-23-585/+786
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
| * | | | | | | Filtering: don't delete messages in DMsGravatar MarkKoz2020-05-09-4/+6
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | Bots are incapable of deleting direct messages authored by others.
| | | | * | | Show a warning when redis pool isn't closedGravatar MarkKoz2020-05-23-0/+5
| | | | | | |
| | | | * | | Remove redis session mock from MockBotGravatar MarkKoz2020-05-23-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's not feasible to mock it because all the commands return futures rather than being coroutines, so they cannot automatically be turned into AsyncMocks. Furthermore, no code should ever use the redis session directly besides RedisCache. Since the tests for RedisCache already use fakeredis, there's no use in trying to mock redis in MockBot.
| | | | * | | DRY approach to typestring prefix resolutionGravatar Leon Sandøy2020-05-23-15/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thanks to @kwzrd for this idea, basically we're making a constant with the typestring prefixes and iterating that in all our converters. These converter functions will also now raise TypeErrors if we try to convert something that isn't in this constants list. I've also added a new test that tests this functionality.
| | | | * | | Don't rely on HDEL ignoring keys for .popGravatar Leon Sandøy2020-05-23-2/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would try to .delete keys that did not exist if a default was provided when calling .pop. This is okay to do (because HDEL will just ignore any attempts to delete non-existing calls), but it does add an additional pointless API call to Redis, so I've added some validation as a small optimization. This also adds a few additional lines of documentation as requested by @SebastiaanZ in their review.
| | | | * | | Fix typo in test_to_dict docstringGravatar Leon Sandøy2020-05-23-1/+1
| | | | | | |
| | | | * | | Update exception message Gravatar Leon Sandøy2020-05-23-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was incorrectly suggesting the user needed to create an instance of RedisCache, when in fact it is the parent that needs to be instantiated. Co-authored-by: Sebastiaan Zeeff <[email protected]>
| | | | * | | CI needs REDIS_PASSWORD to pass testsGravatar Leon Sandøy2020-05-23-0/+1
| | | | | | |
| | | | * | | Moving the Redis session creation to Bot._recreateGravatar Leon Sandøy2020-05-23-2/+5
| | | | | | |
| | | | * | | Unbreak the error_handlerGravatar Leon Sandøy2020-05-23-1/+1
| | | | | | |
| | | | * | | Merge branch 'redis_persistence' of github.com:python-discord/bot into ↵Gravatar Leon Sandøy2020-05-23-44/+127
| | | | |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | redis_persistence
| | | | | * \ \ Merge branch 'master' into redis_persistenceGravatar Leon Sandøy2020-05-23-44/+127
| | | | | |\ \ \ | |_|_|_|_|/ / / |/| | | | | | |
* | | | | | | | Merge pull request #945 from ks129/statsGravatar Joseph Banks2020-05-22-1/+36
|\ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ Merge branch 'master' into statsGravatar Joseph Banks2020-05-22-505/+362
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #942 from ks129/python-news-statsGravatar Joseph Banks2020-05-22-0/+6
|\ \ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ Merge branch 'master' into python-news-statsGravatar Mark2020-05-20-505/+356
| |\ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | |
| * | | | | | | | | Merge branch 'master' into python-news-statsGravatar ks1292020-05-14-2/+1
| |\ \ \ \ \ \ \ \ \
| * | | | | | | | | | Python News: Implement statsGravatar ks1292020-05-14-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add stat increaser to PEP and maillist posting.
| | | * | | | | | | | Eval Stats: Replaced `elif` with `else` on icon checkGravatar ks1292020-05-22-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Mark <[email protected]>
| | | * | | | | | | | Stats: Fix docstringsGravatar ks1292020-05-19-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Joseph Banks <[email protected]>
| | | * | | | | | | | Stats: Fixed stat namesGravatar ks1292020-05-19-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Joseph Banks <[email protected]>
| | | * | | | | | | | Stats: Added stats for eval channel using (Help/Bot commands/Topical)Gravatar ks1292020-05-16-0/+7
| | | | | | | | | | |
| | | * | | | | | | | Stats: Added stats for eval role uses (Helpers/Developers)Gravatar ks1292020-05-16-0/+5
| | | | | | | | | | |
| | | * | | | | | | | Stats: Added stats for eval successes + failsGravatar ks1292020-05-16-0/+6
| | | | | | | | | | |
| | | * | | | | | | | Stats: Added codeblock correction statsGravatar ks1292020-05-16-0/+2
| | | | | | | | | | |
| | | * | | | | | | | Stats: Create guild boost stat collectionGravatar ks1292020-05-16-1/+16
| | |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collect Guild boost amount + level and post it to StatsD every hour in task. Added starting to cog `__init__.py` and stopping to `cog_unload`.
| | | | | | * / / / Better docstring for RedisCache.containsGravatar Leon Sandøy2020-05-23-1/+5
| | | | | | |/ / /
| | | | | | * | | Better docstring for RedisCacheGravatar Leon Sandøy2020-05-23-1/+31
| | | | | | | | |
| | | | | | * | | Complete asyncified test suite for RedisCacheGravatar Leon Sandøy2020-05-23-94/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit just alters existing code to work with the new interface, and with async. All tests are passing successfully.
| | | | | | * | | Finish asyncifying RedisCache methodsGravatar Leon Sandøy2020-05-23-16/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - All methods will now do a validation check - Complete interface spec added to class: - .update - .clear - .pop - .to_dict - .length - .contains - .delete - .get - .set
| | | | | | * | | Finish .set and .get, and add tests.Gravatar Leon Sandøy2020-05-23-25/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The .set and .get will accept ints, floats, and strings. These will be converted into "typestrings", which is basically just a simple format that's been invented for this object. For example, an int looks like `b"i|2423"`. Note how it is still stored as a bytestring (like everything in Redis), but because of this prefix we are able to coerce it into the type we want on the way out of the db.
| | | | | | * | | Use autospecced mocks in MockBot for the stats and aiohttp sessionGravatar MarkKoz2020-05-22-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will help catch anything that tries to get/set an attribute/method which doesn't exist. It'll also catch missing/too many parameters being passed to methods.
| | | | | | * | | Properly mock the redis pool in MockBotGravatar MarkKoz2020-05-22-9/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because some of the redis pool/connection methods return futures rather than being coroutines, the redis pool had to be mocked using the CustomMockMixin so it could take advantage of `additional_spec_asyncs` to use AsyncMocks for these future-returning methods.
| | | | | | * | | Fix unawaited coro warning when instantiating Bot for MockBot's specGravatar MarkKoz2020-05-22-10/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fix is to mock the loop and pass it to the Bot. It will then set it as `self.loop` rather than trying to get an event loop from asyncio. The `create_task` patch has been moved to this loop mock rather than being done in MockBot to ensure that it applies to anything calling it when instantiating the Bot.
| | | | | | * | | Improve aiohttp context manager mocking in snekbox testsGravatar MarkKoz2020-05-22-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not sure how it even managed to work before. It was calling the `post` coroutine (without specifying a URL) and then changing `__aenter__`. Now, a separate mock is created for the context manager and the `post` simply returns that mocked context manager.
| | | | | | * | | Fix assertion for `create_task` in duck pond testsGravatar MarkKoz2020-05-22-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The assertion wasn't using the assertion method. Furthermore, it was testing a non-existent function `create_loop` rather than `create_task`.
| | | | | | * | | Set up async testbedGravatar Leon Sandøy2020-05-22-198/+135
| | | | | | | | |
| | | | | | * | | Opens a Redis connection in the Bot class.Gravatar Leon Sandøy2020-05-22-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This global connection is the one we will be using in RedisCache to power all our commands. This also ensures that connection is closed when the bot starts its shutdown process.
| | | | | | * | | Replace redis-py with aioredis.Gravatar Leon Sandøy2020-05-22-60/+104
| | | | | | | | |
| | | | | | * | | Add the REDIS_PASSWORD environment variableGravatar Leon Sandøy2020-05-22-137/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In production, we will need this password to make a connection to Redis.
| | | | | | * | | Add the REDIS_PASSWORD environment variableGravatar Leon Sandøy2020-05-17-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In production, we will need this password to make a connection to Redis.
| | | | | | * | | Changes discord-py to discord.py in PipfileGravatar Leon Sandøy2020-05-17-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `discord-py` package is no longer the official release, and so making this change silences some warnings about deprecation.
| | | | | | * | | Merge branch 'master' into redis_persistenceGravatar Leon Sandøy2020-05-17-460/+269
| | | | | | |\ \ \
| | | | | | * | | | Fix linting errors introduced by flake8 3.8Gravatar Leon Sandøy2020-05-17-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turns out that bumping the flake8 version up to 3.8 introduces a long list of new linting errors. Since this PR is the one that bumps the version, I suppose we will also fix all the linting errors in this branch.
| | | | | | * | | | Merge branch 'master' into redis_persistenceGravatar Leon Sandøy2020-05-17-1/+1
| | | | | | |\ \ \ \
| | | | | | * | | | | namespace "general" -> "global"Gravatar Leon Sandøy2020-05-17-1/+1
| | | | | | | | | | |
| | | | | | * | | | | Make redis host and port configurable.Gravatar Leon Sandøy2020-05-17-1/+11
| | | | | | | | | | |
| | | | | | * | | | | Test suite for the redis dict.Gravatar Leon Sandøy2020-05-17-0/+189
| | | | | | | | | | |