diff options
-rw-r--r-- | bot/exts/info/information.py | 2 | ||||
-rw-r--r-- | bot/exts/moderation/infraction/infractions.py | 2 | ||||
-rw-r--r-- | bot/exts/moderation/infraction/management.py | 2 | ||||
-rw-r--r-- | bot/exts/moderation/infraction/superstarify.py | 2 | ||||
-rw-r--r-- | bot/exts/moderation/modpings.py | 2 | ||||
-rw-r--r-- | bot/exts/moderation/stream.py | 2 | ||||
-rw-r--r-- | bot/exts/moderation/watchchannels/_watchchannel.py | 2 | ||||
-rw-r--r-- | bot/exts/recruitment/talentpool/_cog.py | 2 | ||||
-rw-r--r-- | bot/exts/recruitment/talentpool/_review.py | 2 | ||||
-rw-r--r-- | bot/exts/utils/reminders.py | 2 | ||||
-rw-r--r-- | bot/utils/members.py | 18 |
11 files changed, 10 insertions, 28 deletions
diff --git a/bot/exts/info/information.py b/bot/exts/info/information.py index ab9185867..c7ee9065c 100644 --- a/bot/exts/info/information.py +++ b/bot/exts/info/information.py @@ -11,6 +11,7 @@ from discord import AllowedMentions, Colour, Embed, Guild, Message, Role from discord.ext.commands import BucketType, Cog, Context, Paginator, command, group, has_any_role from discord.utils import escape_markdown from pydis_core.site_api import ResponseCodeError +from pydis_core.utils.members import get_or_fetch_member from bot import constants from bot.bot import Bot @@ -22,7 +23,6 @@ from bot.pagination import LinePaginator from bot.utils import time from bot.utils.channel import is_mod_channel, is_staff_channel from bot.utils.checks import cooldown_with_role_bypass, has_no_roles_check, in_whitelist_check -from bot.utils.members import get_or_fetch_member log = get_logger(__name__) diff --git a/bot/exts/moderation/infraction/infractions.py b/bot/exts/moderation/infraction/infractions.py index 15d80cd58..6af2571de 100644 --- a/bot/exts/moderation/infraction/infractions.py +++ b/bot/exts/moderation/infraction/infractions.py @@ -8,6 +8,7 @@ from dateutil.relativedelta import relativedelta from discord import Member from discord.ext import commands from discord.ext.commands import Context, command +from pydis_core.utils.members import get_or_fetch_member from bot import constants from bot.bot import Bot @@ -18,7 +19,6 @@ from bot.exts.moderation.infraction import _utils from bot.exts.moderation.infraction._scheduler import InfractionScheduler from bot.log import get_logger from bot.utils.channel import is_mod_channel -from bot.utils.members import get_or_fetch_member from bot.utils.messages import format_user log = get_logger(__name__) diff --git a/bot/exts/moderation/infraction/management.py b/bot/exts/moderation/infraction/management.py index bff27840b..6af523bb0 100644 --- a/bot/exts/moderation/infraction/management.py +++ b/bot/exts/moderation/infraction/management.py @@ -6,6 +6,7 @@ import discord from discord.ext import commands from discord.ext.commands import Context from discord.utils import escape_markdown +from pydis_core.utils.members import get_or_fetch_member from bot import constants from bot.bot import Bot @@ -20,7 +21,6 @@ from bot.log import get_logger from bot.pagination import LinePaginator from bot.utils import messages, time from bot.utils.channel import is_in_category, is_mod_channel -from bot.utils.members import get_or_fetch_member from bot.utils.time import unpack_duration log = get_logger(__name__) diff --git a/bot/exts/moderation/infraction/superstarify.py b/bot/exts/moderation/infraction/superstarify.py index 7de4d08b0..006334755 100644 --- a/bot/exts/moderation/infraction/superstarify.py +++ b/bot/exts/moderation/infraction/superstarify.py @@ -6,6 +6,7 @@ from pathlib import Path from discord import Embed, Member from discord.ext.commands import Cog, Context, command, has_any_role from discord.utils import escape_markdown +from pydis_core.utils.members import get_or_fetch_member from bot import constants from bot.bot import Bot @@ -15,7 +16,6 @@ from bot.exts.moderation.infraction import _utils from bot.exts.moderation.infraction._scheduler import InfractionScheduler from bot.log import get_logger from bot.utils import time -from bot.utils.members import get_or_fetch_member from bot.utils.messages import format_user log = get_logger(__name__) diff --git a/bot/exts/moderation/modpings.py b/bot/exts/moderation/modpings.py index ca05f2c25..002bc4cfe 100644 --- a/bot/exts/moderation/modpings.py +++ b/bot/exts/moderation/modpings.py @@ -6,13 +6,13 @@ from async_rediscache import RedisCache from dateutil.parser import isoparse, parse as dateutil_parse from discord import Member from discord.ext.commands import Cog, Context, group, has_any_role +from pydis_core.utils.members import get_or_fetch_member from pydis_core.utils.scheduling import Scheduler from bot.bot import Bot from bot.constants import Emojis, Guild, MODERATION_ROLES, Roles from bot.converters import Expiry from bot.log import get_logger -from bot.utils.members import get_or_fetch_member from bot.utils.time import TimestampFormats, discord_timestamp log = get_logger(__name__) diff --git a/bot/exts/moderation/stream.py b/bot/exts/moderation/stream.py index 6cc5c4c51..6ffae1e6e 100644 --- a/bot/exts/moderation/stream.py +++ b/bot/exts/moderation/stream.py @@ -7,6 +7,7 @@ from arrow import Arrow from async_rediscache import RedisCache from discord.ext import commands from pydis_core.utils import scheduling +from pydis_core.utils.members import get_or_fetch_member from bot.bot import Bot from bot.constants import ( @@ -22,7 +23,6 @@ from bot.converters import Expiry from bot.log import get_logger from bot.pagination import LinePaginator from bot.utils import time -from bot.utils.members import get_or_fetch_member log = get_logger(__name__) diff --git a/bot/exts/moderation/watchchannels/_watchchannel.py b/bot/exts/moderation/watchchannels/_watchchannel.py index eb6b6ebf3..37b02f916 100644 --- a/bot/exts/moderation/watchchannels/_watchchannel.py +++ b/bot/exts/moderation/watchchannels/_watchchannel.py @@ -12,6 +12,7 @@ from discord.ext.commands import Cog, Context from pydis_core.site_api import ResponseCodeError from pydis_core.utils import scheduling from pydis_core.utils.channel import get_or_fetch_channel +from pydis_core.utils.members import get_or_fetch_member from bot.bot import Bot from bot.constants import BigBrother as BigBrotherConfig, Guild as GuildConfig, Icons @@ -21,7 +22,6 @@ from bot.exts.moderation.modlog import ModLog from bot.log import CustomLogger, get_logger from bot.pagination import LinePaginator from bot.utils import CogABCMeta, messages, time -from bot.utils.members import get_or_fetch_member log = get_logger(__name__) diff --git a/bot/exts/recruitment/talentpool/_cog.py b/bot/exts/recruitment/talentpool/_cog.py index b26771022..bc82de060 100644 --- a/bot/exts/recruitment/talentpool/_cog.py +++ b/bot/exts/recruitment/talentpool/_cog.py @@ -10,6 +10,7 @@ from discord.ext import commands, tasks from discord.ext.commands import BadArgument, Cog, Context, group, has_any_role from pydis_core.site_api import ResponseCodeError from pydis_core.utils.channel import get_or_fetch_channel +from pydis_core.utils.members import get_or_fetch_member from bot.bot import Bot from bot.constants import Bot as BotConfig, Channels, Emojis, Guild, MODERATION_ROLES, Roles, STAFF_ROLES @@ -19,7 +20,6 @@ from bot.exts.recruitment.talentpool._review import Reviewer from bot.log import get_logger from bot.pagination import LinePaginator from bot.utils import time -from bot.utils.members import get_or_fetch_member AUTOREVIEW_ENABLED_KEY = "autoreview_enabled" REASON_MAX_CHARS = 1000 diff --git a/bot/exts/recruitment/talentpool/_review.py b/bot/exts/recruitment/talentpool/_review.py index 7c40f737a..8752669a3 100644 --- a/bot/exts/recruitment/talentpool/_review.py +++ b/bot/exts/recruitment/talentpool/_review.py @@ -12,13 +12,13 @@ from async_rediscache import RedisCache from discord import Embed, Emoji, Member, Message, NotFound, PartialMessage, TextChannel from pydis_core.site_api import ResponseCodeError from pydis_core.utils.channel import get_or_fetch_channel +from pydis_core.utils.members import get_or_fetch_member from bot.bot import Bot from bot.constants import Channels, Colours, Emojis, Guild, Roles from bot.exts.recruitment.talentpool._api import Nomination, NominationAPI from bot.log import get_logger from bot.utils import time -from bot.utils.members import get_or_fetch_member from bot.utils.messages import count_unique_users_reaction if typing.TYPE_CHECKING: diff --git a/bot/exts/utils/reminders.py b/bot/exts/utils/reminders.py index 8b0cbed77..fcf291d1b 100644 --- a/bot/exts/utils/reminders.py +++ b/bot/exts/utils/reminders.py @@ -9,6 +9,7 @@ from dateutil.parser import isoparse from discord.ext.commands import Cog, Context, Greedy, group from pydis_core.site_api import ResponseCodeError from pydis_core.utils import scheduling +from pydis_core.utils.members import get_or_fetch_member from pydis_core.utils.scheduling import Scheduler from bot.bot import Bot @@ -29,7 +30,6 @@ from bot.pagination import LinePaginator from bot.utils import time from bot.utils.checks import has_any_role_check, has_no_roles_check from bot.utils.lock import lock_arg -from bot.utils.members import get_or_fetch_member from bot.utils.messages import send_denial log = get_logger(__name__) diff --git a/bot/utils/members.py b/bot/utils/members.py index 08ee78504..838614b6f 100644 --- a/bot/utils/members.py +++ b/bot/utils/members.py @@ -7,24 +7,6 @@ from bot.log import get_logger log = get_logger(__name__) -async def get_or_fetch_member(guild: discord.Guild, member_id: int) -> discord.Member | None: - """ - Attempt to get a member from cache; on failure fetch from the API. - - Return `None` to indicate the member could not be found. - """ - if member := guild.get_member(member_id): - log.trace("%s retrieved from cache.", member) - else: - try: - member = await guild.fetch_member(member_id) - except discord.errors.NotFound: - log.trace("Failed to fetch %d from API.", member_id) - return None - log.trace("%s fetched from API.", member) - return member - - async def handle_role_change( member: discord.Member, coro: t.Callable[..., t.Coroutine], |