diff options
| author | 2021-06-06 00:34:20 -0700 | |
|---|---|---|
| committer | 2021-06-06 00:34:20 -0700 | |
| commit | d510a6af7d6158009ef23fefd44f1e06bdb33876 (patch) | |
| tree | bc2c7512a19d8cbd09561c8ca3896edec9edb6e5 /tests | |
| parent | Added .txt file extension to antimalware test. (diff) | |
Added subtests for `.txt`, `.json`, and `.csv` files.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/bot/exts/filters/test_antimalware.py | 44 | 
1 files changed, 28 insertions, 16 deletions
| diff --git a/tests/bot/exts/filters/test_antimalware.py b/tests/bot/exts/filters/test_antimalware.py index 9f020c964..359401814 100644 --- a/tests/bot/exts/filters/test_antimalware.py +++ b/tests/bot/exts/filters/test_antimalware.py @@ -105,24 +105,36 @@ class AntiMalwareCogTests(unittest.IsolatedAsyncioTestCase):      async def test_txt_file_redirect_embed_description(self):          """A message containing a .txt file should result in the correct embed.""" -        attachment = MockAttachment(filename="python.txt") -        self.message.attachments = [attachment] -        self.message.channel.send = AsyncMock() -        antimalware.TXT_EMBED_DESCRIPTION = Mock() -        antimalware.TXT_EMBED_DESCRIPTION.format.return_value = "test" - -        await self.cog.on_message(self.message) -        self.message.channel.send.assert_called_once() -        args, kwargs = self.message.channel.send.call_args -        embed = kwargs.pop("embed") -        cmd_channel = self.bot.get_channel(Channels.bot_commands) - -        self.assertEqual(embed.description, antimalware.TXT_EMBED_DESCRIPTION.format.return_value) -        antimalware.TXT_EMBED_DESCRIPTION.format.assert_called_with( -            blocked_extension_str=".txt", -            cmd_channel_mention=cmd_channel.mention +        test_values = ( +            ("text", ".txt"), +            ("json", ".json"), +            ("csv", ".csv"),          ) +        for file_name, disallowed_extension in test_values: +            with self.subTest(file_name=file_name, disallowed_extension=disallowed_extension): + +                attachment = MockAttachment(filename=f"{file_name}{disallowed_extension}") +                self.message.attachments = [attachment] +                self.message.channel.send = AsyncMock() +                antimalware.TXT_EMBED_DESCRIPTION = Mock() +                antimalware.TXT_EMBED_DESCRIPTION.format.return_value = "test" + +                await self.cog.on_message(self.message) +                self.message.channel.send.assert_called_once() +                args, kwargs = self.message.channel.send.call_args +                embed = kwargs.pop("embed") +                cmd_channel = self.bot.get_channel(Channels.bot_commands) + +                self.assertEqual( +                    embed.description, +                    antimalware.TXT_EMBED_DESCRIPTION.format.return_value +                ) +                antimalware.TXT_EMBED_DESCRIPTION.format.assert_called_with( +                    blocked_extension_str=disallowed_extension, +                    cmd_channel_mention=cmd_channel.mention +                ) +      async def test_other_disallowed_extension_embed_description(self):          """Test the description for a non .py/.txt disallowed extension."""          attachment = MockAttachment(filename="python.disallowed") | 
